ARM Sunxi Platform Development
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org,
	mripard@kernel.org, ryan@testtoast.com, samuel@sholland.org,
	jernej.skrabec@gmail.com, wens@csie.org, conor+dt@kernel.org,
	krzk+dt@kernel.org, robh@kernel.org,
	Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH V2 2/4] arm64: dts: allwinner: h616: Add r_i2c pinctrl nodes
Date: Wed, 3 Jul 2024 14:14:39 +0100	[thread overview]
Message-ID: <20240703141439.1807b865@donnerap.manchester.arm.com> (raw)
In-Reply-To: <20240702193414.57461-3-macroalpha82@gmail.com>

On Tue,  2 Jul 2024 14:34:12 -0500
Chris Morgan <macroalpha82@gmail.com> wrote:

> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Add pinctrl nodes for the r_i2c node. Without the pinmux defined the
> r_i2c bus may fail to work, possibly if the bootloader uses rsb mode
> for the PMIC.

Yes, those are the only pins available, checked against the manual.

> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> index 921d5f61d8d6..e31945c3895e 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> @@ -837,6 +837,8 @@ r_i2c: i2c@7081400 {
>  			dmas = <&dma 48>, <&dma 48>;
>  			dma-names = "rx", "tx";
>  			resets = <&r_ccu RST_R_APB2_I2C>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&r_i2c_pins>;
>  			status = "disabled";
>  			#address-cells = <1>;
>  			#size-cells = <0>;


  reply	other threads:[~2024-07-03 13:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02 19:34 [PATCH V2 0/4] Add Anbernic RG35XX-SP Chris Morgan
2024-07-02 19:34 ` [PATCH V2 1/4] dt-bindings: arm: sunxi: Add Anbernic RG35XXSP Chris Morgan
2024-07-03  5:11   ` Krzysztof Kozlowski
2024-07-05 16:48     ` Chris Morgan
2024-07-02 19:34 ` [PATCH V2 2/4] arm64: dts: allwinner: h616: Add r_i2c pinctrl nodes Chris Morgan
2024-07-03 13:14   ` Andre Przywara [this message]
2024-07-03 23:39     ` Andre Przywara
2024-07-02 19:34 ` [PATCH V2 3/4] arm64: dts: allwinner: h616: Change RG35XX Series from r_rsb to r_i2c Chris Morgan
2024-07-02 19:34 ` [PATCH V2 4/4] arm64: dts: allwinner: h700: Add Anbernic RG35XX-SP Chris Morgan
2024-07-03 14:27 ` [PATCH V2 0/4] " Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240703141439.1807b865@donnerap.manchester.arm.com \
    --to=andre.przywara@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=macroalpha82@gmail.com \
    --cc=macromorgan@hotmail.com \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=ryan@testtoast.com \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox