From: "Ryan Walklin" <ryan@testtoast.com>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Andre Przywara" <andre.przywara@arm.com>,
"Chen-Yu Tsai" <wens@csie.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Chris Morgan" <macromorgan@hotmail.com>
Cc: devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 2/4] arm64: dts: allwinner: h700: Add RG35XX 2024 DTS
Date: Wed, 17 Apr 2024 21:08:07 +1200 [thread overview]
Message-ID: <1eb4a701-e0f2-4615-aac6-53f10f762ada@app.fastmail.com> (raw)
In-Reply-To: <c615c0b0-3dd4-4bac-8bd5-654fd8a35d0c@linaro.org>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
> No uppercase letters are allowed as node names.
Apologies, this was my omission.
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
Noted, thanks.
>> +
>> + reg_vcc5v: vcc5v {
>
> Use some common reasonable prefix, e.g. regulator
>
Noted, thanks.
> Please do not add dead code without explanation.
Noted, thanks.
Regards,
Ryan
next prev parent reply other threads:[~2024-04-17 9:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 8:33 [PATCH 0/4] arm64: dts: allwinner: Add Anbernic RG35XX (Plus/H/2024) support Ryan Walklin
2024-04-14 8:33 ` [PATCH 1/4] dt-bindings: arm: sunxi: document Anbernic RG35XX handheld gaming device variants Ryan Walklin
2024-04-14 9:07 ` Krzysztof Kozlowski
2024-04-17 9:05 ` Ryan Walklin
2024-04-17 13:33 ` Krzysztof Kozlowski
2024-04-17 13:58 ` Andre Przywara
2024-04-17 19:22 ` Krzysztof Kozlowski
2024-04-17 9:54 ` Andre Przywara
2024-04-17 19:22 ` Krzysztof Kozlowski
2024-04-14 8:33 ` [PATCH 2/4] arm64: dts: allwinner: h700: Add RG35XX 2024 DTS Ryan Walklin
2024-04-14 9:09 ` Krzysztof Kozlowski
2024-04-17 9:08 ` Ryan Walklin [this message]
2024-04-14 17:46 ` Andre Przywara
2024-04-14 8:33 ` [PATCH 3/4] arm64: dts: allwinner: h700: Add RG35XX-Plus DTS Ryan Walklin
2024-04-14 9:10 ` Krzysztof Kozlowski
2024-04-14 18:37 ` Andre Przywara
2024-04-14 8:33 ` [PATCH 4/4] arm64: dts: allwinner: h700: Add RG35XX-H DTS Ryan Walklin
2024-04-15 0:12 ` Andre Przywara
2024-04-15 18:46 ` [PATCH 0/4] arm64: dts: allwinner: Add Anbernic RG35XX (Plus/H/2024) support Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eb4a701-e0f2-4615-aac6-53f10f762ada@app.fastmail.com \
--to=ryan@testtoast.com \
--cc=andre.przywara@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=macromorgan@hotmail.com \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox