From: Andre Przywara <andre.przywara@arm.com>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mesih Kilinc <mesihkilinc@gmail.com>,
Icenowy Zheng <icenowy@aosc.io>,
Jesse Taube <mr.bossman075@gmail.com>,
Giulio Benetti <giulio.benetti@benettiengineering.com>,
George Hilliard <thirtythreeforty@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org
Subject: [PATCH v2 03/12] ARM: dts: suniv: F1C100: fix watchdog compatible
Date: Thu, 17 Mar 2022 16:23:40 +0000 [thread overview]
Message-ID: <20220317162349.739636-4-andre.przywara@arm.com> (raw)
In-Reply-To: <20220317162349.739636-1-andre.przywara@arm.com>
The F1C100 series of SoCs actually have their watchdog IP being
compatible with the newer Allwinner generation, not the older one.
The currently described sun4i-a10-wdt actually does not work, neither
the watchdog functionality (just never fires), nor the reset part
(reboot hangs).
Replace the compatible string with the one used by the newer generation.
Verified to work with both the watchdog and reboot functionality on a
LicheePi Nano.
Also add the missing interrupt line and clock source, to make it binding
compliant.
Fixes: 4ba16d17efdd ("ARM: dts: suniv: add initial DTSI file for F1C100s")
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Guenter Roeck <linux@roeck-us.net>
---
arch/arm/boot/dts/suniv-f1c100s.dtsi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/suniv-f1c100s.dtsi b/arch/arm/boot/dts/suniv-f1c100s.dtsi
index 6100d3b75f61..def830101448 100644
--- a/arch/arm/boot/dts/suniv-f1c100s.dtsi
+++ b/arch/arm/boot/dts/suniv-f1c100s.dtsi
@@ -104,8 +104,10 @@ timer@1c20c00 {
wdt: watchdog@1c20ca0 {
compatible = "allwinner,suniv-f1c100s-wdt",
- "allwinner,sun4i-a10-wdt";
+ "allwinner,sun6i-a31-wdt";
reg = <0x01c20ca0 0x20>;
+ interrupts = <16>;
+ clocks = <&osc32k>;
};
uart0: serial@1c25000 {
--
2.25.1
next prev parent reply other threads:[~2022-03-17 16:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 16:23 [PATCH v2 00/12] ARM: suniv: dts: update Allwinner F1C100 Andre Przywara
2022-03-17 16:23 ` [PATCH v2 01/12] dt-bindings: watchdog: sunxi: fix F1C100s compatible Andre Przywara
2022-03-20 19:06 ` Rob Herring
2022-03-28 4:20 ` Samuel Holland
2022-03-17 16:23 ` [PATCH v2 02/12] dt-bindings: watchdog: sunxi: clarify clock support Andre Przywara
2022-03-25 21:10 ` Rob Herring
2022-03-28 4:20 ` Samuel Holland
2022-04-04 14:04 ` Guenter Roeck
2022-03-17 16:23 ` Andre Przywara [this message]
2022-03-17 16:23 ` [PATCH v2 04/12] dt-bindings: arm: sunxi: document LicheePi Nano name Andre Przywara
2022-03-17 16:23 ` [PATCH v2 05/12] ARM: dts: suniv: F1C100: add clock and reset macros Andre Przywara
2022-03-17 16:23 ` [PATCH v2 06/12] ARM: dts: suniv: F1C100: fix CPU node Andre Przywara
2022-03-28 4:20 ` Samuel Holland
2022-03-17 16:23 ` [PATCH v2 07/12] ARM: dts: suniv: F1C100: fix timer node Andre Przywara
2022-03-17 16:23 ` [PATCH v2 08/12] ARM: dts: suniv: F1C100: add MMC controllers Andre Przywara
2022-03-17 16:23 ` [PATCH v2 09/12] ARM: dts: suniv: licheepi-nano: add microSD card Andre Przywara
2022-03-17 16:23 ` [PATCH v2 10/12] dt-bindings: spi: sunxi: document F1C100 controllers Andre Przywara
2022-03-17 16:23 ` [PATCH v2 11/12] ARM: dts: suniv: F1C100: add SPI support Andre Przywara
2022-03-28 4:20 ` Samuel Holland
2022-03-17 16:23 ` [PATCH v2 12/12] ARM: dts: suniv: licheepi-nano: add SPI flash Andre Przywara
2022-04-06 20:33 ` [PATCH v2 00/12] ARM: suniv: dts: update Allwinner F1C100 Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220317162349.739636-4-andre.przywara@arm.com \
--to=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mesihkilinc@gmail.com \
--cc=mr.bossman075@gmail.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=thirtythreeforty@gmail.com \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox