public inbox for linux-sunxi@lists.linux.dev
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: <broonie@kernel.org>, <samuel@sholland.org>
Cc: <matthias.bgg@gmail.com>, <wens@csie.org>,
	<jernej.skrabec@gmail.com>, <linux-mediatek@lists.infradead.org>,
	<linux-sunxi@lists.linux.dev>, <lgirdwood@gmail.com>,
	<alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] ASoC: mediatek: mt8186: Use new direct clock defines
Date: Mon, 13 Jun 2022 17:15:52 +0100	[thread overview]
Message-ID: <20220613161552.481337-2-ckeepax@opensource.cirrus.com> (raw)
In-Reply-To: <20220613161552.481337-1-ckeepax@opensource.cirrus.com>

Update this driver to the new direct clock producer/consumer defines. It
appears this driver was added with the inversion taken account of but
still uses the CODEC defines so no inversion of the producer/consumer
is necessary.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---

Note this patch is completely untested, I don't have hardware and the
mt8186 doesn't seem to be included in any makefiles at the moment so I
can't build test either. But the change is trivial and I am pretty
confident I have read the code correctly. It would be good if someone
from Mediatek could have a quick look over though.

Thanks,
Charles

 sound/soc/mediatek/mt8186/mt8186-dai-tdm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/mediatek/mt8186/mt8186-dai-tdm.c b/sound/soc/mediatek/mt8186/mt8186-dai-tdm.c
index dfff209b60da4..c6ead7c252f01 100644
--- a/sound/soc/mediatek/mt8186/mt8186-dai-tdm.c
+++ b/sound/soc/mediatek/mt8186/mt8186-dai-tdm.c
@@ -585,10 +585,10 @@ static int mtk_dai_tdm_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
 	}
 
 	switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
-	case SND_SOC_DAIFMT_CBP_CFP:
+	case SND_SOC_DAIFMT_BP_FP:
 		tdm_priv->slave_mode = false;
 		break;
-	case SND_SOC_DAIFMT_CBC_CFC:
+	case SND_SOC_DAIFMT_BC_FC:
 		tdm_priv->slave_mode = true;
 		break;
 	default:
-- 
2.30.2


  reply	other threads:[~2022-06-13 16:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13 16:15 [PATCH 1/2] ASoC: sun8i-codec: Partial revert to fix clock specifiers Charles Keepax
2022-06-13 16:15 ` Charles Keepax [this message]
2022-06-14  6:39 ` Samuel Holland
2022-06-14  9:15   ` Charles Keepax
2022-06-14 10:25 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220613161552.481337-2-ckeepax@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=matthias.bgg@gmail.com \
    --cc=patches@opensource.cirrus.com \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox