From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Samuel Holland <samuel@sholland.org>
Cc: <broonie@kernel.org>, <matthias.bgg@gmail.com>, <wens@csie.org>,
<jernej.skrabec@gmail.com>, <linux-mediatek@lists.infradead.org>,
<linux-sunxi@lists.linux.dev>, <lgirdwood@gmail.com>,
<alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ASoC: sun8i-codec: Partial revert to fix clock specifiers
Date: Tue, 14 Jun 2022 09:15:48 +0000 [thread overview]
Message-ID: <20220614091548.GC38351@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <9e105410-94d5-1801-8919-af8c0cef4de1@sholland.org>
On Tue, Jun 14, 2022 at 01:39:20AM -0500, Samuel Holland wrote:
> Hi Charles,
>
> On 6/13/22 11:15 AM, Charles Keepax wrote:
> > Recent updates accidentally updated the clock producer/consumer
> > specifiers on this device as part of refactoring the CPU side of the DAI
> > links. However, this device sits on the CODEC side and shouldn't have
> > been updated. Partially revert the changes keeping the switch to the new
> > clock terminology but going back to the CODEC defines.
> >
> > Fixes: 7cc3965fde74 ("ASoC: sunxi: Update to use set_fmt_new callback")
> > Reported-by: Samuel Holland <samuel@sholland.org>
> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
>
> Reviewed-by: Samuel Holland <samuel@sholland.org>
> Tested-by: Samuel Holland <samuel@sholland.org>
>
> Thanks for the quick follow-up, and sorry for the confusion my earlier comment
> caused. I verified that sound is broken (loud static) on a Pine A64-LTS board
> with for-next, and is fixed by this patch.
Not at all man, thank you for spotting my foolish mistake. Glad
we got it fixed up for you, and thank you for testing it.
Thanks,
Charles
next prev parent reply other threads:[~2022-06-14 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 16:15 [PATCH 1/2] ASoC: sun8i-codec: Partial revert to fix clock specifiers Charles Keepax
2022-06-13 16:15 ` [PATCH 2/2] ASoC: mediatek: mt8186: Use new direct clock defines Charles Keepax
2022-06-14 6:39 ` [PATCH 1/2] ASoC: sun8i-codec: Partial revert to fix clock specifiers Samuel Holland
2022-06-14 9:15 ` Charles Keepax [this message]
2022-06-14 10:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614091548.GC38351@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=matthias.bgg@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox