From: Andre Przywara <andre.przywara@arm.com>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Samuel Holland <samuel@sholland.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
u-boot@lists.denx.de, linux-sunxi@lists.linux.dev
Subject: [PATCH 0/3] sunxi: remove CONFIG_MMC?_CD_PIN
Date: Wed, 13 Jul 2022 17:21:42 +0100 [thread overview]
Message-ID: <20220713162145.95744-1-andre.przywara@arm.com> (raw)
Since the dawn of time we had CONFIG_MMC?_CD_PIN defines for each
Allwinner board, which held the name for the respective MMC card
detect GPIO. These days we don't use that in U-Boot proper anymore
(and rely on DT for that, instead), so it's just for the SPL loading.
However the card detect is actually not needed there:
- We continue loading from the same boot media that the BootROM booted
us from, so when we get to load from MMC, there is surely a card in
the slot.
- The BROM already spoiled all efforts by unconditionally accessing the
MMC bus, regardless of any card presence or not. We can't do more harm
by doing the same.
This series removes the code checking the CD pin, and also the definition
from Kconfig and all defconfigs. On top there is a cleanup for the MMC
driver, which explains the reason for still also implementing the legacy
MMC interface.
Please have a look and test!
Thanks,
Andre
Andre Przywara (3):
sunxi: mmc: ignore card detect in SPL
sunxi: mmc: group non-DM specific functions
sunxi: remove CONFIG_MMC?_CD_PIN
arch/arm/mach-sunxi/Kconfig | 27 ----
configs/A10-OLinuXino-Lime_defconfig | 1 -
configs/A10s-OLinuXino-M_defconfig | 2 -
configs/A13-OLinuXinoM_defconfig | 1 -
configs/A13-OLinuXino_defconfig | 1 -
configs/A20-OLinuXino-Lime2-eMMC_defconfig | 1 -
configs/A20-OLinuXino-Lime2_defconfig | 1 -
configs/A20-OLinuXino-Lime_defconfig | 1 -
configs/A20-OLinuXino_MICRO-eMMC_defconfig | 1 -
configs/A20-OLinuXino_MICRO_defconfig | 2 -
configs/A20-Olimex-SOM-EVB_defconfig | 2 -
configs/A20-Olimex-SOM204-EVB-eMMC_defconfig | 1 -
configs/A20-Olimex-SOM204-EVB_defconfig | 1 -
configs/A33-OLinuXino_defconfig | 1 -
configs/Ainol_AW1_defconfig | 1 -
configs/Ampe_A76_defconfig | 1 -
configs/Bananapi_M2_Ultra_defconfig | 1 -
configs/Bananapi_m2m_defconfig | 1 -
configs/Cubieboard2_defconfig | 1 -
configs/Cubieboard4_defconfig | 1 -
configs/Cubieboard_defconfig | 1 -
configs/Cubietruck_defconfig | 1 -
configs/Empire_electronix_d709_defconfig | 1 -
configs/Empire_electronix_m712_defconfig | 1 -
configs/Itead_Ibox_A20_defconfig | 1 -
configs/Lamobo_R1_defconfig | 1 -
configs/Mele_M3_defconfig | 1 -
configs/Mele_M5_defconfig | 1 -
configs/Merrii_A80_Optimus_defconfig | 1 -
configs/Orangepi_mini_defconfig | 2 -
configs/Sinlinx_SinA31s_defconfig | 1 -
configs/Sinlinx_SinA33_defconfig | 1 -
configs/Sunchip_CX-A99_defconfig | 1 -
configs/UTOO_P66_defconfig | 1 -
configs/Wobo_i5_defconfig | 1 -
configs/Yones_Toptech_BD1078_defconfig | 2 -
configs/Yones_Toptech_BS1078_V2_defconfig | 1 -
configs/bananapi_m2_berry_defconfig | 1 -
configs/bananapi_m2_zero_defconfig | 1 -
configs/bananapi_m64_defconfig | 1 -
configs/beelink_gs1_defconfig | 1 -
configs/colorfly_e708_q1_defconfig | 1 -
configs/difrnce_dit4350_defconfig | 1 -
configs/dserve_dsrv9703c_defconfig | 1 -
configs/gt90h_v4_defconfig | 1 -
configs/iNet_3F_defconfig | 1 -
configs/iNet_3W_defconfig | 1 -
configs/iNet_D978_rev2_defconfig | 1 -
configs/icnova-a20-swac_defconfig | 1 -
configs/inet86dz_defconfig | 1 -
configs/inet98v_rev2_defconfig | 1 -
configs/inet_q972_defconfig | 1 -
configs/nanopi_m1_plus_defconfig | 1 -
configs/oceanic_5205_5inmfd_defconfig | 1 -
configs/orangepi_3_defconfig | 1 -
configs/orangepi_lite2_defconfig | 1 -
configs/orangepi_one_plus_defconfig | 1 -
configs/orangepi_zero2_defconfig | 1 -
configs/orangepi_zero_plus2_defconfig | 1 -
configs/orangepi_zero_plus2_h3_defconfig | 1 -
configs/parrot_r16_defconfig | 1 -
configs/pine64-lts_defconfig | 1 -
configs/pine_h64_defconfig | 1 -
configs/polaroid_mid2407pxe03_defconfig | 1 -
configs/polaroid_mid2809pxe04_defconfig | 1 -
configs/q8_a13_tablet_defconfig | 1 -
configs/q8_a23_tablet_800x480_defconfig | 1 -
configs/q8_a33_tablet_1024x600_defconfig | 1 -
configs/q8_a33_tablet_800x480_defconfig | 1 -
configs/sopine_baseboard_defconfig | 1 -
configs/tanix_tx6_defconfig | 1 -
drivers/mmc/sunxi_mmc.c | 152 ++++++++-----------
72 files changed, 62 insertions(+), 192 deletions(-)
--
2.25.1
next reply other threads:[~2022-07-13 16:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 16:21 Andre Przywara [this message]
2022-07-13 16:21 ` [PATCH 1/3] sunxi: mmc: ignore card detect in SPL Andre Przywara
2023-01-08 21:00 ` Samuel Holland
2023-01-13 0:05 ` Andre Przywara
2022-07-13 16:21 ` [PATCH 2/3] sunxi: mmc: group non-DM specific functions Andre Przywara
2023-01-08 21:01 ` Samuel Holland
2022-07-13 16:21 ` [PATCH 3/3] sunxi: remove CONFIG_MMC?_CD_PIN Andre Przywara
2023-01-08 21:03 ` Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713162145.95744-1-andre.przywara@arm.com \
--to=andre.przywara@arm.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox