From: Samuel Holland <samuel@sholland.org>
To: Andre Przywara <andre.przywara@arm.com>,
Jagan Teki <jagan@amarulasolutions.com>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>,
u-boot@lists.denx.de, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 2/3] sunxi: mmc: group non-DM specific functions
Date: Sun, 8 Jan 2023 15:01:28 -0600 [thread overview]
Message-ID: <d8a8f151-a161-a451-2b93-26835fc41692@sholland.org> (raw)
In-Reply-To: <20220713162145.95744-3-andre.przywara@arm.com>
On 7/13/22 11:21, Andre Przywara wrote:
> As the SPL code for sunxi boards does not use the driver model, we have
> two mmc_ops structures, one for DM, one for non-DM. The actual hardware
> access code is shared, with the respective callback functions using that
> common code.
>
> To make this more obvious and easier to read, reorder the functions to
> group them: we first have the common code, then the non-DM bits, and
> the proper DM implementation at the end.
> Also document this structure in the comment at the beginning of the file.
>
> No functional change intended.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> drivers/mmc/sunxi_mmc.c | 117 +++++++++++++++++++++-------------------
> 1 file changed, 61 insertions(+), 56 deletions(-)
Reviewed-by: Samuel Holland <samuel@sholland.org>
Tested-by: Samuel Holland <samuel@sholland.org>
next prev parent reply other threads:[~2023-01-08 21:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 16:21 [PATCH 0/3] sunxi: remove CONFIG_MMC?_CD_PIN Andre Przywara
2022-07-13 16:21 ` [PATCH 1/3] sunxi: mmc: ignore card detect in SPL Andre Przywara
2023-01-08 21:00 ` Samuel Holland
2023-01-13 0:05 ` Andre Przywara
2022-07-13 16:21 ` [PATCH 2/3] sunxi: mmc: group non-DM specific functions Andre Przywara
2023-01-08 21:01 ` Samuel Holland [this message]
2022-07-13 16:21 ` [PATCH 3/3] sunxi: remove CONFIG_MMC?_CD_PIN Andre Przywara
2023-01-08 21:03 ` Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8a8f151-a161-a451-2b93-26835fc41692@sholland.org \
--to=samuel@sholland.org \
--cc=andre.przywara@arm.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox