* [PATCH] sunxi: f1c100s: Drop no-MMC hack
@ 2023-01-05 2:09 Andre Przywara
2023-01-14 20:29 ` Samuel Holland
0 siblings, 1 reply; 2+ messages in thread
From: Andre Przywara @ 2023-01-05 2:09 UTC (permalink / raw)
To: Jagan Teki
Cc: u-boot, Icenowy Zheng, Giulio Benetti, Jesse Taube, linux-sunxi
When support for the Allwinner F1C100s SoC was originally introduced,
its DT lacked any MMC nodes, which upset our sunxi-u-boot.dtsi overlay,
when it tried to add an alias to the SD card. To quickly fix this back
then, we guarded that alias with a preprocessor macro.
Now the F1C100s family has gained MMC nodes, so we don't need the
special treatment anymore. Just remove this guard.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
arch/arm/dts/sunxi-u-boot.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/dts/sunxi-u-boot.dtsi b/arch/arm/dts/sunxi-u-boot.dtsi
index 2028d5b6a90..e959eb2a405 100644
--- a/arch/arm/dts/sunxi-u-boot.dtsi
+++ b/arch/arm/dts/sunxi-u-boot.dtsi
@@ -12,9 +12,7 @@
/ {
aliases {
-#ifndef CONFIG_MACH_SUNIV
mmc0 = &mmc0;
-#endif
#if CONFIG_MMC_SUNXI_SLOT_EXTRA == 2
mmc1 = &mmc2;
#endif
--
2.35.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sunxi: f1c100s: Drop no-MMC hack
2023-01-05 2:09 [PATCH] sunxi: f1c100s: Drop no-MMC hack Andre Przywara
@ 2023-01-14 20:29 ` Samuel Holland
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Holland @ 2023-01-14 20:29 UTC (permalink / raw)
To: Andre Przywara, Jagan Teki
Cc: u-boot, Icenowy Zheng, Giulio Benetti, Jesse Taube, linux-sunxi
On 1/4/23 20:09, Andre Przywara wrote:
> When support for the Allwinner F1C100s SoC was originally introduced,
> its DT lacked any MMC nodes, which upset our sunxi-u-boot.dtsi overlay,
> when it tried to add an alias to the SD card. To quickly fix this back
> then, we guarded that alias with a preprocessor macro.
>
> Now the F1C100s family has gained MMC nodes, so we don't need the
> special treatment anymore. Just remove this guard.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> arch/arm/dts/sunxi-u-boot.dtsi | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Samuel Holland <samuel@sholland.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-14 20:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-05 2:09 [PATCH] sunxi: f1c100s: Drop no-MMC hack Andre Przywara
2023-01-14 20:29 ` Samuel Holland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox