From: Andre Przywara <andre.przywara@arm.com>
To: Vasily Khoruzhick <anarsoul@gmail.com>,
Yangtao Li <tiny.windzz@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Martin Botka <martin.botka@somainline.org>,
Bob McChesney <bob@electricworry.net>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: [PATCH v3 0/6] Add support for H616 Thermal system
Date: Tue, 28 Nov 2023 00:58:43 +0000 [thread overview]
Message-ID: <20231128005849.19044-1-andre.przywara@arm.com> (raw)
Hi,
this is v3 of the series by Martin, now complemented by patches to fix
the problem with way-too-high temperatures reported on some boards. This
seems to be related to the firmware being run, because the vendor U-Boot
contains a hack avoiding this problem. Some investigation and digging
in BSP code later we identified that bit 16 in register 0x3000000
(SYS_CFG) needs to be cleared for the raw temperature register values to
contain reasonable values.
To achieve this, patch 1/6 exports this very register from the already
existing syscon device. Patch 4/6 then adds code to the thermal driver
to find the syscon device via a new DT property, and query its regmap to
clear bit 16 in there.
I am not fully convinced this is the best solution, but it works for me.
What leaves a bit of a bitter taste is that the SRAM driver (the one
exporting the regmap) also uses this register, to switch some SRAM C
region to the video engine (VE). Experiments show that only bit 0 in
this register is doing this job, so the current mask covering the 31
LSBs should probably be amended to only cover bit 0.
Another solution could be to model this bit as an SRAM switch, and let
the THS driver claim some (dummy?) SRAM region from the syscon/SRAM driver
directly. While this sounds cleaner to some degree, I don't think there
is really such a THS SRAM region, so it's not fully correct either.
I would appreciate any feedback on this, happy to implement the other
approach, if that's desired.
The rest of the patches is mostly unchanged from Martin's v2, just
updated and massaged the commit messages a bit. I also added patch 3/6
to document some so-far unknown register value.
Please have a look!
Cheers,
Andre
Changelog v2 .. v3:
- rebase on top of v6.7-rc3
- add patches to clear bit 16 in SYS_CFG register 0x3000000
- add syscon to the binding documentation
- add patch explaining the unknown control register value
Changelog v1 .. v2:
- Fix typos
- Remove h616 calc and init functions
- Use TEMP_CALIB_MASK insteaf of 0xffff
- Adjust calibration function to new offset and scale
- Add proper comment to bindings patch
- Split delta calculations to 2 lines
- Add parentheses around caldata[2|3] >> 12
- Negate bindings if for clocks
Andre Przywara (3):
soc: sunxi: sram: export register 0 for THS on H616
thermal: sun8i: explain unknown H6 register value
thermal: sun8i: add syscon register access code
Martin Botka (3):
dt-bindings: thermal: sun8i: Add H616 THS controller
thermal: sun8i: add support for H616 THS controller
arm64: dts: allwinner: h616: Add thermal sensor and zones
.../thermal/allwinner,sun8i-a83t-ths.yaml | 30 ++--
.../arm64/boot/dts/allwinner/sun50i-h616.dtsi | 88 ++++++++++
drivers/soc/sunxi/sunxi_sram.c | 5 +
drivers/thermal/sun8i_thermal.c | 152 ++++++++++++++++--
4 files changed, 252 insertions(+), 23 deletions(-)
--
2.35.8
next reply other threads:[~2023-11-28 1:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 0:58 Andre Przywara [this message]
2023-11-28 0:58 ` [PATCH v3 1/6] soc: sunxi: sram: export register 0 for THS on H616 Andre Przywara
2023-11-28 0:58 ` [PATCH v3 2/6] dt-bindings: thermal: sun8i: Add H616 THS controller Andre Przywara
2023-11-28 7:41 ` Krzysztof Kozlowski
2023-11-28 0:58 ` [PATCH v3 3/6] thermal: sun8i: explain unknown H6 register value Andre Przywara
2023-11-28 0:58 ` [PATCH v3 4/6] thermal: sun8i: add syscon register access code Andre Przywara
2023-11-28 7:43 ` Krzysztof Kozlowski
2023-11-28 7:50 ` Chen-Yu Tsai
2023-11-28 8:29 ` Krzysztof Kozlowski
2023-11-28 8:59 ` Chen-Yu Tsai
2023-11-28 9:02 ` Chen-Yu Tsai
2023-11-28 9:09 ` Chen-Yu Tsai
2023-11-28 9:13 ` Krzysztof Kozlowski
2023-11-28 14:11 ` Krzysztof Kozlowski
2023-11-28 14:33 ` Andre Przywara
2023-11-28 14:48 ` Krzysztof Kozlowski
2023-11-28 16:10 ` Andre Przywara
2023-11-28 16:39 ` Chen-Yu Tsai
2023-11-28 16:50 ` Rob Herring
2023-11-29 17:03 ` Andre Przywara
2023-11-29 17:09 ` Chen-Yu Tsai
2023-11-28 0:58 ` [PATCH v3 5/6] thermal: sun8i: add support for H616 THS controller Andre Przywara
2023-12-09 10:44 ` Maksim Kiselev
2023-12-11 0:05 ` Andre Przywara
2023-12-12 18:09 ` Maxim Kiselev
2023-12-14 9:59 ` Andre Przywara
2023-12-17 14:16 ` Maxim Kiselev
2023-11-28 0:58 ` [PATCH v3 6/6] arm64: dts: allwinner: h616: Add thermal sensor and zones Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128005849.19044-1-andre.przywara@arm.com \
--to=andre.przywara@arm.com \
--cc=anarsoul@gmail.com \
--cc=bob@electricworry.net \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=lukasz.luba@arm.com \
--cc=martin.botka@somainline.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=samuel@sholland.org \
--cc=tiny.windzz@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox