From: Andre Przywara <andre.przywara@arm.com>
To: "Kryštof Černý" <cleverline1mc@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] Use regulators for pio on NanoPi NEO Plus2
Date: Wed, 4 Sep 2024 16:27:02 +0100 [thread overview]
Message-ID: <20240904162702.7c3dc33e@donnerap.manchester.arm.com> (raw)
In-Reply-To: <20240827-nanopi-neo-plus2-regfix-v2-2-497684ec82c7@gmail.com>
On Tue, 27 Aug 2024 23:00:44 +0200
Kryštof Černý <cleverline1mc@gmail.com> wrote:
Hi,
> Pin controllers pio and r_pio will have proper regulators assigned.
>
> Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
Checked against the schematic, it's indeed all 3.3V, except for PortD.
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> index dee4cd82636b..526443bb736c 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> @@ -171,6 +171,18 @@ &ohci3 {
> status = "okay";
> };
>
> +&pio {
> + vcc-pa-supply = <®_vcc3v3>;
> + vcc-pc-supply = <®_vcc3v3>;
> + vcc-pd-supply = <®_gmac_2v5>;
> + vcc-pf-supply = <®_vcc3v3>;
> + vcc-pg-supply = <®_vcc3v3>;
> +};
> +
> +&r_pio {
> + vcc-pl-supply = <®_vcc3v3>;
> +};
> +
> &uart0 {
> pinctrl-names = "default";
> pinctrl-0 = <&uart0_pa_pins>;
>
next prev parent reply other threads:[~2024-09-04 15:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 21:00 [PATCH v2 0/3] Fix regulators and assign them on NanoPi NEO Plus2 Kryštof Černý
2024-08-27 21:00 ` [PATCH v2 1/3] Fix NanoPi NEO Plus2 regulators Kryštof Černý
2024-09-04 16:44 ` Andre Przywara
2024-08-27 21:00 ` [PATCH v2 2/3] Use regulators for pio on NanoPi NEO Plus2 Kryštof Černý
2024-09-04 15:27 ` Andre Przywara [this message]
2024-08-27 21:00 ` [PATCH v2 3/3] Add vqmmc-supply " Kryštof Černý
2024-09-04 15:25 ` Andre Przywara
2024-09-04 14:52 ` [PATCH v2 0/3] Fix regulators and assign them " Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904162702.7c3dc33e@donnerap.manchester.arm.com \
--to=andre.przywara@arm.com \
--cc=cleverline1mc@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox