[PATCH] arm: dts: allwinner: a10: Add DMA for emac

[PATCH] arm: dts: allwinner: a10: Add DMA for emac

[uis]

RX DMA should be already used by driver, TX still isn't

Signed-off-by: uis <uis9936@gmail.com>
---
 arch/arm/boot/dts/allwinner/sun4i-a10.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/allwinner/sun4i-a10.dtsi
b/arch/arm/boot/dts/allwinner/sun4i-a10.dtsi
index 51a6464aab9a..299e12aadf9c 100644
--- a/arch/arm/boot/dts/allwinner/sun4i-a10.dtsi
+++ b/arch/arm/boot/dts/allwinner/sun4i-a10.dtsi
@@ -314,6 +314,9 @@ emac: ethernet@1c0b000 {
  reg = <0x01c0b000 0x1000>;
  interrupts = <55>;
  clocks = <&ccu CLK_AHB_EMAC>;
+ dmas = <&dma SUN4I_DMA_DEDICATED 7>,
+       <&dma SUN4I_DMA_DEDICATED 6>;
+ dma-names = "rx", "tx";
  allwinner,sram = <&emac_sram 1>;
  pinctrl-names = "default";
  pinctrl-0 = <&emac_pins>;
--
I had to resend message as plain text

Re: [PATCH] arm: dts: allwinner: a10: Add DMA for emac

[Chen-Yu Tsai]

On Wed, Sep 4, 2024 at 5:11 PM uis <uis9936@gmail.com> wrote:
>
> RX DMA should be already used by driver, TX still isn't

Commit messages for device tree changes should not reference the OS.

Just say that the hardware is DMA capable and should have DRQs added.

> Signed-off-by: uis <uis9936@gmail.com>
> ---
>  arch/arm/boot/dts/allwinner/sun4i-a10.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/allwinner/sun4i-a10.dtsi
> b/arch/arm/boot/dts/allwinner/sun4i-a10.dtsi
> index 51a6464aab9a..299e12aadf9c 100644
> --- a/arch/arm/boot/dts/allwinner/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/allwinner/sun4i-a10.dtsi
> @@ -314,6 +314,9 @@ emac: ethernet@1c0b000 {
>   reg = <0x01c0b000 0x1000>;
>   interrupts = <55>;
>   clocks = <&ccu CLK_AHB_EMAC>;
> + dmas = <&dma SUN4I_DMA_DEDICATED 7>,
> +       <&dma SUN4I_DMA_DEDICATED 6>;
> + dma-names = "rx", "tx";
>   allwinner,sram = <&emac_sram 1>;
>   pinctrl-names = "default";
>   pinctrl-0 = <&emac_pins>;
> --
> I had to resend message as plain text

And the whitespace is broken. Please use git send-email to send patches.

Re: [PATCH] arm: dts: allwinner: a10: Add DMA for emac

[Andre Przywara]

On Wed, 4 Sep 2024 12:10:57 +0300
uis <uis9936@gmail.com> wrote:

Hi,

> RX DMA should be already used by driver, TX still isn't

As Chen-Yu mentioned, you would need a better commit message.

I tested this on the original Cubieboard, and it worked fine. With some
very crude netcat based testing I didn't see any performance or CPU
benefit, but the DMA engine seemed to have been utilised, and the
"missing DMA" messages vanished from dmesg.
Also checked the manual for the DRQ numbers: they match.

So with a proper commit message:

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

> Signed-off-by: uis <uis9936@gmail.com>

I think the kernel contribution rules require a bit more of a real name
here.

Cheers,
Andre

> ---
>  arch/arm/boot/dts/allwinner/sun4i-a10.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/allwinner/sun4i-a10.dtsi
> b/arch/arm/boot/dts/allwinner/sun4i-a10.dtsi
> index 51a6464aab9a..299e12aadf9c 100644
> --- a/arch/arm/boot/dts/allwinner/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/allwinner/sun4i-a10.dtsi
> @@ -314,6 +314,9 @@ emac: ethernet@1c0b000 {
>   reg = <0x01c0b000 0x1000>;
>   interrupts = <55>;
>   clocks = <&ccu CLK_AHB_EMAC>;
> + dmas = <&dma SUN4I_DMA_DEDICATED 7>,
> +       <&dma SUN4I_DMA_DEDICATED 6>;
> + dma-names = "rx", "tx";
>   allwinner,sram = <&emac_sram 1>;
>   pinctrl-names = "default";
>   pinctrl-0 = <&emac_pins>;
> --
> I had to resend message as plain text
>