From: Andre Przywara <andre.przywara@arm.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-rtc@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Yiting Deng <yiting.deng@amlogic.com>,
Xianwei Zhao <xianwei.zhao@amlogic.com>,
Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Support Opensource <support.opensource@diasemi.com>,
Paul Cercueil <paul@crapouillou.net>,
Vladimir Zapolskiy <vz@mleia.com>,
Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Eddie Huang <eddie.huang@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Vincent Shih <vincent.sunplus@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Michal Simek <michal.simek@amd.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
chrome-platform@lists.linux.dev, linux-mips@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev,
linux-tegra@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH] rtc: use boolean values with device_init_wakeup()
Date: Tue, 17 Dec 2024 11:01:40 +0000 [thread overview]
Message-ID: <20241217110140.22c92138@donnerap.manchester.arm.com> (raw)
In-Reply-To: <20241217071331.3607-2-wsa+renesas@sang-engineering.com>
On Tue, 17 Dec 2024 08:13:26 +0100
Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:
> device_init_wakeup() second argument is a bool type. Use proper boolean
> values when calling it to match the type and to produce unambiguous code
> which is easier to understand.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Verified via regexps that it's indeed this pattern: 1 => true, 0 => false.
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
> Created with a coccinelle script. I opted for a single patch because the change
> is rather trivial. I can break out per driver if this is desired. If you
> like the change at all, that is.
>
> drivers/rtc/rtc-88pm80x.c | 2 +-
> drivers/rtc/rtc-88pm860x.c | 2 +-
> drivers/rtc/rtc-amlogic-a4.c | 6 +++---
> drivers/rtc/rtc-armada38x.c | 2 +-
> drivers/rtc/rtc-as3722.c | 2 +-
> drivers/rtc/rtc-at91rm9200.c | 2 +-
> drivers/rtc/rtc-at91sam9.c | 2 +-
> drivers/rtc/rtc-cadence.c | 2 +-
> drivers/rtc/rtc-cmos.c | 2 +-
> drivers/rtc/rtc-cpcap.c | 2 +-
> drivers/rtc/rtc-cros-ec.c | 2 +-
> drivers/rtc/rtc-da9055.c | 2 +-
> drivers/rtc/rtc-ds3232.c | 2 +-
> drivers/rtc/rtc-isl1208.c | 2 +-
> drivers/rtc/rtc-jz4740.c | 2 +-
> drivers/rtc/rtc-loongson.c | 4 ++--
> drivers/rtc/rtc-lp8788.c | 2 +-
> drivers/rtc/rtc-lpc32xx.c | 2 +-
> drivers/rtc/rtc-max77686.c | 2 +-
> drivers/rtc/rtc-max8925.c | 2 +-
> drivers/rtc/rtc-max8997.c | 2 +-
> drivers/rtc/rtc-meson-vrtc.c | 2 +-
> drivers/rtc/rtc-mpc5121.c | 2 +-
> drivers/rtc/rtc-mt6397.c | 2 +-
> drivers/rtc/rtc-mv.c | 4 ++--
> drivers/rtc/rtc-mxc.c | 2 +-
> drivers/rtc/rtc-mxc_v2.c | 2 +-
> drivers/rtc/rtc-omap.c | 2 +-
> drivers/rtc/rtc-palmas.c | 2 +-
> drivers/rtc/rtc-pic32.c | 2 +-
> drivers/rtc/rtc-pm8xxx.c | 2 +-
> drivers/rtc/rtc-pxa.c | 2 +-
> drivers/rtc/rtc-rc5t583.c | 2 +-
> drivers/rtc/rtc-rc5t619.c | 2 +-
> drivers/rtc/rtc-renesas-rtca3.c | 2 +-
> drivers/rtc/rtc-rk808.c | 2 +-
> drivers/rtc/rtc-s3c.c | 2 +-
> drivers/rtc/rtc-s5m.c | 2 +-
> drivers/rtc/rtc-sa1100.c | 2 +-
> drivers/rtc/rtc-sc27xx.c | 4 ++--
> drivers/rtc/rtc-sh.c | 2 +-
> drivers/rtc/rtc-spear.c | 4 ++--
> drivers/rtc/rtc-sun6i.c | 2 +-
> drivers/rtc/rtc-sunplus.c | 4 ++--
> drivers/rtc/rtc-tegra.c | 2 +-
> drivers/rtc/rtc-test.c | 2 +-
> drivers/rtc/rtc-tps6586x.c | 2 +-
> drivers/rtc/rtc-tps65910.c | 2 +-
> drivers/rtc/rtc-twl.c | 2 +-
> drivers/rtc/rtc-wm831x.c | 2 +-
> drivers/rtc/rtc-wm8350.c | 2 +-
> drivers/rtc/rtc-xgene.c | 4 ++--
> drivers/rtc/rtc-zynqmp.c | 4 ++--
> 53 files changed, 62 insertions(+), 62 deletions(-)
>
next prev parent reply other threads:[~2024-12-17 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 7:13 [PATCH] rtc: use boolean values with device_init_wakeup() Wolfram Sang
2024-12-17 10:36 ` Charles Keepax
2024-12-17 11:01 ` Andre Przywara [this message]
2025-01-09 20:03 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241217110140.22c92138@donnerap.manchester.arm.com \
--to=andre.przywara@arm.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=claudiu.beznea@tuxon.dev \
--cc=cw00.choi@samsung.com \
--cc=eddie.huang@mediatek.com \
--cc=gregory.clement@bootlin.com \
--cc=groeck@chromium.org \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@amd.com \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.ferre@microchip.com \
--cc=orsonzhai@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=paul@crapouillou.net \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=samuel@sholland.org \
--cc=sean.wang@mediatek.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=support.opensource@diasemi.com \
--cc=thierry.reding@gmail.com \
--cc=vincent.sunplus@gmail.com \
--cc=vz@mleia.com \
--cc=wens@csie.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=xianwei.zhao@amlogic.com \
--cc=yiting.deng@amlogic.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox