[PATCH v2 0/2] Add support for WiFi/BT header on Pine64 A64

[PATCH v2 0/2] Add support for WiFi/BT header on Pine64 A64

[Peter Robinson]

Add the BT and WiFi pins on the WiFi/BT header on the Pine64/Sopine
boards.

Changes in v2:
- drop patch that enables the WiFi module, it'll move to a overlay later

Peter Robinson (2):
  arm64: dts: allwinner: a64: Add WiFi/BT header on Pine64
  arm64: dts: allwinner: a64: Add WiFi/BT header on SoPine

 .../boot/dts/allwinner/sun50i-a64-pine64.dts  | 17 +++++++++++++
 .../allwinner/sun50i-a64-sopine-baseboard.dts | 24 +++++++++++++++++++
 2 files changed, 41 insertions(+)

-- 
2.47.1

[PATCH v2 1/2] arm64: dts: allwinner: a64: Add WiFi/BT header on Pine64

[Peter Robinson]

This adds all the pin mappings on the WiFi/BT header on
the original Pine64. They're disabled by default as the
modules don't ship by default. This includes, where they
haven't been already, UART1 for BT and mmc1 for WiFi.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 .../boot/dts/allwinner/sun50i-a64-pine64.dts    | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
index 09e71fd60785..f04f0f1badc4 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
@@ -35,6 +35,11 @@ hdmi_con_in: endpoint {
 			};
 		};
 	};
+
+	wifi_pwrseq: pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */
+	};
 };
 
 &codec {
@@ -124,6 +129,17 @@ &mmc0 {
 	status = "okay";
 };
 
+/* On Wifi/BT connector */
+&mmc1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mmc1_pins>;
+	vmmc-supply = <&reg_dldo4>;
+	vqmmc-supply = <&reg_eldo1>;
+	mmc-pwrseq = <&wifi_pwrseq>;
+	bus-width = <4>;
+	non-removable;
+};
+
 &ohci0 {
 	status = "okay";
 };
@@ -286,6 +302,7 @@ &uart0 {
 &uart1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>;
+	uart-has-rtscts;
 	status = "disabled";
 };
 
-- 
2.47.1

Re: [PATCH v2 1/2] arm64: dts: allwinner: a64: Add WiFi/BT header on Pine64

[Chen-Yu Tsai]

On Fri, Dec 20, 2024 at 8:00 PM Peter Robinson <pbrobinson@gmail.com> wrote:
>
> This adds all the pin mappings on the WiFi/BT header on
> the original Pine64. They're disabled by default as the
> modules don't ship by default. This includes, where they
> haven't been already, UART1 for BT and mmc1 for WiFi.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  .../boot/dts/allwinner/sun50i-a64-pine64.dts    | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> index 09e71fd60785..f04f0f1badc4 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> @@ -35,6 +35,11 @@ hdmi_con_in: endpoint {
>                         };
>                 };
>         };
> +
> +       wifi_pwrseq: pwrseq {
> +               compatible = "mmc-pwrseq-simple";
> +               reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */
> +       };
>  };
>
>  &codec {
> @@ -124,6 +129,17 @@ &mmc0 {
>         status = "okay";
>  };
>
> +/* On Wifi/BT connector */
> +&mmc1 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&mmc1_pins>;
> +       vmmc-supply = <&reg_dldo4>;
> +       vqmmc-supply = <&reg_eldo1>;
> +       mmc-pwrseq = <&wifi_pwrseq>;
> +       bus-width = <4>;
> +       non-removable;

Please also add an explicit 'status = "disabled"', like what is done
for the uart below.

ChenYu

> +};
> +
>  &ohci0 {
>         status = "okay";
>  };
> @@ -286,6 +302,7 @@ &uart0 {
>  &uart1 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>;
> +       uart-has-rtscts;
>         status = "disabled";
>  };
>
> --
> 2.47.1
>
>

Re: [PATCH v2 1/2] arm64: dts: allwinner: a64: Add WiFi/BT header on Pine64

[Chen-Yu Tsai]

On Mon, Mar 31, 2025 at 11:16 PM Peter Robinson <pbrobinson@gmail.com> wrote:
>
> Hi Chen-Yu,
>
> Apologies for the delayed reply, preparing an update, comment inline.
>
> On Sun, 22 Dec 2024 at 17:19, Chen-Yu Tsai <wens@csie.org> wrote:
>>
>> On Fri, Dec 20, 2024 at 8:00 PM Peter Robinson <pbrobinson@gmail.com> wrote:
>> >
>> > This adds all the pin mappings on the WiFi/BT header on
>> > the original Pine64. They're disabled by default as the
>> > modules don't ship by default. This includes, where they
>> > haven't been already, UART1 for BT and mmc1 for WiFi.
>> >
>> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>> > ---
>> >  .../boot/dts/allwinner/sun50i-a64-pine64.dts    | 17 +++++++++++++++++
>> >  1 file changed, 17 insertions(+)
>> >
>> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
>> > index 09e71fd60785..f04f0f1badc4 100644
>> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
>> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
>> > @@ -35,6 +35,11 @@ hdmi_con_in: endpoint {
>> >                         };
>> >                 };
>> >         };
>> > +
>> > +       wifi_pwrseq: pwrseq {
>> > +               compatible = "mmc-pwrseq-simple";
>> > +               reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */
>> > +       };
>> >  };
>> >
>> >  &codec {
>> > @@ -124,6 +129,17 @@ &mmc0 {
>> >         status = "okay";
>> >  };
>> >
>> > +/* On Wifi/BT connector */
>> > +&mmc1 {
>> > +       pinctrl-names = "default";
>> > +       pinctrl-0 = <&mmc1_pins>;
>> > +       vmmc-supply = <&reg_dldo4>;
>> > +       vqmmc-supply = <&reg_eldo1>;
>> > +       mmc-pwrseq = <&wifi_pwrseq>;
>> > +       bus-width = <4>;
>> > +       non-removable;
>>
>> Please also add an explicit 'status = "disabled"', like what is done
>> for the uart below.
>
>
> So the status is disabled already because it's disabled in sun50i-a64.dtsi, as is the uart1 actually, so in both cases it's not actually needed and will then just be set to okay in the overlay, do you still wanted it explicitly, else I'll drop the unneded uart one too.

I know they are disabled by default, so yes I still want to see them
explicitly disabled at the board level.


ChenYu


> Peter
>
>>
>> ChenYu
>>
>> > +};
>> > +
>> >  &ohci0 {
>> >         status = "okay";
>> >  };
>> > @@ -286,6 +302,7 @@ &uart0 {
>> >  &uart1 {
>> >         pinctrl-names = "default";
>> >         pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>;
>> > +       uart-has-rtscts;
>> >         status = "disabled";
>> >  };
>> >
>> > --
>> > 2.47.1
>> >
>> >

[PATCH v2 2/2] arm64: dts: allwinner: a64: Add WiFi/BT header on SoPine

[Peter Robinson]

This adds all the pin mappings on the WiFi/BT header on
the SoPine baseboard/A64-LTS. They're disabled by default
as the modules don't ship by default. This includes, where
they haven't been already, UART1 for BT and mmc1 for WiFi.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 .../allwinner/sun50i-a64-sopine-baseboard.dts | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
index be2347c8f267..752d2aae8465 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
@@ -42,6 +42,11 @@ reg_vcc1v8: vcc1v8 {
 		regulator-min-microvolt = <1800000>;
 		regulator-max-microvolt = <1800000>;
 	};
+
+	wifi_pwrseq: pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */
+	};
 };
 
 &ac_power_supply {
@@ -103,6 +108,17 @@ ext_rgmii_phy: ethernet-phy@1 {
 	};
 };
 
+/* On Wifi/BT connector */
+&mmc1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mmc1_pins>;
+	vmmc-supply = <&reg_dldo4>;
+	vqmmc-supply = <&reg_eldo1>;
+	mmc-pwrseq = <&wifi_pwrseq>;
+	bus-width = <4>;
+	non-removable;
+};
+
 &mmc2 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc2_pins>;
@@ -175,6 +191,14 @@ &uart0 {
 	status = "okay";
 };
 
+/* On Wifi/BT connector, with RTS/CTS */
+&uart1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>;
+	uart-has-rtscts;
+	status = "disabled";
+};
+
 /* On Pi-2 connector */
 &uart2 {
 	pinctrl-names = "default";
-- 
2.47.1

Re: [PATCH v2 2/2] arm64: dts: allwinner: a64: Add WiFi/BT header on SoPine

[Chen-Yu Tsai]

On Fri, Dec 20, 2024 at 8:00 PM Peter Robinson <pbrobinson@gmail.com> wrote:
>
> This adds all the pin mappings on the WiFi/BT header on
> the SoPine baseboard/A64-LTS. They're disabled by default
> as the modules don't ship by default. This includes, where
> they haven't been already, UART1 for BT and mmc1 for WiFi.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  .../allwinner/sun50i-a64-sopine-baseboard.dts | 24 +++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> index be2347c8f267..752d2aae8465 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> @@ -42,6 +42,11 @@ reg_vcc1v8: vcc1v8 {
>                 regulator-min-microvolt = <1800000>;
>                 regulator-max-microvolt = <1800000>;
>         };
> +
> +       wifi_pwrseq: pwrseq {
> +               compatible = "mmc-pwrseq-simple";
> +               reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */
> +       };
>  };
>
>  &ac_power_supply {
> @@ -103,6 +108,17 @@ ext_rgmii_phy: ethernet-phy@1 {
>         };
>  };
>
> +/* On Wifi/BT connector */
> +&mmc1 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&mmc1_pins>;
> +       vmmc-supply = <&reg_dldo4>;
> +       vqmmc-supply = <&reg_eldo1>;
> +       mmc-pwrseq = <&wifi_pwrseq>;
> +       bus-width = <4>;
> +       non-removable;

Same here, please explicitly set 'status = "disabled"' like what
you are doing with uart1 below.

ChenYu

> +};
> +
>  &mmc2 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&mmc2_pins>;
> @@ -175,6 +191,14 @@ &uart0 {
>         status = "okay";
>  };
>
> +/* On Wifi/BT connector, with RTS/CTS */
> +&uart1 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>;
> +       uart-has-rtscts;
> +       status = "disabled";
> +};
> +
>  /* On Pi-2 connector */
>  &uart2 {
>         pinctrl-names = "default";
> --
> 2.47.1
>
>

Re: [PATCH v2 0/2] Add support for WiFi/BT header on Pine64 A64

[Vasily Khoruzhick]

On Fri, Dec 20, 2024 at 4:00 AM Peter Robinson <pbrobinson@gmail.com> wrote:
>
> Add the BT and WiFi pins on the WiFi/BT header on the Pine64/Sopine
> boards.
>
> Changes in v2:
> - drop patch that enables the WiFi module, it'll move to a overlay later

Any plans to send v3 with comments from Chen-Yu addressed?


> Peter Robinson (2):
>   arm64: dts: allwinner: a64: Add WiFi/BT header on Pine64
>   arm64: dts: allwinner: a64: Add WiFi/BT header on SoPine
>
>  .../boot/dts/allwinner/sun50i-a64-pine64.dts  | 17 +++++++++++++
>  .../allwinner/sun50i-a64-sopine-baseboard.dts | 24 +++++++++++++++++++
>  2 files changed, 41 insertions(+)
>
> --
> 2.47.1
>
>