Re: [PATCH 2/5] dt-bindings: power: supply: axp20x-battery: Add x-powers,no-thermistor

[Krzysztof Kozlowski <krzk@kernel.org>]

On Fri, Jan 31, 2025 at 05:14:52PM -0600, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Add the vendor specific boolean property of x-powers,no-thermistor.
> This property optionally describes hardware where no thermistor is
> present on the battery and is specific to the AXP717. In rare
> circumstances this value can be set incorrectly in the efuse of the
> PMIC, and if it is not hard-coded the device will fail to charge.
> 
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>  .../x-powers,axp20x-battery-power-supply.yaml | 22 ++++++++++++++++---
>  1 file changed, 19 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml b/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml
> index 5ccd375eb294..e0f134a13f7e 100644
> --- a/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml
> @@ -14,9 +14,6 @@ maintainers:
>    - Chen-Yu Tsai <wens@csie.org>
>    - Sebastian Reichel <sre@kernel.org>
>  
> -allOf:
> -  - $ref: power-supply.yaml#
> -
>  properties:
>    compatible:
>      oneOf:
> @@ -35,7 +32,26 @@ properties:
>        this gauge.
>      $ref: /schemas/types.yaml#/definitions/phandle
>  
> +  x-powers,no-thermistor:
> +    type: boolean
> +    description: Indicates that no thermistor is connected to the TS pin
> +
>  required:
>    - compatible
>  
> +allOf:
> +  - $ref: power-supply.yaml#
> +  - if:

This could be simpler - use not: here.

> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - x-powers,axp717-battery-power-supply

Anyway,

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof