ARM Sunxi Platform Development
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Paul Kocialkowski <contact@paulk.fr>
Cc: u-boot@lists.denx.de, Tom Rini <trini@konsulko.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Icenowy Zheng <icenowy@aosc.xyz>,
	linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 1/6] sunxi: Kconfig: Fix default order for V3s DRAM clock
Date: Mon, 2 Jun 2025 01:39:55 +0100	[thread overview]
Message-ID: <20250602013955.61191d77@minigeek.lan> (raw)
In-Reply-To: <20250601153943.2690123-2-contact@paulk.fr>

On Sun,  1 Jun 2025 17:39:38 +0200
Paul Kocialkowski <contact@paulk.fr> wrote:

Hi Paul,

> The V3s (using co-packaged DRAM) runs at 360 MHz, which is specified in
> the common platform Kconfig file. However the value for MACH_SUN8I will
> be picked up instead due to ordering.
> 
> Re-order the defaults to have MACH_SUN8I_V3S before MACH_SUN8I and let
> it select the correct default. Also update the LicheePi Zero Dock
> defconfig to remove the value, which is now correctly selected.

Looks alright, can confirm that all generated .config files are the
same before and after:

> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Thanks!
Andre

> ---
>  arch/arm/mach-sunxi/Kconfig     | 2 +-
>  configs/LicheePi_Zero_defconfig | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> index 17179593913e..8b43fd176dc0 100644
> --- a/arch/arm/mach-sunxi/Kconfig
> +++ b/arch/arm/mach-sunxi/Kconfig
> @@ -591,9 +591,9 @@ config DRAM_CLK
>  	int "sunxi dram clock speed"
>  	default 792 if MACH_SUN9I
>  	default 648 if MACH_SUN8I_R40
> -	default 312 if MACH_SUN6I || MACH_SUN8I
>  	default 360 if MACH_SUN4I || MACH_SUN5I || MACH_SUN7I || \
>  		       MACH_SUN8I_V3S
> +	default 312 if MACH_SUN6I || MACH_SUN8I
>  	default 672 if MACH_SUN50I
>  	default 744 if MACH_SUN50I_H6
>  	default 720 if MACH_SUN50I_H616
> diff --git a/configs/LicheePi_Zero_defconfig b/configs/LicheePi_Zero_defconfig
> index c37c49ccbb16..b2cf0a018c7f 100644
> --- a/configs/LicheePi_Zero_defconfig
> +++ b/configs/LicheePi_Zero_defconfig
> @@ -3,6 +3,5 @@ CONFIG_ARCH_SUNXI=y
>  CONFIG_DEFAULT_DEVICE_TREE="sun8i-v3s-licheepi-zero"
>  CONFIG_SPL=y
>  CONFIG_MACH_SUN8I_V3S=y
> -CONFIG_DRAM_CLK=360
>  # CONFIG_HAS_ARMV7_SECURE_BASE is not set
>  CONFIG_NO_NET=y


  reply	other threads:[~2025-06-02  0:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-01 15:39 [PATCH 0/6] Various V3/S3/V3s fixes and improvements Paul Kocialkowski
2025-06-01 15:39 ` [PATCH 1/6] sunxi: Kconfig: Fix default order for V3s DRAM clock Paul Kocialkowski
2025-06-02  0:39   ` Andre Przywara [this message]
2025-06-01 15:39 ` [PATCH 2/6] sunxi: Add support for the Lichee Pi Zero with Dock Paul Kocialkowski
2025-06-02  0:40   ` Andre Przywara
2025-06-03 17:37     ` Paul Kocialkowski
2025-06-01 15:39 ` [PATCH 3/6] sunxi: Split V3/S3 support from V3s Paul Kocialkowski
2025-06-01 15:39 ` [PATCH 4/6] sunxi: pinecube: Enable EMAC and network support Paul Kocialkowski
2025-06-02  0:40   ` Andre Przywara
2025-06-01 15:39 ` [PATCH 5/6] power: axp: Fixup default voltages for V3/S3 Paul Kocialkowski
2025-06-01 15:39 ` [PATCH 6/6] net: sun8i-emac: Add support for active-low leds with internal PHY Paul Kocialkowski
2025-06-02  0:40   ` Andre Przywara
2025-06-03 17:40     ` Paul Kocialkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250602013955.61191d77@minigeek.lan \
    --to=andre.przywara@arm.com \
    --cc=contact@paulk.fr \
    --cc=icenowy@aosc.xyz \
    --cc=jagan@amarulasolutions.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox