Re: [PATCH 2/6] sunxi: Add support for the Lichee Pi Zero with Dock

[Andre Przywara <andre.przywara@arm.com>]

On Sun,  1 Jun 2025 17:39:39 +0200
Paul Kocialkowski <contact@paulk.fr> wrote:

Hi Paul,

> This adds a U-Boot config and device-tree build for the Lichee Pi Zero
> with Dock. Compared to the Lichee Pi Zero, it has an ethernet port
> (with internal PHY) so the EMAC driver and network support are enabled.

I just realised that there is no difference between the U-Boot versions
of the DT and the kernel ones, so can you please use the opportunity to
upgrade the V3x systems to OF_UPSTREAM (in a separate patch)? This would
involve removing all the redundant .dts* files from arch/arm/dts, see
dc2dd2de0f782860 for an example.

Regardless the defconfig looks alright, but one comment:

> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  arch/arm/dts/Makefile                | 3 ++-
>  configs/LicheePi_Zero_Dock_defconfig | 7 +++++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
>  create mode 100644 configs/LicheePi_Zero_Dock_defconfig
> 
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 32b698a7f411..be6867ceae0e 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -650,7 +650,8 @@ dtb-$(CONFIG_MACH_SUN8I_V3S) += \
>  	sun8i-s3-elimo-initium.dtb \
>  	sun8i-s3-pinecube.dtb \
>  	sun8i-v3-sl631-imx179.dtb \
> -	sun8i-v3s-licheepi-zero.dtb
> +	sun8i-v3s-licheepi-zero.dtb \
> +	sun8i-v3s-licheepi-zero-dock.dtb
>  dtb-$(CONFIG_MACH_SUN8I_R528) += \
>  	sun8i-t113s-mangopi-mq-r-t113.dtb
>  dtb-$(CONFIG_MACH_SUN50I_H5) += \
> diff --git a/configs/LicheePi_Zero_Dock_defconfig b/configs/LicheePi_Zero_Dock_defconfig
> new file mode 100644
> index 000000000000..ec172d98b65e
> --- /dev/null
> +++ b/configs/LicheePi_Zero_Dock_defconfig
> @@ -0,0 +1,7 @@
> +CONFIG_ARM=y
> +CONFIG_ARCH_SUNXI=y
> +CONFIG_DEFAULT_DEVICE_TREE="sun8i-v3s-licheepi-zero-dock"
> +CONFIG_SPL=y
> +CONFIG_MACH_SUN8I_V3S=y
> +# CONFIG_HAS_ARMV7_SECURE_BASE is not set

IIUC, the V3S does not have (secure) SRAM A2, and no ARISC? Can we
express this in the Kconfig file then, since it's not a board config
option?

Cheers,
Andre

> +CONFIG_SUN8I_EMAC=y