From: Lee Jones <lee@kernel.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Chen-Yu Tsai <wens@csie.org>, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Samuel Holland <samuel@sholland.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/3] mfd: axp20x: Add support for AXP318W PMIC
Date: Tue, 2 Sep 2025 14:36:38 +0100 [thread overview]
Message-ID: <20250902133638.GO2163762@google.com> (raw)
In-Reply-To: <20250813235330.24263-3-andre.przywara@arm.com>
On Thu, 14 Aug 2025, Andre Przywara wrote:
> The AXP318W is a PMIC chip produced by X-Powers, it can be connected to
> an I2C bus.
>
> It has a large number of regulators: 9(!) DCDC buck converters, and 28
> LDOs, also some ADCs, interrupts, and a power key.
>
> Describe the regmap and the MFD bits, along with the registers exposed
> via I2C only. This covers the regulator, interrupts and power key
> devices for now.
> Advertise the device using the new compatible string.
>
> We use just "318" for the internal identifiers, for easier typing and
> less churn, but use "318W" for anything externally visible. If something
> else other than the "AXP318W" shows up, that's an easy change then.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> drivers/mfd/axp20x-i2c.c | 2 +
> drivers/mfd/axp20x.c | 84 +++++++++++++++++++++++++++++++++++++
> include/linux/mfd/axp20x.h | 86 ++++++++++++++++++++++++++++++++++++++
> 3 files changed, 172 insertions(+)
Looks okay. Let me know when you're !RFC.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-09-02 13:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 23:53 [RFC PATCH 0/3] regulator: Add X-Powers AXP318W PMIC support Andre Przywara
2025-08-13 23:53 ` [RFC PATCH 1/3] dt-bindings: mfd: x-powers,axp152: Document AXP318W Andre Przywara
2025-08-20 19:50 ` Rob Herring (Arm)
2025-08-13 23:53 ` [RFC PATCH 2/3] mfd: axp20x: Add support for AXP318W PMIC Andre Przywara
2025-09-02 13:36 ` Lee Jones [this message]
2025-08-13 23:53 ` [RFC PATCH 3/3] regulator: axp20x: add support for the AXP318W Andre Przywara
2025-08-19 13:36 ` Yixun Lan
2025-10-21 11:17 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902133638.GO2163762@google.com \
--to=lee@kernel.org \
--cc=andre.przywara@arm.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox