From: Richard Genoud <richard.genoud@bootlin.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Wentao Liang" <vulab@iscas.ac.cn>,
"Johan Hovold" <johan@kernel.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
"Richard Genoud" <richard.genoud@bootlin.com>
Subject: [PATCH v4 08/16] mtd: rawnand: sunxi: add has_ecc_block_512 capability
Date: Tue, 28 Oct 2025 08:35:01 +0100 [thread overview]
Message-ID: <20251028073534.526992-9-richard.genoud@bootlin.com> (raw)
In-Reply-To: <20251028073534.526992-1-richard.genoud@bootlin.com>
The H616 controller can't handle 512 bytes ECC block size. The
NFC_ECC_BLOCK_512 bit disappeared in H6, and NDFC_RANDOM_EN took its
place.
So, add has_ecc_block_512 capability to only set this bit on SoC having
it.
No functional change.
Signed-off-by: Richard Genoud <richard.genoud@bootlin.com>
---
drivers/mtd/nand/raw/sunxi_nand.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c
index 021034a761b7..7976cd862b1b 100644
--- a/drivers/mtd/nand/raw/sunxi_nand.c
+++ b/drivers/mtd/nand/raw/sunxi_nand.c
@@ -233,6 +233,7 @@ static inline struct sunxi_nand_chip *to_sunxi_nand(struct nand_chip *nand)
*
* @has_mdma: Use mbus dma mode, otherwise general dma
* through MBUS on A23/A33 needs extra configuration.
+ * @has_ecc_block_512: If the ECC can handle 512B or only 1024B chuncks
* @reg_io_data: I/O data register
* @reg_ecc_err_cnt: ECC error counter register
* @reg_user_data: User data register
@@ -244,6 +245,7 @@ static inline struct sunxi_nand_chip *to_sunxi_nand(struct nand_chip *nand)
*/
struct sunxi_nfc_caps {
bool has_mdma;
+ bool has_ecc_block_512;
unsigned int reg_io_data;
unsigned int reg_ecc_err_cnt;
unsigned int reg_user_data;
@@ -1758,8 +1760,14 @@ static int sunxi_nand_hw_ecc_ctrl_init(struct nand_chip *nand,
sunxi_nand->ecc.ecc_ctl = NFC_ECC_MODE(i) | NFC_ECC_EXCEPTION |
NFC_ECC_PIPELINE | NFC_ECC_EN;
- if (ecc->size == 512)
- sunxi_nand->ecc.ecc_ctl |= NFC_ECC_BLOCK_512;
+ if (ecc->size == 512) {
+ if (nfc->caps->has_ecc_block_512) {
+ sunxi_nand->ecc.ecc_ctl |= NFC_ECC_BLOCK_512;
+ } else {
+ dev_err(nfc->dev, "512B ECC block not supported\n");
+ return -EOPNOTSUPP;
+ }
+ }
return 0;
}
@@ -2214,6 +2222,7 @@ static const u8 sunxi_ecc_strengths_a10[] = {
};
static const struct sunxi_nfc_caps sunxi_nfc_a10_caps = {
+ .has_ecc_block_512 = true,
.reg_io_data = NFC_REG_A10_IO_DATA,
.reg_ecc_err_cnt = NFC_REG_A10_ECC_ERR_CNT,
.reg_user_data = NFC_REG_A10_USER_DATA,
@@ -2226,6 +2235,7 @@ static const struct sunxi_nfc_caps sunxi_nfc_a10_caps = {
static const struct sunxi_nfc_caps sunxi_nfc_a23_caps = {
.has_mdma = true,
+ .has_ecc_block_512 = true,
.reg_io_data = NFC_REG_A23_IO_DATA,
.reg_ecc_err_cnt = NFC_REG_A10_ECC_ERR_CNT,
.reg_user_data = NFC_REG_A10_USER_DATA,
--
2.47.3
next prev parent reply other threads:[~2025-10-28 7:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 7:34 [PATCH v4 00/16] Introduce Allwinner H6/H616 NAND controller support Richard Genoud
2025-10-28 7:34 ` [PATCH v4 01/16] dt-bindings: mtd: sunxi: Add H616 compatible Richard Genoud
2025-10-28 7:34 ` [PATCH v4 02/16] mtd: rawnand: sunxi: Remove superfluous register readings Richard Genoud
2025-10-28 7:34 ` [PATCH v4 03/16] mtd: rawnand: sunxi: Replace hard coded value by a define Richard Genoud
2025-10-28 15:34 ` Jernej Škrabec
2025-10-28 7:34 ` [PATCH v4 04/16] mtd: rawnand: sunxi: move ECC strenghts in sunxi_nfc_caps Richard Genoud
2025-10-28 7:34 ` [PATCH v4 05/16] mtd: rawnand: sunxi: introduce reg_ecc_err_cnt " Richard Genoud
2025-10-28 15:36 ` Jernej Škrabec
2025-10-28 7:34 ` [PATCH v4 06/16] mtd: rawnand: sunxi: introduce reg_user_data " Richard Genoud
2025-10-28 15:37 ` Jernej Škrabec
2025-10-28 7:35 ` [PATCH v4 07/16] mtd: rawnand: sunxi: rework pattern found registers Richard Genoud
2025-10-28 15:41 ` Jernej Škrabec
2025-10-28 16:20 ` Miquel Raynal
2025-10-28 7:35 ` Richard Genoud [this message]
2025-10-28 15:43 ` [PATCH v4 08/16] mtd: rawnand: sunxi: add has_ecc_block_512 capability Jernej Škrabec
2025-10-28 7:35 ` [PATCH v4 09/16] mtd: rawnand: sunxi: introduce ecc_mode_mask in sunxi_nfc_caps Richard Genoud
2025-10-28 7:35 ` [PATCH v4 10/16] mtd: rawnand: sunxi: introduce random en/dir " Richard Genoud
2025-10-28 7:35 ` [PATCH v4 11/16] mtd: rawnand: sunxi: introduce reg_pat_id " Richard Genoud
2025-10-28 15:45 ` Jernej Škrabec
2025-10-28 7:35 ` [PATCH v4 12/16] mtd: rawnand: sunxi: introduce reg_spare_area " Richard Genoud
2025-10-28 15:45 ` Jernej Škrabec
2025-10-28 7:35 ` [PATCH v4 13/16] mtd: rawnand: sunxi: introduce ecc_err_mask " Richard Genoud
2025-10-28 7:35 ` [PATCH v4 14/16] mtd: rawnand: sunxi: introduce sram_size " Richard Genoud
2025-10-28 15:46 ` Jernej Škrabec
2025-10-28 7:35 ` [PATCH v4 15/16] mtd: rawnand: sunxi: Add support for H616 nand controller Richard Genoud
2025-10-28 7:35 ` [PATCH v4 16/16] arm64: dts: allwinner: h616: add NAND controller Richard Genoud
2025-10-28 16:23 ` [PATCH v4 00/16] Introduce Allwinner H6/H616 NAND controller support Miquel Raynal
2025-10-28 17:05 ` (subset) " Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028073534.526992-9-richard.genoud@bootlin.com \
--to=richard.genoud@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=johan@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=miquel.raynal@bootlin.com \
--cc=mripard@kernel.org \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=vigneshr@ti.com \
--cc=vulab@iscas.ac.cn \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox