From: Simon Horman <horms@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: Li Youhong <dayou5941@163.com>, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH] net: sun4i-emac: fix missing of_node_put() for phy_node
Date: Thu, 10 Sep 2026 10:32:36 +0100 [thread overview]
Message-ID: <20260910093236.GP40544@horms.kernel.org> (raw)
In-Reply-To: <20260905080854.5CAB41F00A3D@smtp.kernel.org>
On Sat, Sep 05, 2026 at 08:08:53AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
>
> Pre-existing issues:
> - [High] Unconditional call to `dma_release_channel()` with a potentially NULL pointer in the `emac_probe()` error path causes a kernel panic.
> - [High] Premature release of the DMA channel before `unregister_netdev()` in `emac_remove()` creates a use-after-free race condition.
While these seem to be real bugs that ought to be fixed
I don't think they need block progress of this patch.
next prev parent reply other threads:[~2026-09-10 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 8:07 [PATCH] net: sun4i-emac: fix missing of_node_put() for phy_node Li Youhong
2026-09-05 8:08 ` sashiko-bot
2026-09-10 9:32 ` Simon Horman [this message]
2026-09-10 9:31 ` Simon Horman
2026-09-10 10:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910093236.GP40544@horms.kernel.org \
--to=horms@kernel.org \
--cc=dayou5941@163.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox