From: sashiko-bot@kernel.org
To: "Andre Przywara" <andre.przywara@arm.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org,
linux-sunxi@lists.linux.dev, conor+dt@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: vendor-prefixes: Add vendor prefix for Teclast
Date: Mon, 14 Sep 2026 21:11:38 +0000 [thread overview]
Message-ID: <20260914211139.48AA61F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260914210115.28151-2-andre.przywara@arm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added vendor prefix `^teclast,.*` is inserted out of alphabetical order.
--
commit 5eadfadaf4aefd64a40c08bf27f4fc8d4fc5a0a6
Author: Andre Przywara <andre.przywara@arm.com>
dt-bindings: vendor-prefixes: Add vendor prefix for Teclast
This commit adds a new vendor prefix for Teclast to the device tree
vendor-prefixes.yaml file. Teclast is a manufacturer of tablets, laptops,
and mini PCs.
Link: https://www.teclast.com [1]
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index ba20029693734..6da733d465a31 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -1722,6 +1722,8 @@ patternProperties:
> description: Thundercomm Technology Co., Ltd.
> "^thwc,.*":
> description: Shenzhen Tong Heng Wei Chuang Technology Co., Ltd.
> + "^teclast,.*":
> + description: Teclast
[Severity: Low]
Is this newly added vendor prefix inserted out of alphabetical order?
In the patternProperties section of vendor-prefixes.yaml, there is a
requirement to keep the list in alphabetical order. Alphabetically, the
entry "^teclast,.*" should be placed after "^techwell,.*" and before
"^teejet,.*", rather than after "^thwc,.*".
> "^ti,.*":
> description: Texas Instruments
> "^tianma,.*":
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260914210115.28151-1-andre.przywara@arm.com?part=1
next prev parent reply other threads:[~2026-09-14 21:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 21:01 [PATCH 0/3] dts: allwinner: Add Teclast P80 tablet support Andre Przywara
2026-09-14 21:01 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add vendor prefix for Teclast Andre Przywara
2026-09-14 21:11 ` sashiko-bot [this message]
2026-09-14 22:53 ` Andre Przywara
2026-09-15 16:59 ` Conor Dooley
2026-09-14 21:01 ` [PATCH 2/3] dt-bindings: arm: sunxi: Add two Teclast tablets Andre Przywara
2026-09-14 21:19 ` sashiko-bot
2026-09-14 22:51 ` Andre Przywara
2026-09-15 16:58 ` Conor Dooley
2026-09-15 21:01 ` Andre Przywara
2026-09-16 16:20 ` Conor
2026-09-18 6:55 ` Krzysztof Kozlowski
2026-09-14 21:01 ` [PATCH 3/3] arm64: dts: allwinner: A133: add basic support for Teclast P80 tablet Andre Przywara
2026-09-21 15:59 ` [PATCH 0/3] dts: allwinner: Add Teclast P80 tablet support Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914211139.48AA61F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=andre.przywara@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox