Re: [PATCH 2/3] dt-bindings: arm: sunxi: Add two Teclast tablets

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2935 bytes --]

On Tue, Sep 15, 2026 at 12:51:22AM +0200, Andre Przywara wrote:
> On Mon, 14 Sep 2026 21:19:39 +0000
> sashiko-bot@kernel.org wrote:
> 
> > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> > - [High] Missing SoC fallback compatible string 'allwinner,sun50i-a100' for the Teclast P80 tablet breaks CPU frequency scaling.
> 
> Well, there is more to it. We should rather add the a133 as an explicit
> name in the driver, like we did for the H616 family. And the whole OPP
> table is still from the old A100 days, it doesn't really cover the A133
> or A133P values, which go up to 1.6GHz and 2.0 GHz, respectively.
> The bin selection in the driver is also not adequate, the BSP code
> seems to use the SID cell at 0x00 to select one of two speed bins, at
> least for the A133. The A133P is probably still different.
> 
> So I'd rather keep the a133 fallback compatible, and adjust the driver.

Can you explain the complaint from Sashiko to me?
From where I am sitting, without awareness of allwinner SKUs, it seems
like the bot is suggesting that you add a "random" fallback to make a
driver probe.

> 
> Cheers,
> Andre
> 
> > --
> > 
> > commit 582b866f1ad9000afddf47eb7e4c9d37a95dfbc8
> > Author: Andre Przywara <andre.przywara@arm.com>
> > 
> > dt-bindings: arm: sunxi: Add two Teclast tablets
> > 
> > This commit adds devicetree bindings for the Teclast P80 and P85T tablets.
> > The Teclast P80 is based on the Allwinner A133 SoC, and the P85T uses the
> > Allwinner A523 SoC.
> > 
> > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > index f04db28c630ac..28437c47ac01b 100644
> > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > @@ -933,6 +933,16 @@ properties:
> > 
> > [ ... ]
> > 
> > > +      - description: Teclast P80 Tablet
> > > +        items:
> > > +          - const: teclast,p80
> > > +          - const: allwinner,sun50i-a133
> > 
> > [Severity: High]
> > Does this strict two-item compatible array omit the necessary fallback string?
> > 
> > The sun50i-cpufreq-nvmem driver in drivers/cpufreq/sun50i-cpufreq-nvmem.c
> > requires allwinner,sun50i-a100 to exist in the root node's compatible array
> > to bind via of_machine_device_match(sun50i_cpufreq_match_list).
> > 
> > Without this fallback string included in the bindings (and subsequently the
> > board's Device Tree), cpufreq-dt will not be instantiated. This will cause
> > CPU frequency scaling to silently fail on the Teclast P80 tablet, leaving
> > the system stuck at the bootloader-configured frequency.
> > 
> > > +
> > > +      - description: Teclast P85T Tablet
> > > +        items:
> > > +          - const: teclast,p85t
> > > +          - const: allwinner,sun55i-a523
> > > +
> > 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]