ARM Sunxi Platform Development
 help / color / mirror / Atom feed
* [PATCH 1/7] bus: sunxi-rsb: Convert to devm_platform_ioremap_resource()
@ 2023-07-06  7:20 Yangtao Li
  2023-07-11 18:25 ` Jernej Škrabec
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Yangtao Li @ 2023-07-06  7:20 UTC (permalink / raw)
  To: Chen-Yu Tsai, Jernej Skrabec, Samuel Holland
  Cc: Yangtao Li, linux-arm-kernel, linux-sunxi, linux-kernel

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/bus/sunxi-rsb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c
index 696c0aefb0ca..2aefd5dde3c9 100644
--- a/drivers/bus/sunxi-rsb.c
+++ b/drivers/bus/sunxi-rsb.c
@@ -746,7 +746,6 @@ static int sunxi_rsb_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct device_node *np = dev->of_node;
-	struct resource *r;
 	struct sunxi_rsb *rsb;
 	u32 clk_freq = 3000000;
 	int irq, ret;
@@ -766,8 +765,7 @@ static int sunxi_rsb_probe(struct platform_device *pdev)
 	rsb->dev = dev;
 	rsb->clk_freq = clk_freq;
 	platform_set_drvdata(pdev, rsb);
-	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	rsb->regs = devm_ioremap_resource(dev, r);
+	rsb->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(rsb->regs))
 		return PTR_ERR(rsb->regs);
 
-- 
2.39.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/7] bus: sunxi-rsb: Convert to devm_platform_ioremap_resource()
  2023-07-06  7:20 [PATCH 1/7] bus: sunxi-rsb: Convert to devm_platform_ioremap_resource() Yangtao Li
@ 2023-07-11 18:25 ` Jernej Škrabec
  2023-07-21 15:28 ` (subset) " Thierry Reding
  2023-07-30 22:50 ` Jernej Škrabec
  2 siblings, 0 replies; 4+ messages in thread
From: Jernej Škrabec @ 2023-07-11 18:25 UTC (permalink / raw)
  To: Chen-Yu Tsai, Samuel Holland, Yangtao Li
  Cc: Yangtao Li, linux-arm-kernel, linux-sunxi, linux-kernel

Dne četrtek, 06. julij 2023 ob 09:20:36 CEST je Yangtao Li napisal(a):
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> ---
>  drivers/bus/sunxi-rsb.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c
> index 696c0aefb0ca..2aefd5dde3c9 100644
> --- a/drivers/bus/sunxi-rsb.c
> +++ b/drivers/bus/sunxi-rsb.c
> @@ -746,7 +746,6 @@ static int sunxi_rsb_probe(struct platform_device *pdev)
> {
>  	struct device *dev = &pdev->dev;
>  	struct device_node *np = dev->of_node;
> -	struct resource *r;
>  	struct sunxi_rsb *rsb;
>  	u32 clk_freq = 3000000;
>  	int irq, ret;
> @@ -766,8 +765,7 @@ static int sunxi_rsb_probe(struct platform_device *pdev)
> rsb->dev = dev;
>  	rsb->clk_freq = clk_freq;
>  	platform_set_drvdata(pdev, rsb);
> -	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	rsb->regs = devm_ioremap_resource(dev, r);
> +	rsb->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(rsb->regs))
>  		return PTR_ERR(rsb->regs);





^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: (subset) [PATCH 1/7] bus: sunxi-rsb: Convert to devm_platform_ioremap_resource()
  2023-07-06  7:20 [PATCH 1/7] bus: sunxi-rsb: Convert to devm_platform_ioremap_resource() Yangtao Li
  2023-07-11 18:25 ` Jernej Škrabec
@ 2023-07-21 15:28 ` Thierry Reding
  2023-07-30 22:50 ` Jernej Škrabec
  2 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2023-07-21 15:28 UTC (permalink / raw)
  To: Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Yangtao Li
  Cc: linux-arm-kernel, linux-sunxi, linux-kernel

From: Thierry Reding <treding@nvidia.com>


On Thu, 06 Jul 2023 15:20:36 +0800, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
> 
> 

Applied, thanks!

[5/7] bus: tegra-gmi: Convert to devm_platform_ioremap_resource()
      commit: df823d210395341c58e8d346dfc37d6e67e9f2c6

Best regards,
-- 
Thierry Reding <treding@nvidia.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/7] bus: sunxi-rsb: Convert to devm_platform_ioremap_resource()
  2023-07-06  7:20 [PATCH 1/7] bus: sunxi-rsb: Convert to devm_platform_ioremap_resource() Yangtao Li
  2023-07-11 18:25 ` Jernej Škrabec
  2023-07-21 15:28 ` (subset) " Thierry Reding
@ 2023-07-30 22:50 ` Jernej Škrabec
  2 siblings, 0 replies; 4+ messages in thread
From: Jernej Škrabec @ 2023-07-30 22:50 UTC (permalink / raw)
  To: Chen-Yu Tsai, Samuel Holland, Yangtao Li
  Cc: Yangtao Li, linux-arm-kernel, linux-sunxi, linux-kernel

Dne četrtek, 06. julij 2023 ob 09:20:36 CEST je Yangtao Li napisal(a):
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Applied, thanks!

Best regards,
Jernej



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-07-30 22:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-06  7:20 [PATCH 1/7] bus: sunxi-rsb: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-11 18:25 ` Jernej Škrabec
2023-07-21 15:28 ` (subset) " Thierry Reding
2023-07-30 22:50 ` Jernej Škrabec

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox