From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Samuel Holland" <samuel@sholland.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, kernel@pengutronix.de
Subject: Re: [PATCH 082/117] media: sun8i-di: Convert to platform remove callback returning void
Date: Sun, 26 Mar 2023 20:17:48 +0200 [thread overview]
Message-ID: <3486523.iIbC2pHGDl@kista> (raw)
In-Reply-To: <20230326143224.572654-85-u.kleine-koenig@pengutronix.de>
Dne nedelja, 26. marec 2023 ob 16:31:49 CEST je Uwe Kleine-König napisal(a):
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
next prev parent reply other threads:[~2023-03-26 18:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 14:30 [PATCH 000/117] media: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-26 14:31 ` [PATCH 078/117] media: sun4i_csi: " Uwe Kleine-König
2023-03-26 18:19 ` Jernej Škrabec
2023-03-26 14:31 ` [PATCH 079/117] media: sun6i_csi: " Uwe Kleine-König
2023-03-26 18:19 ` Jernej Škrabec
2023-03-26 14:31 ` [PATCH 080/117] media: sun6i_mipi_csi2: " Uwe Kleine-König
2023-03-26 18:18 ` Jernej Škrabec
2023-03-26 14:31 ` [PATCH 081/117] media: sun8i_a83t_mipi_csi2: " Uwe Kleine-König
2023-03-26 18:18 ` Jernej Škrabec
2023-03-26 14:31 ` [PATCH 082/117] media: sun8i-di: " Uwe Kleine-König
2023-03-26 18:17 ` Jernej Škrabec [this message]
2023-03-26 14:31 ` [PATCH 083/117] media: sun8i_rotate: " Uwe Kleine-König
2023-03-26 18:18 ` Jernej Škrabec
2023-03-26 14:32 ` [PATCH 110/117] media: sunxi-cir: " Uwe Kleine-König
2023-03-26 18:19 ` Jernej Škrabec
2023-04-17 6:02 ` [PATCH 000/117] media: " Uwe Kleine-König
2023-04-17 6:19 ` Laurent Pinchart
2023-04-17 7:30 ` Uwe Kleine-König
2023-04-17 7:35 ` Laurent Pinchart
2023-04-17 7:57 ` Biju Das
2023-04-17 8:54 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3486523.iIbC2pHGDl@kista \
--to=jernej.skrabec@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=samuel@sholland.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox