* [PATCH v1] clk: sunxi: sun9i-mmc: Use dev_err_probe() to simplfy code
@ 2024-08-30 7:27 Chen Yufan
2024-08-30 17:53 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Chen Yufan @ 2024-08-30 7:27 UTC (permalink / raw)
To: Emilio López, Michael Turquette, Stephen Boyd, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, linux-clk, linux-arm-kernel,
linux-sunxi, linux-kernel
Cc: opensource.kernel, Chen Yufan
Use dev_err_probe() can make code a bit simpler.
Signed-off-by: Chen Yufan <chenyufan@vivo.com>
---
drivers/clk/sunxi/clk-sun9i-mmc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/sunxi/clk-sun9i-mmc.c b/drivers/clk/sunxi/clk-sun9i-mmc.c
index 91074017c04f..e6b62e421936 100644
--- a/drivers/clk/sunxi/clk-sun9i-mmc.c
+++ b/drivers/clk/sunxi/clk-sun9i-mmc.c
@@ -134,10 +134,8 @@ static int sun9i_a80_mmc_config_clk_probe(struct platform_device *pdev)
}
ret = reset_control_deassert(data->reset);
- if (ret) {
- dev_err(&pdev->dev, "Reset deassert err %d\n", ret);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(&pdev->dev, ret, "Reset deassert err %d\n");
clk_parent = __clk_get_name(data->clk);
for (i = 0; i < count; i++) {
--
2.39.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1] clk: sunxi: sun9i-mmc: Use dev_err_probe() to simplfy code
2024-08-30 7:27 [PATCH v1] clk: sunxi: sun9i-mmc: Use dev_err_probe() to simplfy code Chen Yufan
@ 2024-08-30 17:53 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-30 17:53 UTC (permalink / raw)
To: Chen Yufan, Emilio López, Michael Turquette, Stephen Boyd,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-clk,
linux-arm-kernel, linux-sunxi, linux-kernel
Cc: opensource.kernel
On 30/08/2024 09:27, Chen Yufan wrote:
> Use dev_err_probe() can make code a bit simpler.
>
> Signed-off-by: Chen Yufan <chenyufan@vivo.com>
> ---
> drivers/clk/sunxi/clk-sun9i-mmc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/sunxi/clk-sun9i-mmc.c b/drivers/clk/sunxi/clk-sun9i-mmc.c
> index 91074017c04f..e6b62e421936 100644
> --- a/drivers/clk/sunxi/clk-sun9i-mmc.c
> +++ b/drivers/clk/sunxi/clk-sun9i-mmc.c
> @@ -134,10 +134,8 @@ static int sun9i_a80_mmc_config_clk_probe(struct platform_device *pdev)
> }
>
> ret = reset_control_deassert(data->reset);
> - if (ret) {
> - dev_err(&pdev->dev, "Reset deassert err %d\n", ret);
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(&pdev->dev, ret, "Reset deassert err %d\n");
This is ridiculous.
You change something which cannot defer, while leaving other places
which actually can defer and could benefit.
Stop spamming with such low quality patches.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-30 17:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-30 7:27 [PATCH v1] clk: sunxi: sun9i-mmc: Use dev_err_probe() to simplfy code Chen Yufan
2024-08-30 17:53 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox