From: Adrian Hunter <adrian.hunter@intel.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Joerg Roedel <joro@8bytes.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Robin Murphy <robin.murphy@arm.com>
Cc: Thierry Reding <treding@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Prathamesh Shete <pshete@nvidia.com>,
Will Deacon <will@kernel.org>,
iommu@lists.linux-foundation.org, linux-mmc@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v11 3/6] mmc: sdhci-tegra: Sort includes alphabetically
Date: Fri, 18 Nov 2022 09:32:58 +0200 [thread overview]
Message-ID: <11a4e08b-f176-a39a-365c-278b08fc1bdb@intel.com> (raw)
In-Reply-To: <20221117182720.2290761-4-thierry.reding@gmail.com>
On 17/11/22 20:27, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Sort includes alphabetically to make it easier to add new ones
> subsequently.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/mmc/host/sdhci-tegra.c | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
12 insertions and 11 deletions because linux/bitfield.h
was added.
I am not super enthusiastic about reordering includes.
I would advise people to text search to find an include
instead.
Nevertheless:
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index c71000a07656..e2a8488d4fa9 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -3,28 +3,29 @@
> * Copyright (C) 2010 Google, Inc.
> */
>
> +#include <linux/bitfield.h>
> +#include <linux/clk.h>
> #include <linux/delay.h>
> #include <linux/dma-mapping.h>
> #include <linux/err.h>
> -#include <linux/module.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/init.h>
> -#include <linux/iopoll.h>
> -#include <linux/platform_device.h>
> -#include <linux/clk.h>
> #include <linux/io.h>
> -#include <linux/of.h>
> +#include <linux/iopoll.h>
> +#include <linux/ktime.h>
> +#include <linux/mmc/card.h>
> +#include <linux/mmc/host.h>
> +#include <linux/mmc/mmc.h>
> +#include <linux/mmc/slot-gpio.h>
> +#include <linux/module.h>
> #include <linux/of_device.h>
> +#include <linux/of.h>
> #include <linux/pinctrl/consumer.h>
> +#include <linux/platform_device.h>
> #include <linux/pm_opp.h>
> #include <linux/pm_runtime.h>
> #include <linux/regulator/consumer.h>
> #include <linux/reset.h>
> -#include <linux/mmc/card.h>
> -#include <linux/mmc/host.h>
> -#include <linux/mmc/mmc.h>
> -#include <linux/mmc/slot-gpio.h>
> -#include <linux/gpio/consumer.h>
> -#include <linux/ktime.h>
>
> #include <soc/tegra/common.h>
>
next prev parent reply other threads:[~2022-11-18 7:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 18:27 [PATCH v11 0/6] mmc: sdhci: Add Tegra234 support Thierry Reding
2022-11-17 18:27 ` [PATCH v11 1/6] iommu: Add note about struct iommu_fwspec usage Thierry Reding
2022-11-19 9:51 ` Joerg Roedel
2022-11-17 18:27 ` [PATCH v11 2/6] iommu/tegra: Add tegra_dev_iommu_get_stream_id() helper Thierry Reding
2022-11-18 8:08 ` Ulf Hansson
2022-12-02 10:31 ` Thierry Reding
2022-11-17 18:27 ` [PATCH v11 3/6] mmc: sdhci-tegra: Sort includes alphabetically Thierry Reding
2022-11-18 7:32 ` Adrian Hunter [this message]
2022-11-18 8:01 ` Ulf Hansson
2022-11-17 18:27 ` [PATCH v11 4/6] mmc: sdhci-tegra: Separate Tegra194 and Tegra234 SoC data Thierry Reding
2022-11-17 18:27 ` [PATCH v11 5/6] mmc: sdhci-tegra: Add support to program MC stream ID Thierry Reding
2022-11-17 18:27 ` [PATCH v11 6/6] mmc: sdhci-tegra: Issue CMD and DAT resets together Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11a4e08b-f176-a39a-365c-278b08fc1bdb@intel.com \
--to=adrian.hunter@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pshete@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox