[PATCH 1/2] ARM: tegra: enable PINCTRL_PALMAS config

[PATCH 1/2] ARM: tegra: enable PINCTRL_PALMAS config

[Laxman Dewangan]

PALMAS PMIC is used on Dalmore platform. Enable the pincontrol
driver for Palmas to configure pins of Palmas on desired state.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
 arch/arm/configs/tegra_defconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig
index 8c284ff..e5012dc 100644
--- a/arch/arm/configs/tegra_defconfig
+++ b/arch/arm/configs/tegra_defconfig
@@ -128,6 +128,7 @@ CONFIG_SPI=y
 CONFIG_SPI_TEGRA114=y
 CONFIG_SPI_TEGRA20_SFLASH=y
 CONFIG_SPI_TEGRA20_SLINK=y
+CONFIG_PINCTRL_PALMAS=y
 CONFIG_GPIO_PCA953X_IRQ=y
 CONFIG_GPIO_PALMAS=y
 CONFIG_GPIO_TPS6586X=y
-- 
1.7.1.1

[PATCH 2/2] ARM: tegra: add Palmas pincontrol to Dalmore device tree

[Laxman Dewangan]

Add Palmas pincontrol to Dalmore device tree and make following
configuration as default:
- Disable DVFS1 and DVFS2.
- Set GPIO6 to gpio mode.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
 arch/arm/boot/dts/tegra114-dalmore.dts |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
index 45056a2..44413dd 100644
--- a/arch/arm/boot/dts/tegra114-dalmore.dts
+++ b/arch/arm/boot/dts/tegra114-dalmore.dts
@@ -1009,6 +1009,19 @@
 				interrupt-parent = <&palmas>;
 				interrupts = <8 0>;
 			};
+
+			palmas_pinctrl {
+				compatible = "ti,tps65913-pinctrl";
+				pinctrl-names = "default";
+				pinctrl-0 = <&palmas_default>;
+
+				palmas_default: palams_pinctrl {
+					pin_gpio6 {
+						pins = "gpio6";
+						function = "gpio";
+					};
+				};
+			};
 		};
 	};
 
-- 
1.7.1.1

Re: [PATCH 2/2] ARM: tegra: add Palmas pincontrol to Dalmore device tree

[Stephen Warren]

On 08/21/2013 06:34 AM, Laxman Dewangan wrote:
> Add Palmas pincontrol to Dalmore device tree and make following
> configuration as default:
> - Disable DVFS1 and DVFS2.
> - Set GPIO6 to gpio mode.

> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts

> +			palmas_pinctrl {
> +				compatible = "ti,tps65913-pinctrl";

A node name of "pinmux" would be more appropriate here, since the node
name should represent device type rather than device identity.

Aside from that, the series looks fine, but at this point will have to
wait for 3.13 I think, unless this series has a side-effect of fixing
some bug/regression. Can you please repost once 3.12-rc1 is out?

Re: [PATCH 2/2] ARM: tegra: add Palmas pincontrol to Dalmore device tree

[Laxman Dewangan]

On Wednesday 21 August 2013 10:59 PM, Stephen Warren wrote:
> On 08/21/2013 06:34 AM, Laxman Dewangan wrote:
>> Add Palmas pincontrol to Dalmore device tree and make following
>> configuration as default:
>> - Disable DVFS1 and DVFS2.
>> - Set GPIO6 to gpio mode.
>> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
>> +			palmas_pinctrl {
>> +				compatible = "ti,tps65913-pinctrl";
> A node name of "pinmux" would be more appropriate here, since the node
> name should represent device type rather than device identity.
>
> Aside from that, the series looks fine, but at this point will have to
> wait for 3.13 I think, unless this series has a side-effect of fixing
> some bug/regression. Can you please repost once 3.12-rc1 is out?

Sure, I will correct the node name and post the patch later.