* Re: [PATCH v2] PM / devfreq: tegra: Register governor on module init
@ 2015-03-31 2:16 MyungJoo Ham
0 siblings, 0 replies; 2+ messages in thread
From: MyungJoo Ham @ 2015-03-31 2:16 UTC (permalink / raw)
To: Tomeu Vizoso, linux-kernel@vger.kernel.org
Cc: linux-tegra@vger.kernel.org, 박경민,
Stephen Warren, Thierry Reding, Alexandre Courbot,
linux-pm@vger.kernel.org
> Sender : Tomeu Vizoso<tomeu.vizoso@collabora.com>
> Date : 2015-03-31 00:33 (GMT+09:00)
> Title : [PATCH v2] PM / devfreq: tegra: Register governor on module init
>
> So this driver builds as a module.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
>
> v2: * Remove governor if driver registration fails
> ---
> drivers/devfreq/tegra-devfreq.c | 37 ++++++++++++++++++++++++++++++-------
> 1 file changed, 30 insertions(+), 7 deletions(-)
>
Thanks. Merged.
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Cheers,
MyungJoo.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] PM / devfreq: tegra: Register governor on module init
@ 2015-03-30 15:08 Thierry Reding
2015-03-30 15:33 ` [PATCH v2] " Tomeu Vizoso
0 siblings, 1 reply; 2+ messages in thread
From: Thierry Reding @ 2015-03-30 15:08 UTC (permalink / raw)
To: Tomeu Vizoso
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA, MyungJoo Ham, Kyungmin Park,
Stephen Warren, Alexandre Courbot,
linux-pm-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 439 bytes --]
On Mon, Mar 30, 2015 at 02:54:38PM +0200, Tomeu Vizoso wrote:
[...]
> +static int __init tegra_devfreq_init(void)
> +{
> + int ret = 0;
> +
> + ret = devfreq_add_governor(&tegra_devfreq_governor);
> + if (ret) {
> + pr_err("%s: failed to add governor: %d\n", __func__, ret);
> + return ret;
> + }
> +
> + return platform_driver_register(&tegra_devfreq_driver);
Shouldn't you remove the governor on driver registration failure?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH v2] PM / devfreq: tegra: Register governor on module init
2015-03-30 15:08 [PATCH] " Thierry Reding
@ 2015-03-30 15:33 ` Tomeu Vizoso
0 siblings, 0 replies; 2+ messages in thread
From: Tomeu Vizoso @ 2015-03-30 15:33 UTC (permalink / raw)
To: linux-kernel
Cc: linux-tegra, Tomeu Vizoso, MyungJoo Ham, Kyungmin Park,
Stephen Warren, Thierry Reding, Alexandre Courbot, linux-pm
So this driver builds as a module.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
v2: * Remove governor if driver registration fails
---
drivers/devfreq/tegra-devfreq.c | 37 ++++++++++++++++++++++++++++++-------
1 file changed, 30 insertions(+), 7 deletions(-)
diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
index 8e633a6..13a1a6e 100644
--- a/drivers/devfreq/tegra-devfreq.c
+++ b/drivers/devfreq/tegra-devfreq.c
@@ -606,12 +606,6 @@ static struct devfreq_governor tegra_devfreq_governor = {
.event_handler = tegra_governor_event_handler,
};
-static int __init tegra_governor_init(void)
-{
- return devfreq_add_governor(&tegra_devfreq_governor);
-}
-subsys_initcall(tegra_governor_init);
-
static int tegra_devfreq_probe(struct platform_device *pdev)
{
struct tegra_devfreq *tegra;
@@ -755,7 +749,36 @@ static struct platform_driver tegra_devfreq_driver = {
.of_match_table = tegra_devfreq_of_match,
},
};
-module_platform_driver(tegra_devfreq_driver);
+
+static int __init tegra_devfreq_init(void)
+{
+ int ret = 0;
+
+ ret = devfreq_add_governor(&tegra_devfreq_governor);
+ if (ret) {
+ pr_err("%s: failed to add governor: %d\n", __func__, ret);
+ return ret;
+ }
+
+ ret = platform_driver_register(&tegra_devfreq_driver);
+ if (ret)
+ devfreq_remove_governor(&tegra_devfreq_governor);
+
+ return ret;
+}
+module_init(tegra_devfreq_init)
+
+static void __exit tegra_devfreq_exit(void)
+{
+ int ret = 0;
+
+ platform_driver_unregister(&tegra_devfreq_driver);
+
+ ret = devfreq_remove_governor(&tegra_devfreq_governor);
+ if (ret)
+ pr_err("%s: failed to remove governor: %d\n", __func__, ret);
+}
+module_exit(tegra_devfreq_exit)
MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("Tegra devfreq driver");
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-31 2:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-31 2:16 [PATCH v2] PM / devfreq: tegra: Register governor on module init MyungJoo Ham
-- strict thread matches above, loose matches on Subject: below --
2015-03-30 15:08 [PATCH] " Thierry Reding
2015-03-30 15:33 ` [PATCH v2] " Tomeu Vizoso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox