From: "Rob Herring (Arm)" <robh@kernel.org>
To: Vishwaroop A <va@nvidia.com>
Cc: linux-tegra@vger.kernel.org, smangipudi@nvidia.com,
linux-spi@vger.kernel.org, skomatineni@nvidia.com,
thierry.reding@gmail.com, kyarlagadda@nvidia.com,
ldewangan@nvidia.com, linux-kernel@vger.kernel.org,
broonie@kernel.org, jonathanh@nvidia.com
Subject: Re: [PATCH v3 0/6] Configure Clocks, Add Internal DMA support
Date: Wed, 16 Apr 2025 07:43:39 -0500 [thread overview]
Message-ID: <174480737097.2514153.5351260600015584210.robh@kernel.org> (raw)
In-Reply-To: <20250416110606.2737315-1-va@nvidia.com>
On Wed, 16 Apr 2025 11:06:00 +0000, Vishwaroop A wrote:
> This series introduces QSPI clock configuration and internal DMA
> support for Quad SPI controller. The patches have been reorganized
> for better logical flow and review comments from v2 have been addressed.
>
> Vishwaroop A (6):
> spi: tegra210-quad: Fix X1_X2_X4 encoding and support x4 transfers
> spi: tegra210-quad: remove redundant error handling code
> spi: tegra210-quad: modify chip select (CS) deactivation
> arm64: tegra: Configure QSPI clocks and add DMA
> spi: tegra210-quad: Update dummy sequence configuration
> spi: tegra210-quad: Add support for internal DMA
>
> arch/arm64/boot/dts/nvidia/tegra234.dtsi | 10 +
> drivers/spi/spi-tegra210-quad.c | 282 +++++++++++++----------
> 2 files changed, 176 insertions(+), 116 deletions(-)
>
> ---
> v2 -> v3:
> * Reorganized the patches.
> * Addressed review comments received on the patches.
> ---
>
> --
> 2.17.1
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: attempting to guess base-commit...
Base: tags/v6.15-rc2-1-g36ff6c3f5084 (exact match)
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/nvidia/' for 20250416110606.2737315-1-va@nvidia.com:
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: spi@3270000 (nvidia,tegra234-qspi): Unevaluated properties are not allowed ('iommus' was unexpected)
from schema $id: http://devicetree.org/schemas/spi/nvidia,tegra210-quad.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dtb: spi@3270000 (nvidia,tegra234-qspi): Unevaluated properties are not allowed ('iommus' was unexpected)
from schema $id: http://devicetree.org/schemas/spi/nvidia,tegra210-quad.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0005.dtb: spi@3270000 (nvidia,tegra234-qspi): Unevaluated properties are not allowed ('iommus' was unexpected)
from schema $id: http://devicetree.org/schemas/spi/nvidia,tegra210-quad.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dtb: spi@3270000 (nvidia,tegra234-qspi): Unevaluated properties are not allowed ('iommus' was unexpected)
from schema $id: http://devicetree.org/schemas/spi/nvidia,tegra210-quad.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dtb: spi@3270000 (nvidia,tegra234-qspi): Unevaluated properties are not allowed ('iommus' was unexpected)
from schema $id: http://devicetree.org/schemas/spi/nvidia,tegra210-quad.yaml#
next prev parent reply other threads:[~2025-04-16 12:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 11:06 [PATCH v3 0/6] Configure Clocks, Add Internal DMA support Vishwaroop A
2025-04-16 11:06 ` [PATCH v3 1/6] spi: tegra210-quad: Fix X1_X2_X4 encoding and support x4 transfers Vishwaroop A
2025-04-16 11:06 ` [PATCH v3 2/6] spi: tegra210-quad: remove redundant error handling code Vishwaroop A
2025-04-16 11:06 ` [PATCH v3 3/6] spi: tegra210-quad: modify chip select (CS) deactivation Vishwaroop A
2025-04-16 11:06 ` [PATCH v3 4/6] arm64: tegra: Configure QSPI clocks and add DMA Vishwaroop A
2025-04-16 14:11 ` Jon Hunter
2025-04-16 11:06 ` [PATCH v3 5/6] spi: tegra210-quad: Update dummy sequence configuration Vishwaroop A
2025-04-16 11:06 ` [PATCH v3 6/6] spi: tegra210-quad: Add support for internal DMA Vishwaroop A
2025-04-16 11:57 ` Mukesh Kumar Savaliya
2025-04-16 12:23 ` Mark Brown
2025-04-16 14:08 ` Jon Hunter
2025-04-24 13:29 ` Mark Brown
2025-04-16 12:43 ` Rob Herring (Arm) [this message]
2025-04-25 23:00 ` (subset) [PATCH v3 0/6] Configure Clocks, Add Internal DMA support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174480737097.2514153.5351260600015584210.robh@kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=skomatineni@nvidia.com \
--cc=smangipudi@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=va@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox