From: Jon Hunter <jonathanh@nvidia.com>
To: Aaron Kling <webgeek1234@gmail.com>
Cc: Thierry Reding <thierry.reding@kernel.org>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] soc/tegra: fuse: speedo-tegra210: Support revision B01
Date: Wed, 22 Jul 2026 13:44:16 +0100 [thread overview]
Message-ID: <1a09d973-df0f-4e49-81dc-2c12c795d2c6@nvidia.com> (raw)
In-Reply-To: <CALHNRZ_0++igjSQBRo-LVW_bvyu98x_4DXjxRSq0kCNxMaqYKw@mail.gmail.com>
On 21/07/2026 18:31, Aaron Kling wrote:
> On Tue, Jul 21, 2026 at 4:46 AM Jon Hunter <jonathanh@nvidia.com> wrote:
>>
>>
>> On 18/07/2026 00:19, Aaron Kling via B4 Relay wrote:
>>> From: Aaron Kling <webgeek1234@gmail.com>
>>>
>>> Tegra210B01 has a separate set of skus and speedo tables
>>>
>>> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
>>> ---
>>> drivers/soc/tegra/fuse/speedo-tegra210.c | 22 ++++++++++++++++++++--
>>> 1 file changed, 20 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/soc/tegra/fuse/speedo-tegra210.c b/drivers/soc/tegra/fuse/speedo-tegra210.c
>>> index 06c2bcbee5734..699751f4bd0c0 100644
>>> --- a/drivers/soc/tegra/fuse/speedo-tegra210.c
>>> +++ b/drivers/soc/tegra/fuse/speedo-tegra210.c
>>> @@ -65,7 +65,25 @@ static void __init rev_sku_to_speedo_ids(struct tegra_sku_info *sku_info,
>>> sku_info->gpu_speedo_id = 0;
>>> *threshold = THRESHOLD_INDEX_0;
>>>
>>> - if (sku_info->revision >= TEGRA_REVISION_A02) {
>>> + if (sku_info->revision >= TEGRA_REVISION_B01) {
>>> + sku_info->gpu_speedo_id = 1;
>>> +
>>> + switch (sku) {
>>> + case 0x00: /* Engineering SKU */
>>> + case 0x01: /* Engineering SKU */
>>> + case 0x83:
>>> + break;
>>> +
>>> + case 0x87:
>>> + sku_info->cpu_speedo_id = 3;
>>> + break;
>>> +
>>> + default:
>>> + pr_err("Tegra210B01: unknown SKU %#04x\n", sku);
>>> + /* Using the default for the error case */
>>> + break;
>>> + }
>>> + } else if (sku_info->revision >= TEGRA_REVISION_A02) {
>>> switch (sku) {
>>> case 0x00: /* Engineering SKU */
>>> case 0x01: /* Engineering SKU */
>>> @@ -154,7 +172,7 @@ void __init tegra210_init_speedo_data(struct tegra_sku_info *sku_info)
>>> speedo_revision = get_speedo_revision();
>>> pr_info("Speedo Revision %u\n", speedo_revision);
>>>
>>> - if (speedo_revision >= 3) {
>>> + if (sku_info->revision == TEGRA_REVISION_B01 || speedo_revision >= 3) {
>>> sku_info->cpu_speedo_value = cpu_speedo[0];
>>> sku_info->gpu_speedo_value = cpu_speedo[2];
>>> sku_info->soc_speedo_value = soc_speedo[0];
>>>
>>
>> I am guessing that this is derived/ported from some kernel that NVIDIA
>> has released in the past. It would be nice to include a reference to
>> whatever change was used to create this.
>
> It is loosely based on [0], but restructured to not change nearly as
> many lines. How would you want this referenced? Something like a
> 'based on downstream 5.10' blurb in the commit message or a direct
> reference to the commit somehow?
Commit d93f8399053dcf117ff56a3029ff08c0e36f4b75 uses ...
Based-on:
https://lore.kernel.org/r/7703024f-8882-9eec-a122-599871728a89@gmail.com
Based-on-patch-by: Heiner Kallweit <hkallweit1@gmail.com>
So this would be fine.
Jon
--
nvpublic
next prev parent reply other threads:[~2026-07-22 12:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 23:19 [PATCH 0/2] soc/tegra: fuse: Support Tegra210B01 Speedos Aaron Kling via B4 Relay
2026-07-17 23:19 ` [PATCH 1/2] soc/tegra: fuse: Support revision B01 Aaron Kling via B4 Relay
2026-07-21 7:37 ` Mikko Perttunen
2026-07-17 23:19 ` [PATCH 2/2] soc/tegra: fuse: speedo-tegra210: " Aaron Kling via B4 Relay
2026-07-21 7:43 ` Mikko Perttunen
2026-07-21 9:46 ` Jon Hunter
2026-07-21 17:31 ` Aaron Kling
2026-07-22 12:44 ` Jon Hunter [this message]
2026-07-23 3:11 ` Aaron Kling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a09d973-df0f-4e49-81dc-2c12c795d2c6@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@kernel.org \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox