From: Mikko Perttunen <mperttunen@nvidia.com>
To: Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
webgeek1234@gmail.com
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
Aaron Kling <webgeek1234@gmail.com>
Subject: Re: [PATCH 1/2] soc/tegra: fuse: Support revision B01
Date: Tue, 21 Jul 2026 16:37:34 +0900 [thread overview]
Message-ID: <NvaHgTOhRNaBSnS5yK1uig@nvidia.com> (raw)
In-Reply-To: <20260717-t210b01-speedo-v1-1-f04a8bd4d997@gmail.com>
On Saturday, July 18, 2026 8:19 AM Aaron Kling via B4 Relay wrote:
> From: Aaron Kling <webgeek1234@gmail.com>
>
> This is used by Tegra210B01
Please describe the change in full in the commit message, don't continue
the paragraph from the subject.
>
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
> drivers/soc/tegra/fuse/fuse-tegra.c | 1 +
> drivers/soc/tegra/fuse/tegra-apbmisc.c | 45 +++++++++++++++++++---------------
> include/soc/tegra/fuse.h | 1 +
> 3 files changed, 27 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c
> index 78b054d43a422..a37642dc92c61 100644
> --- a/drivers/soc/tegra/fuse/fuse-tegra.c
> +++ b/drivers/soc/tegra/fuse/fuse-tegra.c
> @@ -34,6 +34,7 @@ static const char *tegra_revision_name[TEGRA_REVISION_MAX] = {
> [TEGRA_REVISION_A03] = "A03",
> [TEGRA_REVISION_A03p] = "A03 prime",
> [TEGRA_REVISION_A04] = "A04",
> + [TEGRA_REVISION_B01] = "B01",
> };
>
> static const char *tegra_platform_name[TEGRA_PLATFORM_MAX] = {
> diff --git a/drivers/soc/tegra/fuse/tegra-apbmisc.c b/drivers/soc/tegra/fuse/tegra-apbmisc.c
> index 6af69ccaa295c..8df3bcd148ba7 100644
> --- a/drivers/soc/tegra/fuse/tegra-apbmisc.c
> +++ b/drivers/soc/tegra/fuse/tegra-apbmisc.c
> @@ -167,30 +167,35 @@ static const struct of_device_id apbmisc_match[] __initconst = {
>
> void __init tegra_init_revision(void)
> {
> - u8 chip_id, minor_rev;
> + u8 chip_id, major_rev, minor_rev;
>
> chip_id = tegra_get_chip_id();
> + major_rev = tegra_get_major_rev();
> minor_rev = tegra_get_minor_rev();
>
> - switch (minor_rev) {
> - case 1:
> - tegra_sku_info.revision = TEGRA_REVISION_A01;
> - break;
> - case 2:
> - tegra_sku_info.revision = TEGRA_REVISION_A02;
> - break;
> - case 3:
> - if (chip_id == TEGRA20 && (tegra_fuse_read_spare(18) ||
> - tegra_fuse_read_spare(19)))
> - tegra_sku_info.revision = TEGRA_REVISION_A03p;
> - else
> - tegra_sku_info.revision = TEGRA_REVISION_A03;
> - break;
> - case 4:
> - tegra_sku_info.revision = TEGRA_REVISION_A04;
> - break;
> - default:
> - tegra_sku_info.revision = TEGRA_REVISION_UNKNOWN;
> + if (major_rev > 1) {
> + tegra_sku_info.revision = TEGRA_REVISION_B01;
To match the A revisions, I think better to check minor_rev as well and
set to UNKNOWN if it's not as expected.
Thank you!
Mikko
> + } else {
> + switch (minor_rev) {
> + case 1:
> + tegra_sku_info.revision = TEGRA_REVISION_A01;
> + break;
> + case 2:
> + tegra_sku_info.revision = TEGRA_REVISION_A02;
> + break;
> + case 3:
> + if (chip_id == TEGRA20 && (tegra_fuse_read_spare(18) ||
> + tegra_fuse_read_spare(19)))
> + tegra_sku_info.revision = TEGRA_REVISION_A03p;
> + else
> + tegra_sku_info.revision = TEGRA_REVISION_A03;
> + break;
> + case 4:
> + tegra_sku_info.revision = TEGRA_REVISION_A04;
> + break;
> + default:
> + tegra_sku_info.revision = TEGRA_REVISION_UNKNOWN;
> + }
> }
>
> tegra_sku_info.sku_id = tegra_fuse_read_early(FUSE_SKU_INFO);
> diff --git a/include/soc/tegra/fuse.h b/include/soc/tegra/fuse.h
> index 8f421b9f7585c..30db79f7f17fd 100644
> --- a/include/soc/tegra/fuse.h
> +++ b/include/soc/tegra/fuse.h
> @@ -33,6 +33,7 @@ enum tegra_revision {
> TEGRA_REVISION_A03,
> TEGRA_REVISION_A03p,
> TEGRA_REVISION_A04,
> + TEGRA_REVISION_B01,
> TEGRA_REVISION_MAX,
> };
>
>
> --
> 2.54.0
>
>
>
next prev parent reply other threads:[~2026-07-21 7:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 23:19 [PATCH 0/2] soc/tegra: fuse: Support Tegra210B01 Speedos Aaron Kling via B4 Relay
2026-07-17 23:19 ` [PATCH 1/2] soc/tegra: fuse: Support revision B01 Aaron Kling via B4 Relay
2026-07-21 7:37 ` Mikko Perttunen [this message]
2026-07-17 23:19 ` [PATCH 2/2] soc/tegra: fuse: speedo-tegra210: " Aaron Kling via B4 Relay
2026-07-21 7:43 ` Mikko Perttunen
2026-07-21 9:46 ` Jon Hunter
2026-07-21 17:31 ` Aaron Kling
2026-07-22 12:44 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NvaHgTOhRNaBSnS5yK1uig@nvidia.com \
--to=mperttunen@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@kernel.org \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox