Linux Tegra architecture development
 help / color / mirror / Atom feed
* [PATCH 0/2] soc/tegra: fuse: Support Tegra210B01 Speedos
@ 2026-07-17 23:19 Aaron Kling via B4 Relay
  2026-07-17 23:19 ` [PATCH 1/2] soc/tegra: fuse: Support revision B01 Aaron Kling via B4 Relay
  2026-07-17 23:19 ` [PATCH 2/2] soc/tegra: fuse: speedo-tegra210: " Aaron Kling via B4 Relay
  0 siblings, 2 replies; 8+ messages in thread
From: Aaron Kling via B4 Relay @ 2026-07-17 23:19 UTC (permalink / raw)
  To: Thierry Reding, Jonathan Hunter; +Cc: linux-tegra, linux-kernel, Aaron Kling

This series adds support for the b01 fuse revision, then adds speedo
support for known Tegra210B01 sku's.

Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
Aaron Kling (2):
      soc/tegra: fuse: Support revision B01
      soc/tegra: fuse: speedo-tegra210: Support revision B01

 drivers/soc/tegra/fuse/fuse-tegra.c      |  1 +
 drivers/soc/tegra/fuse/speedo-tegra210.c | 22 ++++++++++++++--
 drivers/soc/tegra/fuse/tegra-apbmisc.c   | 45 ++++++++++++++++++--------------
 include/soc/tegra/fuse.h                 |  1 +
 4 files changed, 47 insertions(+), 22 deletions(-)
---
base-commit: 1a1757b76427f6201bfe0bf1bea9f7574f332a93
change-id: 20260714-t210b01-speedo-07f8cd3b3aa3

Best regards,
-- 
Aaron Kling <webgeek1234@gmail.com>



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/2] soc/tegra: fuse: Support revision B01
  2026-07-17 23:19 [PATCH 0/2] soc/tegra: fuse: Support Tegra210B01 Speedos Aaron Kling via B4 Relay
@ 2026-07-17 23:19 ` Aaron Kling via B4 Relay
  2026-07-21  7:37   ` Mikko Perttunen
  2026-07-17 23:19 ` [PATCH 2/2] soc/tegra: fuse: speedo-tegra210: " Aaron Kling via B4 Relay
  1 sibling, 1 reply; 8+ messages in thread
From: Aaron Kling via B4 Relay @ 2026-07-17 23:19 UTC (permalink / raw)
  To: Thierry Reding, Jonathan Hunter; +Cc: linux-tegra, linux-kernel, Aaron Kling

From: Aaron Kling <webgeek1234@gmail.com>

This is used by Tegra210B01

Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
 drivers/soc/tegra/fuse/fuse-tegra.c    |  1 +
 drivers/soc/tegra/fuse/tegra-apbmisc.c | 45 +++++++++++++++++++---------------
 include/soc/tegra/fuse.h               |  1 +
 3 files changed, 27 insertions(+), 20 deletions(-)

diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c
index 78b054d43a422..a37642dc92c61 100644
--- a/drivers/soc/tegra/fuse/fuse-tegra.c
+++ b/drivers/soc/tegra/fuse/fuse-tegra.c
@@ -34,6 +34,7 @@ static const char *tegra_revision_name[TEGRA_REVISION_MAX] = {
 	[TEGRA_REVISION_A03]     = "A03",
 	[TEGRA_REVISION_A03p]    = "A03 prime",
 	[TEGRA_REVISION_A04]     = "A04",
+	[TEGRA_REVISION_B01]     = "B01",
 };
 
 static const char *tegra_platform_name[TEGRA_PLATFORM_MAX] = {
diff --git a/drivers/soc/tegra/fuse/tegra-apbmisc.c b/drivers/soc/tegra/fuse/tegra-apbmisc.c
index 6af69ccaa295c..8df3bcd148ba7 100644
--- a/drivers/soc/tegra/fuse/tegra-apbmisc.c
+++ b/drivers/soc/tegra/fuse/tegra-apbmisc.c
@@ -167,30 +167,35 @@ static const struct of_device_id apbmisc_match[] __initconst = {
 
 void __init tegra_init_revision(void)
 {
-	u8 chip_id, minor_rev;
+	u8 chip_id, major_rev, minor_rev;
 
 	chip_id = tegra_get_chip_id();
+	major_rev = tegra_get_major_rev();
 	minor_rev = tegra_get_minor_rev();
 
-	switch (minor_rev) {
-	case 1:
-		tegra_sku_info.revision = TEGRA_REVISION_A01;
-		break;
-	case 2:
-		tegra_sku_info.revision = TEGRA_REVISION_A02;
-		break;
-	case 3:
-		if (chip_id == TEGRA20 && (tegra_fuse_read_spare(18) ||
-					   tegra_fuse_read_spare(19)))
-			tegra_sku_info.revision = TEGRA_REVISION_A03p;
-		else
-			tegra_sku_info.revision = TEGRA_REVISION_A03;
-		break;
-	case 4:
-		tegra_sku_info.revision = TEGRA_REVISION_A04;
-		break;
-	default:
-		tegra_sku_info.revision = TEGRA_REVISION_UNKNOWN;
+	if (major_rev > 1) {
+		tegra_sku_info.revision = TEGRA_REVISION_B01;
+	} else {
+		switch (minor_rev) {
+		case 1:
+			tegra_sku_info.revision = TEGRA_REVISION_A01;
+			break;
+		case 2:
+			tegra_sku_info.revision = TEGRA_REVISION_A02;
+			break;
+		case 3:
+			if (chip_id == TEGRA20 && (tegra_fuse_read_spare(18) ||
+						   tegra_fuse_read_spare(19)))
+				tegra_sku_info.revision = TEGRA_REVISION_A03p;
+			else
+				tegra_sku_info.revision = TEGRA_REVISION_A03;
+			break;
+		case 4:
+			tegra_sku_info.revision = TEGRA_REVISION_A04;
+			break;
+		default:
+			tegra_sku_info.revision = TEGRA_REVISION_UNKNOWN;
+		}
 	}
 
 	tegra_sku_info.sku_id = tegra_fuse_read_early(FUSE_SKU_INFO);
diff --git a/include/soc/tegra/fuse.h b/include/soc/tegra/fuse.h
index 8f421b9f7585c..30db79f7f17fd 100644
--- a/include/soc/tegra/fuse.h
+++ b/include/soc/tegra/fuse.h
@@ -33,6 +33,7 @@ enum tegra_revision {
 	TEGRA_REVISION_A03,
 	TEGRA_REVISION_A03p,
 	TEGRA_REVISION_A04,
+	TEGRA_REVISION_B01,
 	TEGRA_REVISION_MAX,
 };
 

-- 
2.54.0



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/2] soc/tegra: fuse: speedo-tegra210: Support revision B01
  2026-07-17 23:19 [PATCH 0/2] soc/tegra: fuse: Support Tegra210B01 Speedos Aaron Kling via B4 Relay
  2026-07-17 23:19 ` [PATCH 1/2] soc/tegra: fuse: Support revision B01 Aaron Kling via B4 Relay
@ 2026-07-17 23:19 ` Aaron Kling via B4 Relay
  2026-07-21  7:43   ` Mikko Perttunen
  2026-07-21  9:46   ` Jon Hunter
  1 sibling, 2 replies; 8+ messages in thread
From: Aaron Kling via B4 Relay @ 2026-07-17 23:19 UTC (permalink / raw)
  To: Thierry Reding, Jonathan Hunter; +Cc: linux-tegra, linux-kernel, Aaron Kling

From: Aaron Kling <webgeek1234@gmail.com>

Tegra210B01 has a separate set of skus and speedo tables

Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
 drivers/soc/tegra/fuse/speedo-tegra210.c | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/tegra/fuse/speedo-tegra210.c b/drivers/soc/tegra/fuse/speedo-tegra210.c
index 06c2bcbee5734..699751f4bd0c0 100644
--- a/drivers/soc/tegra/fuse/speedo-tegra210.c
+++ b/drivers/soc/tegra/fuse/speedo-tegra210.c
@@ -65,7 +65,25 @@ static void __init rev_sku_to_speedo_ids(struct tegra_sku_info *sku_info,
 	sku_info->gpu_speedo_id = 0;
 	*threshold = THRESHOLD_INDEX_0;
 
-	if (sku_info->revision >= TEGRA_REVISION_A02) {
+	if (sku_info->revision >= TEGRA_REVISION_B01) {
+		sku_info->gpu_speedo_id = 1;
+
+		switch (sku) {
+		case 0x00: /* Engineering SKU */
+		case 0x01: /* Engineering SKU */
+		case 0x83:
+			break;
+
+		case 0x87:
+			sku_info->cpu_speedo_id = 3;
+			break;
+
+		default:
+			pr_err("Tegra210B01: unknown SKU %#04x\n", sku);
+			/* Using the default for the error case */
+			break;
+		}
+	} else if (sku_info->revision >= TEGRA_REVISION_A02) {
 		switch (sku) {
 		case 0x00: /* Engineering SKU */
 		case 0x01: /* Engineering SKU */
@@ -154,7 +172,7 @@ void __init tegra210_init_speedo_data(struct tegra_sku_info *sku_info)
 	speedo_revision = get_speedo_revision();
 	pr_info("Speedo Revision %u\n", speedo_revision);
 
-	if (speedo_revision >= 3) {
+	if (sku_info->revision == TEGRA_REVISION_B01 || speedo_revision >= 3) {
 		sku_info->cpu_speedo_value = cpu_speedo[0];
 		sku_info->gpu_speedo_value = cpu_speedo[2];
 		sku_info->soc_speedo_value = soc_speedo[0];

-- 
2.54.0



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] soc/tegra: fuse: Support revision B01
  2026-07-17 23:19 ` [PATCH 1/2] soc/tegra: fuse: Support revision B01 Aaron Kling via B4 Relay
@ 2026-07-21  7:37   ` Mikko Perttunen
  0 siblings, 0 replies; 8+ messages in thread
From: Mikko Perttunen @ 2026-07-21  7:37 UTC (permalink / raw)
  To: Thierry Reding, Jonathan Hunter, webgeek1234
  Cc: linux-tegra, linux-kernel, Aaron Kling

On Saturday, July 18, 2026 8:19 AM Aaron Kling via B4 Relay wrote:
> From: Aaron Kling <webgeek1234@gmail.com>
> 
> This is used by Tegra210B01

Please describe the change in full in the commit message, don't continue 
the paragraph from the subject.

> 
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
>  drivers/soc/tegra/fuse/fuse-tegra.c    |  1 +
>  drivers/soc/tegra/fuse/tegra-apbmisc.c | 45 +++++++++++++++++++---------------
>  include/soc/tegra/fuse.h               |  1 +
>  3 files changed, 27 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c
> index 78b054d43a422..a37642dc92c61 100644
> --- a/drivers/soc/tegra/fuse/fuse-tegra.c
> +++ b/drivers/soc/tegra/fuse/fuse-tegra.c
> @@ -34,6 +34,7 @@ static const char *tegra_revision_name[TEGRA_REVISION_MAX] = {
>  	[TEGRA_REVISION_A03]     = "A03",
>  	[TEGRA_REVISION_A03p]    = "A03 prime",
>  	[TEGRA_REVISION_A04]     = "A04",
> +	[TEGRA_REVISION_B01]     = "B01",
>  };
>  
>  static const char *tegra_platform_name[TEGRA_PLATFORM_MAX] = {
> diff --git a/drivers/soc/tegra/fuse/tegra-apbmisc.c b/drivers/soc/tegra/fuse/tegra-apbmisc.c
> index 6af69ccaa295c..8df3bcd148ba7 100644
> --- a/drivers/soc/tegra/fuse/tegra-apbmisc.c
> +++ b/drivers/soc/tegra/fuse/tegra-apbmisc.c
> @@ -167,30 +167,35 @@ static const struct of_device_id apbmisc_match[] __initconst = {
>  
>  void __init tegra_init_revision(void)
>  {
> -	u8 chip_id, minor_rev;
> +	u8 chip_id, major_rev, minor_rev;
>  
>  	chip_id = tegra_get_chip_id();
> +	major_rev = tegra_get_major_rev();
>  	minor_rev = tegra_get_minor_rev();
>  
> -	switch (minor_rev) {
> -	case 1:
> -		tegra_sku_info.revision = TEGRA_REVISION_A01;
> -		break;
> -	case 2:
> -		tegra_sku_info.revision = TEGRA_REVISION_A02;
> -		break;
> -	case 3:
> -		if (chip_id == TEGRA20 && (tegra_fuse_read_spare(18) ||
> -					   tegra_fuse_read_spare(19)))
> -			tegra_sku_info.revision = TEGRA_REVISION_A03p;
> -		else
> -			tegra_sku_info.revision = TEGRA_REVISION_A03;
> -		break;
> -	case 4:
> -		tegra_sku_info.revision = TEGRA_REVISION_A04;
> -		break;
> -	default:
> -		tegra_sku_info.revision = TEGRA_REVISION_UNKNOWN;
> +	if (major_rev > 1) {
> +		tegra_sku_info.revision = TEGRA_REVISION_B01;

To match the A revisions, I think better to check minor_rev as well and 
set to UNKNOWN if it's not as expected.

Thank you!
Mikko

> +	} else {
> +		switch (minor_rev) {
> +		case 1:
> +			tegra_sku_info.revision = TEGRA_REVISION_A01;
> +			break;
> +		case 2:
> +			tegra_sku_info.revision = TEGRA_REVISION_A02;
> +			break;
> +		case 3:
> +			if (chip_id == TEGRA20 && (tegra_fuse_read_spare(18) ||
> +						   tegra_fuse_read_spare(19)))
> +				tegra_sku_info.revision = TEGRA_REVISION_A03p;
> +			else
> +				tegra_sku_info.revision = TEGRA_REVISION_A03;
> +			break;
> +		case 4:
> +			tegra_sku_info.revision = TEGRA_REVISION_A04;
> +			break;
> +		default:
> +			tegra_sku_info.revision = TEGRA_REVISION_UNKNOWN;
> +		}
>  	}
>  
>  	tegra_sku_info.sku_id = tegra_fuse_read_early(FUSE_SKU_INFO);
> diff --git a/include/soc/tegra/fuse.h b/include/soc/tegra/fuse.h
> index 8f421b9f7585c..30db79f7f17fd 100644
> --- a/include/soc/tegra/fuse.h
> +++ b/include/soc/tegra/fuse.h
> @@ -33,6 +33,7 @@ enum tegra_revision {
>  	TEGRA_REVISION_A03,
>  	TEGRA_REVISION_A03p,
>  	TEGRA_REVISION_A04,
> +	TEGRA_REVISION_B01,
>  	TEGRA_REVISION_MAX,
>  };
>  
> 
> -- 
> 2.54.0
> 
> 
> 





^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] soc/tegra: fuse: speedo-tegra210: Support revision B01
  2026-07-17 23:19 ` [PATCH 2/2] soc/tegra: fuse: speedo-tegra210: " Aaron Kling via B4 Relay
@ 2026-07-21  7:43   ` Mikko Perttunen
  2026-07-21  9:46   ` Jon Hunter
  1 sibling, 0 replies; 8+ messages in thread
From: Mikko Perttunen @ 2026-07-21  7:43 UTC (permalink / raw)
  To: Thierry Reding, Jonathan Hunter, webgeek1234
  Cc: linux-tegra, linux-kernel, Aaron Kling

On Saturday, July 18, 2026 8:19 AM Aaron Kling via B4 Relay wrote:
> From: Aaron Kling <webgeek1234@gmail.com>
> 
> Tegra210B01 has a separate set of skus and speedo tables
> 
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
>  drivers/soc/tegra/fuse/speedo-tegra210.c | 22 ++++++++++++++++++++--
>  1 file changed, 20 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/tegra/fuse/speedo-tegra210.c b/drivers/soc/tegra/fuse/speedo-tegra210.c
> index 06c2bcbee5734..699751f4bd0c0 100644
> --- a/drivers/soc/tegra/fuse/speedo-tegra210.c
> +++ b/drivers/soc/tegra/fuse/speedo-tegra210.c
> @@ -65,7 +65,25 @@ static void __init rev_sku_to_speedo_ids(struct tegra_sku_info *sku_info,
>  	sku_info->gpu_speedo_id = 0;
>  	*threshold = THRESHOLD_INDEX_0;
>  
> -	if (sku_info->revision >= TEGRA_REVISION_A02) {
> +	if (sku_info->revision >= TEGRA_REVISION_B01) {
> +		sku_info->gpu_speedo_id = 1;
> +
> +		switch (sku) {
> +		case 0x00: /* Engineering SKU */
> +		case 0x01: /* Engineering SKU */
> +		case 0x83:
> +			break;
> +
> +		case 0x87:
> +			sku_info->cpu_speedo_id = 3;
> +			break;
> +
> +		default:
> +			pr_err("Tegra210B01: unknown SKU %#04x\n", sku);
> +			/* Using the default for the error case */
> +			break;
> +		}
> +	} else if (sku_info->revision >= TEGRA_REVISION_A02) {
>  		switch (sku) {
>  		case 0x00: /* Engineering SKU */
>  		case 0x01: /* Engineering SKU */
> @@ -154,7 +172,7 @@ void __init tegra210_init_speedo_data(struct tegra_sku_info *sku_info)
>  	speedo_revision = get_speedo_revision();
>  	pr_info("Speedo Revision %u\n", speedo_revision);
>  
> -	if (speedo_revision >= 3) {
> +	if (sku_info->revision == TEGRA_REVISION_B01 || speedo_revision >= 3) {
>  		sku_info->cpu_speedo_value = cpu_speedo[0];
>  		sku_info->gpu_speedo_value = cpu_speedo[2];
>  		sku_info->soc_speedo_value = soc_speedo[0];
> 
> -- 
> 2.54.0
> 
> 
> 

Thanks!

Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>




^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] soc/tegra: fuse: speedo-tegra210: Support revision B01
  2026-07-17 23:19 ` [PATCH 2/2] soc/tegra: fuse: speedo-tegra210: " Aaron Kling via B4 Relay
  2026-07-21  7:43   ` Mikko Perttunen
@ 2026-07-21  9:46   ` Jon Hunter
  2026-07-21 17:31     ` Aaron Kling
  1 sibling, 1 reply; 8+ messages in thread
From: Jon Hunter @ 2026-07-21  9:46 UTC (permalink / raw)
  To: webgeek1234, Thierry Reding; +Cc: linux-tegra, linux-kernel


On 18/07/2026 00:19, Aaron Kling via B4 Relay wrote:
> From: Aaron Kling <webgeek1234@gmail.com>
> 
> Tegra210B01 has a separate set of skus and speedo tables
> 
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
>   drivers/soc/tegra/fuse/speedo-tegra210.c | 22 ++++++++++++++++++++--
>   1 file changed, 20 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/tegra/fuse/speedo-tegra210.c b/drivers/soc/tegra/fuse/speedo-tegra210.c
> index 06c2bcbee5734..699751f4bd0c0 100644
> --- a/drivers/soc/tegra/fuse/speedo-tegra210.c
> +++ b/drivers/soc/tegra/fuse/speedo-tegra210.c
> @@ -65,7 +65,25 @@ static void __init rev_sku_to_speedo_ids(struct tegra_sku_info *sku_info,
>   	sku_info->gpu_speedo_id = 0;
>   	*threshold = THRESHOLD_INDEX_0;
>   
> -	if (sku_info->revision >= TEGRA_REVISION_A02) {
> +	if (sku_info->revision >= TEGRA_REVISION_B01) {
> +		sku_info->gpu_speedo_id = 1;
> +
> +		switch (sku) {
> +		case 0x00: /* Engineering SKU */
> +		case 0x01: /* Engineering SKU */
> +		case 0x83:
> +			break;
> +
> +		case 0x87:
> +			sku_info->cpu_speedo_id = 3;
> +			break;
> +
> +		default:
> +			pr_err("Tegra210B01: unknown SKU %#04x\n", sku);
> +			/* Using the default for the error case */
> +			break;
> +		}
> +	} else if (sku_info->revision >= TEGRA_REVISION_A02) {
>   		switch (sku) {
>   		case 0x00: /* Engineering SKU */
>   		case 0x01: /* Engineering SKU */
> @@ -154,7 +172,7 @@ void __init tegra210_init_speedo_data(struct tegra_sku_info *sku_info)
>   	speedo_revision = get_speedo_revision();
>   	pr_info("Speedo Revision %u\n", speedo_revision);
>   
> -	if (speedo_revision >= 3) {
> +	if (sku_info->revision == TEGRA_REVISION_B01 || speedo_revision >= 3) {
>   		sku_info->cpu_speedo_value = cpu_speedo[0];
>   		sku_info->gpu_speedo_value = cpu_speedo[2];
>   		sku_info->soc_speedo_value = soc_speedo[0];
> 

I am guessing that this is derived/ported from some kernel that NVIDIA 
has released in the past. It would be nice to include a reference to 
whatever change was used to create this.

Jon

-- 
nvpublic


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] soc/tegra: fuse: speedo-tegra210: Support revision B01
  2026-07-21  9:46   ` Jon Hunter
@ 2026-07-21 17:31     ` Aaron Kling
  2026-07-22 12:44       ` Jon Hunter
  0 siblings, 1 reply; 8+ messages in thread
From: Aaron Kling @ 2026-07-21 17:31 UTC (permalink / raw)
  To: Jon Hunter; +Cc: Thierry Reding, linux-tegra, linux-kernel

On Tue, Jul 21, 2026 at 4:46 AM Jon Hunter <jonathanh@nvidia.com> wrote:
>
>
> On 18/07/2026 00:19, Aaron Kling via B4 Relay wrote:
> > From: Aaron Kling <webgeek1234@gmail.com>
> >
> > Tegra210B01 has a separate set of skus and speedo tables
> >
> > Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> > ---
> >   drivers/soc/tegra/fuse/speedo-tegra210.c | 22 ++++++++++++++++++++--
> >   1 file changed, 20 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/soc/tegra/fuse/speedo-tegra210.c b/drivers/soc/tegra/fuse/speedo-tegra210.c
> > index 06c2bcbee5734..699751f4bd0c0 100644
> > --- a/drivers/soc/tegra/fuse/speedo-tegra210.c
> > +++ b/drivers/soc/tegra/fuse/speedo-tegra210.c
> > @@ -65,7 +65,25 @@ static void __init rev_sku_to_speedo_ids(struct tegra_sku_info *sku_info,
> >       sku_info->gpu_speedo_id = 0;
> >       *threshold = THRESHOLD_INDEX_0;
> >
> > -     if (sku_info->revision >= TEGRA_REVISION_A02) {
> > +     if (sku_info->revision >= TEGRA_REVISION_B01) {
> > +             sku_info->gpu_speedo_id = 1;
> > +
> > +             switch (sku) {
> > +             case 0x00: /* Engineering SKU */
> > +             case 0x01: /* Engineering SKU */
> > +             case 0x83:
> > +                     break;
> > +
> > +             case 0x87:
> > +                     sku_info->cpu_speedo_id = 3;
> > +                     break;
> > +
> > +             default:
> > +                     pr_err("Tegra210B01: unknown SKU %#04x\n", sku);
> > +                     /* Using the default for the error case */
> > +                     break;
> > +             }
> > +     } else if (sku_info->revision >= TEGRA_REVISION_A02) {
> >               switch (sku) {
> >               case 0x00: /* Engineering SKU */
> >               case 0x01: /* Engineering SKU */
> > @@ -154,7 +172,7 @@ void __init tegra210_init_speedo_data(struct tegra_sku_info *sku_info)
> >       speedo_revision = get_speedo_revision();
> >       pr_info("Speedo Revision %u\n", speedo_revision);
> >
> > -     if (speedo_revision >= 3) {
> > +     if (sku_info->revision == TEGRA_REVISION_B01 || speedo_revision >= 3) {
> >               sku_info->cpu_speedo_value = cpu_speedo[0];
> >               sku_info->gpu_speedo_value = cpu_speedo[2];
> >               sku_info->soc_speedo_value = soc_speedo[0];
> >
>
> I am guessing that this is derived/ported from some kernel that NVIDIA
> has released in the past. It would be nice to include a reference to
> whatever change was used to create this.

It is loosely based on [0], but restructured to not change nearly as
many lines. How would you want this referenced? Something like a
'based on downstream 5.10' blurb in the commit message or a direct
reference to the commit somehow?

Aaron

[0] https://gitlab.com/nvidia/nv-tegra/linux-5.10/-/commit/8555ef4988d3b39d91791794825c354b3c9377ba

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] soc/tegra: fuse: speedo-tegra210: Support revision B01
  2026-07-21 17:31     ` Aaron Kling
@ 2026-07-22 12:44       ` Jon Hunter
  0 siblings, 0 replies; 8+ messages in thread
From: Jon Hunter @ 2026-07-22 12:44 UTC (permalink / raw)
  To: Aaron Kling; +Cc: Thierry Reding, linux-tegra, linux-kernel


On 21/07/2026 18:31, Aaron Kling wrote:
> On Tue, Jul 21, 2026 at 4:46 AM Jon Hunter <jonathanh@nvidia.com> wrote:
>>
>>
>> On 18/07/2026 00:19, Aaron Kling via B4 Relay wrote:
>>> From: Aaron Kling <webgeek1234@gmail.com>
>>>
>>> Tegra210B01 has a separate set of skus and speedo tables
>>>
>>> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
>>> ---
>>>    drivers/soc/tegra/fuse/speedo-tegra210.c | 22 ++++++++++++++++++++--
>>>    1 file changed, 20 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/soc/tegra/fuse/speedo-tegra210.c b/drivers/soc/tegra/fuse/speedo-tegra210.c
>>> index 06c2bcbee5734..699751f4bd0c0 100644
>>> --- a/drivers/soc/tegra/fuse/speedo-tegra210.c
>>> +++ b/drivers/soc/tegra/fuse/speedo-tegra210.c
>>> @@ -65,7 +65,25 @@ static void __init rev_sku_to_speedo_ids(struct tegra_sku_info *sku_info,
>>>        sku_info->gpu_speedo_id = 0;
>>>        *threshold = THRESHOLD_INDEX_0;
>>>
>>> -     if (sku_info->revision >= TEGRA_REVISION_A02) {
>>> +     if (sku_info->revision >= TEGRA_REVISION_B01) {
>>> +             sku_info->gpu_speedo_id = 1;
>>> +
>>> +             switch (sku) {
>>> +             case 0x00: /* Engineering SKU */
>>> +             case 0x01: /* Engineering SKU */
>>> +             case 0x83:
>>> +                     break;
>>> +
>>> +             case 0x87:
>>> +                     sku_info->cpu_speedo_id = 3;
>>> +                     break;
>>> +
>>> +             default:
>>> +                     pr_err("Tegra210B01: unknown SKU %#04x\n", sku);
>>> +                     /* Using the default for the error case */
>>> +                     break;
>>> +             }
>>> +     } else if (sku_info->revision >= TEGRA_REVISION_A02) {
>>>                switch (sku) {
>>>                case 0x00: /* Engineering SKU */
>>>                case 0x01: /* Engineering SKU */
>>> @@ -154,7 +172,7 @@ void __init tegra210_init_speedo_data(struct tegra_sku_info *sku_info)
>>>        speedo_revision = get_speedo_revision();
>>>        pr_info("Speedo Revision %u\n", speedo_revision);
>>>
>>> -     if (speedo_revision >= 3) {
>>> +     if (sku_info->revision == TEGRA_REVISION_B01 || speedo_revision >= 3) {
>>>                sku_info->cpu_speedo_value = cpu_speedo[0];
>>>                sku_info->gpu_speedo_value = cpu_speedo[2];
>>>                sku_info->soc_speedo_value = soc_speedo[0];
>>>
>>
>> I am guessing that this is derived/ported from some kernel that NVIDIA
>> has released in the past. It would be nice to include a reference to
>> whatever change was used to create this.
> 
> It is loosely based on [0], but restructured to not change nearly as
> many lines. How would you want this referenced? Something like a
> 'based on downstream 5.10' blurb in the commit message or a direct
> reference to the commit somehow?

Commit d93f8399053dcf117ff56a3029ff08c0e36f4b75 uses ...

Based-on: 
https://lore.kernel.org/r/7703024f-8882-9eec-a122-599871728a89@gmail.com
Based-on-patch-by: Heiner Kallweit <hkallweit1@gmail.com>

So this would be fine.

Jon

-- 
nvpublic


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-07-22 12:44 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-17 23:19 [PATCH 0/2] soc/tegra: fuse: Support Tegra210B01 Speedos Aaron Kling via B4 Relay
2026-07-17 23:19 ` [PATCH 1/2] soc/tegra: fuse: Support revision B01 Aaron Kling via B4 Relay
2026-07-21  7:37   ` Mikko Perttunen
2026-07-17 23:19 ` [PATCH 2/2] soc/tegra: fuse: speedo-tegra210: " Aaron Kling via B4 Relay
2026-07-21  7:43   ` Mikko Perttunen
2026-07-21  9:46   ` Jon Hunter
2026-07-21 17:31     ` Aaron Kling
2026-07-22 12:44       ` Jon Hunter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox