From: Florian Fainelli <f.fainelli@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>
Cc: Jon Hunter <jonathanh@nvidia.com>,
Bhadram Varka <vbhadram@nvidia.com>,
linux-tegra@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 RESEND] stmmac: tegra: Add MGBE support
Date: Tue, 27 Sep 2022 10:23:23 -0700 [thread overview]
Message-ID: <1b50703c-9de0-3331-0517-2691b7005489@gmail.com> (raw)
In-Reply-To: <20220923114922.864552-1-thierry.reding@gmail.com>
+Russell, Andrew, Vladimir,
On 9/23/22 04:49, Thierry Reding wrote:
> From: Bhadram Varka <vbhadram@nvidia.com>
>
> Add support for the Multi-Gigabit Ethernet (MGBE/XPCS) IP found on
> NVIDIA Tegra234 SoCs.
>
> Signed-off-by: Bhadram Varka <vbhadram@nvidia.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/Kconfig | 6 +
> drivers/net/ethernet/stmicro/stmmac/Makefile | 1 +
> .../net/ethernet/stmicro/stmmac/dwmac-tegra.c | 290 ++++++++++++++++++
You should be modeling this as a proper PCS driver and have a
'pcs-handle' property pointing to it in your Device Tree.
The configuration you are doing here is probably working the first time
you bring-up the network device but I doubt it works across system
suspend/resume states where power to the GMAC and PCS is lost, it also
begs the question of which mediums this was tested with and whether
dynamic switching of speeds and so on is working?
--
Florian
next prev parent reply other threads:[~2022-09-27 17:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 11:49 [PATCH net-next v4 RESEND] stmmac: tegra: Add MGBE support Thierry Reding
2022-09-27 9:29 ` Paolo Abeni
2022-09-27 15:33 ` Thierry Reding
2022-09-27 17:23 ` Florian Fainelli [this message]
2022-10-12 4:56 ` Bhadram Varka
2022-11-18 9:23 ` Jon Hunter
2022-11-18 13:02 ` Vladimir Oltean
2022-11-22 7:05 ` Bhadram Varka
2022-11-22 13:26 ` Vladimir Oltean
2022-11-25 4:14 ` Bhadram Varka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b50703c-9de0-3331-0517-2691b7005489@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jonathanh@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=thierry.reding@gmail.com \
--cc=vbhadram@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox