[PATCH] drm/tegra: Remove unused .mode_set and .mode_set_base CRTC helpers

[PATCH] drm/tegra: Remove unused .mode_set and .mode_set_base CRTC helpers

[Laurent Pinchart]

The two CRTC helper operations are called only for non-atomic mode
setting, by either the drm_crtc_helper_set_config() helper or the
drm_helper_resume_force_mode() helper. As the driver has switched to
atomic mode setting and neither of those helpers is used, the operations
are not used anymore. Remove them.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
---
 drivers/gpu/drm/tegra/dc.c | 2 --
 1 file changed, 2 deletions(-)

Hi Thierry,

I stumbled on this while trying to understand the atomic mode setting code
paths. Could you please test the patch ?

diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
index 3aaa84ae2681..4476d6a35a0f 100644
--- a/drivers/gpu/drm/tegra/dc.c
+++ b/drivers/gpu/drm/tegra/dc.c
@@ -1327,9 +1327,7 @@ static void tegra_crtc_atomic_flush(struct drm_crtc *crtc)
 static const struct drm_crtc_helper_funcs tegra_crtc_helper_funcs = {
 	.disable = tegra_crtc_disable,
 	.mode_fixup = tegra_crtc_mode_fixup,
-	.mode_set = drm_helper_crtc_mode_set,
 	.mode_set_nofb = tegra_crtc_mode_set_nofb,
-	.mode_set_base = drm_helper_crtc_mode_set_base,
 	.prepare = tegra_crtc_prepare,
 	.commit = tegra_crtc_commit,
 	.atomic_check = tegra_crtc_atomic_check,
-- 
Regards,

Laurent Pinchart

Re: [PATCH] drm/tegra: Remove unused .mode_set and .mode_set_base CRTC helpers

[Laurent Pinchart]

Hi Thierry,

Ping ?

On Friday 20 February 2015 13:43:56 Laurent Pinchart wrote:
> The two CRTC helper operations are called only for non-atomic mode
> setting, by either the drm_crtc_helper_set_config() helper or the
> drm_helper_resume_force_mode() helper. As the driver has switched to
> atomic mode setting and neither of those helpers is used, the operations
> are not used anymore. Remove them.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
> ---
>  drivers/gpu/drm/tegra/dc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> Hi Thierry,
> 
> I stumbled on this while trying to understand the atomic mode setting code
> paths. Could you please test the patch ?
> 
> diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
> index 3aaa84ae2681..4476d6a35a0f 100644
> --- a/drivers/gpu/drm/tegra/dc.c
> +++ b/drivers/gpu/drm/tegra/dc.c
> @@ -1327,9 +1327,7 @@ static void tegra_crtc_atomic_flush(struct drm_crtc
> *crtc) static const struct drm_crtc_helper_funcs tegra_crtc_helper_funcs =
> { .disable = tegra_crtc_disable,
>  	.mode_fixup = tegra_crtc_mode_fixup,
> -	.mode_set = drm_helper_crtc_mode_set,
>  	.mode_set_nofb = tegra_crtc_mode_set_nofb,
> -	.mode_set_base = drm_helper_crtc_mode_set_base,
>  	.prepare = tegra_crtc_prepare,
>  	.commit = tegra_crtc_commit,
>  	.atomic_check = tegra_crtc_atomic_check,

-- 
Regards,

Laurent Pinchart

Re: [PATCH] drm/tegra: Remove unused .mode_set and .mode_set_base CRTC helpers

[Thierry Reding]

[-- Attachment #1.1: Type: text/plain, Size: 1866 bytes --]

On Fri, Apr 03, 2015 at 04:53:41PM +0300, Laurent Pinchart wrote:
> Hi Thierry,
> 
> Ping ?

I thought I had already replied to the original post, but apparently I
didn't. I had been carrying that same patch for a while already but had
not sent it to Dave because it didn't seem material for after -rc1. The
patch has gone in for v4.1-rc1 now.

Thanks,
Thierry

> On Friday 20 February 2015 13:43:56 Laurent Pinchart wrote:
> > The two CRTC helper operations are called only for non-atomic mode
> > setting, by either the drm_crtc_helper_set_config() helper or the
> > drm_helper_resume_force_mode() helper. As the driver has switched to
> > atomic mode setting and neither of those helpers is used, the operations
> > are not used anymore. Remove them.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> >  drivers/gpu/drm/tegra/dc.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > Hi Thierry,
> > 
> > I stumbled on this while trying to understand the atomic mode setting code
> > paths. Could you please test the patch ?
> > 
> > diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
> > index 3aaa84ae2681..4476d6a35a0f 100644
> > --- a/drivers/gpu/drm/tegra/dc.c
> > +++ b/drivers/gpu/drm/tegra/dc.c
> > @@ -1327,9 +1327,7 @@ static void tegra_crtc_atomic_flush(struct drm_crtc
> > *crtc) static const struct drm_crtc_helper_funcs tegra_crtc_helper_funcs =
> > { .disable = tegra_crtc_disable,
> >  	.mode_fixup = tegra_crtc_mode_fixup,
> > -	.mode_set = drm_helper_crtc_mode_set,
> >  	.mode_set_nofb = tegra_crtc_mode_set_nofb,
> > -	.mode_set_base = drm_helper_crtc_mode_set_base,
> >  	.prepare = tegra_crtc_prepare,
> >  	.commit = tegra_crtc_commit,
> >  	.atomic_check = tegra_crtc_atomic_check,
> 
> -- 
> Regards,
> 
> Laurent Pinchart
> 

[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel