* [PATCH v5 0/8] Adding support for STMPE811 ADC @ 2018-12-21 13:46 Philippe Schenker 2018-12-21 13:46 ` [PATCH v5 8/8] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules Philippe Schenker 2019-01-16 12:44 ` [GIT PULL] Immutable branch between MFD, IIO and Input due for the v5.1 merge window Lee Jones 0 siblings, 2 replies; 4+ messages in thread From: Philippe Schenker @ 2018-12-21 13:46 UTC (permalink / raw) To: jic23, marcel.ziswiler, stefan Cc: robh, alexandre.torgue, shawnguo, dmitry.torokhov, thierry.reding, digetx, lee.jones, coquelin.stm32, Philippe Schenker, Arnd Bergmann, Arnaud Pouliquen, linux-iio, Mark Brown, Pengutronix Kernel Team, Rob Herring, Geert Uytterhoeven, William Breathitt Gray, linux-stm32, Fabio Estevam, Randy Dunlap, Jonathan Cameron, Freeman Liu, linux-input From: Philippe Schenker <philippe.schenker@toradex.com> Hello everyone, This patchset is adding an ADC driver for STMPE811. The STMPE811 is a Multi-Frontend-Device that supports a touchscreen, ADC, GPIO and a temperature sensor. For Touchscreen and GPIO there are already existing drivers in mainline. This patchset will add support, to read out the ADC and temperature sensor. This patchset is also reformatting device tree bindings, so they are easier to read (PATCH 1/1). To be able to add this ADC driver it is necessary to move some defines from the touchscreen driver to the mfd device (PATCH 2/8) so they are also accessible by mfd and adc driver. Because the touchscreen driver is also using the internal ADC it makes sense to put the common adc settings of stmpe-ts.c and stmpe_adc.c to the MFD. In the MFD there is then also an initialisation for the common settings of ADC done. The existing initialisation in touchscreen driver is kept for backwards-compatibility. All of this MFD related changes are in PATCH 3/8. In PATCH 4/8 then these settings are removed from stmpe-ts and grabbed from MFD. PATCH 5/8 is actually adding the ADC driver that also supports the built-in temperature sensor. PATCH 6/8 is then adding the needed devicetree bindings. PATCH 7/8 and 8/8 is lastly adding the stmpe_adc DT-nodes as found on Toradex boards. Changes in v5: - Made a one column list - Added lee's Acked-for-MFD - Changed author of commit to use correct email. - Changed author of commit to use correct email - Added Lee Jone's Ack - Changed author of commit. Previous patch versions author was wrong by mistake. - Changed author of commit to use correct email. - Removed devm_add_action_or_reset - Changed iio_device_register to devm_iio_device_register - Added Jonathan Cameron's Reviewed-by - Added correct author of commit, as this changed by accident - Made a one column list - Cleared note about precedence - Changed example to a full STMPE811 device with MFD, touchscreen, and the new stmpe_adc driver. - Added Jonathan Cameron's Reviewed-by Changes in v4: - New separate precursor patch for holding reformatting - Added Lee Jone's Ack - Added Dmitry Torokhov's Ack - New patch: split mfd changes into this precursor patch - Export the added stmpe811_adc_commmon_init function - Disabling adc when mfd is removed - New patch: Split changes in stmpe-ts.c to a separate commit - Remove common adc settings from init and call the stmpe811_adc_common_init function - Moved MFD changes to a precursor patch - Moved stmpe-ts changes to a precursor patch - Created stmpe_read_temp and stmpe_read_voltage functions to make read_raw more readable - Added local lock instead of using indio_dev's mlock - Use be16_to_cpu() macro instead of bitshifting - Added stmpe_enable again to stmpe_adc_init_hw - Use devm_add_action_or_reset to get rid of the remove function (I tested if that actually works) - Put reformatting in a separate precursor patch. - Moved T30 devicetree settings to separate commit - New separate commit to hold T30 devicetree changes Changes in v3: - Undo ADC-settings related code-deletions in stmpe-ts.c that the code is backwards-compatible to older devicetrees. - Removed COMPILE_TEST from dependings in Kconfig - Removed stmpe_adc_get_platform_info() function and integrated the few code lines in the other function - Reformatted documentation for touchscreen to use tabs and have a better overview of the settings. - Added note which adc-settings will take precedence. - changed typo in sample-time setting from 144 clocks to 124 clocks, as stated in the datasheet. - None Changes in v2: - This is a new added commit. Separate commit for moving the defines out of drivers/input/touchscreen/stmpe-ts.c to overlying mfd-device drivers/mfd/stmpe.c - Pre-fix defines with STMPE_ - Move code to setup ADC to MFD device, as it is used by both drivers adc and touchscreen - Code formatting - Removed unused includes - Defined the macro STMPE_START_ONE_TEMP_CONV with other macros. - Added new macro that defines the channel of the temperature sensor. Took new name for STMPE_MAX_ADC->STMPE_ADC_LAST_NR and used it throughout the code for better readability. - Added mutex_unlock where missing. - Moved the bindings for ADC to the overlying mfd. - Reformatted for better readability - Put common ADC settings in mfd Philippe Schenker (5): dt-bindings: stmpe: reformatting parameter list and use tabs only mfd: stmpe: Move ADC related defines to header of mfd Input: stmpe-ts: preparations for STMPE ADC driver ARM: dts: Add stmpe-adc DT node to Toradex iMX6 modules ARM: dts: Add stmpe-adc DT node to Toradex T30 modules Stefan Agner (3): mfd: stmpe: preparations for STMPE ADC driver iio: adc: add STMPE ADC driver using IIO framework iio: adc: add STMPE ADC devicetree bindings .../devicetree/bindings/iio/adc/stmpe-adc.txt | 21 + .../bindings/input/touchscreen/stmpe.txt | 116 ++++-- .../devicetree/bindings/mfd/stmpe.txt | 28 +- arch/arm/boot/dts/imx6qdl-apalis.dtsi | 22 +- arch/arm/boot/dts/imx6qdl-colibri.dtsi | 23 +- arch/arm/boot/dts/tegra30-apalis.dtsi | 22 +- arch/arm/boot/dts/tegra30-colibri.dtsi | 22 +- drivers/iio/adc/Kconfig | 7 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/stmpe-adc.c | 363 ++++++++++++++++++ drivers/input/touchscreen/stmpe-ts.c | 66 +--- drivers/mfd/Kconfig | 3 +- drivers/mfd/stmpe.c | 68 ++++ include/linux/mfd/stmpe.h | 21 + 14 files changed, 667 insertions(+), 116 deletions(-) create mode 100644 Documentation/devicetree/bindings/iio/adc/stmpe-adc.txt create mode 100644 drivers/iio/adc/stmpe-adc.c -- 2.19.2 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v5 8/8] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules 2018-12-21 13:46 [PATCH v5 0/8] Adding support for STMPE811 ADC Philippe Schenker @ 2018-12-21 13:46 ` Philippe Schenker 2019-01-09 11:51 ` Marcel Ziswiler 2019-01-16 12:44 ` [GIT PULL] Immutable branch between MFD, IIO and Input due for the v5.1 merge window Lee Jones 1 sibling, 1 reply; 4+ messages in thread From: Philippe Schenker @ 2018-12-21 13:46 UTC (permalink / raw) To: jic23, marcel.ziswiler, stefan Cc: robh, alexandre.torgue, shawnguo, dmitry.torokhov, thierry.reding, digetx, lee.jones, coquelin.stm32, Philippe Schenker, devicetree, Jonathan Hunter, linux-kernel, Rob Herring, linux-tegra, Mark Rutland From: Philippe Schenker <philippe.schenker@toradex.com> Add the stmpe-adc DT node as found on Toradex T30 modules Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> --- Changes in v5: None Changes in v4: - New separate commit to hold T30 devicetree changes Changes in v3: None Changes in v2: None arch/arm/boot/dts/tegra30-apalis.dtsi | 22 ++++++++++++++-------- arch/arm/boot/dts/tegra30-colibri.dtsi | 22 ++++++++++++++-------- 2 files changed, 28 insertions(+), 16 deletions(-) diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi index 7f112f192fe9..850b0d13549a 100644 --- a/arch/arm/boot/dts/tegra30-apalis.dtsi +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi @@ -976,11 +976,18 @@ id = <0>; blocks = <0x5>; irq-trigger = <0x1>; + /* 3.25 MHz ADC clock speed */ + st,adc-freq = <1>; + /* 12-bit ADC */ + st,mod-12b = <1>; + /* internal ADC reference */ + st,ref-sel = <0>; + /* ADC converstion time: 80 clocks */ + st,sample-time = <4>; + /* forbid to use ADC channels 3-0 (touch) */ stmpe_touchscreen { compatible = "st,stmpe-ts"; - /* 3.25 MHz ADC clock speed */ - st,adc-freq = <1>; /* 8 sample average control */ st,ave-ctrl = <3>; /* 7 length fractional part in z */ @@ -990,17 +997,16 @@ * current limit value */ st,i-drive = <1>; - /* 12-bit ADC */ - st,mod-12b = <1>; - /* internal ADC reference */ - st,ref-sel = <0>; - /* ADC converstion time: 80 clocks */ - st,sample-time = <4>; /* 1 ms panel driver settling time */ st,settling = <3>; /* 5 ms touch detect interrupt delay */ st,touch-det-delay = <5>; }; + + stmpe_adc { + compatible = "st,stmpe-adc"; + st,norequest-mask = <0x0F>; + }; }; /* diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi b/arch/arm/boot/dts/tegra30-colibri.dtsi index 35af03ca9e90..1f9198bb24ff 100644 --- a/arch/arm/boot/dts/tegra30-colibri.dtsi +++ b/arch/arm/boot/dts/tegra30-colibri.dtsi @@ -845,11 +845,18 @@ id = <0>; blocks = <0x5>; irq-trigger = <0x1>; + /* 3.25 MHz ADC clock speed */ + st,adc-freq = <1>; + /* 12-bit ADC */ + st,mod-12b = <1>; + /* internal ADC reference */ + st,ref-sel = <0>; + /* ADC converstion time: 80 clocks */ + st,sample-time = <4>; + /* forbid to use ADC channels 3-0 (touch) */ stmpe_touchscreen { compatible = "st,stmpe-ts"; - /* 3.25 MHz ADC clock speed */ - st,adc-freq = <1>; /* 8 sample average control */ st,ave-ctrl = <3>; /* 7 length fractional part in z */ @@ -859,17 +866,16 @@ * current limit value */ st,i-drive = <1>; - /* 12-bit ADC */ - st,mod-12b = <1>; - /* internal ADC reference */ - st,ref-sel = <0>; - /* ADC converstion time: 80 clocks */ - st,sample-time = <4>; /* 1 ms panel driver settling time */ st,settling = <3>; /* 5 ms touch detect interrupt delay */ st,touch-det-delay = <5>; }; + + stmpe_adc { + compatible = "st,stmpe-adc"; + st,norequest-mask = <0x0F>; + }; }; /* -- 2.19.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v5 8/8] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules 2018-12-21 13:46 ` [PATCH v5 8/8] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules Philippe Schenker @ 2019-01-09 11:51 ` Marcel Ziswiler 0 siblings, 0 replies; 4+ messages in thread From: Marcel Ziswiler @ 2019-01-09 11:51 UTC (permalink / raw) To: stefan@agner.ch, dev@pschenker.ch, jic23@kernel.org Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org, jonathanh@nvidia.com, devicetree@vger.kernel.org, lee.jones@linaro.org, digetx@gmail.com, thierry.reding@gmail.com, coquelin.stm32@gmail.com, Philippe Schenker, mark.rutland@arm.com, robh@kernel.org, shawnguo@kernel.org, alexandre.torgue@st.com, dmitry.torokhov@gmail.com, linux-tegra@vger.kernel.org On Fri, 2018-12-21 at 14:46 +0100, Philippe Schenker wrote: > From: Philippe Schenker <philippe.schenker@toradex.com> > > Add the stmpe-adc DT node as found on Toradex T30 modules > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > --- > > Changes in v5: None > Changes in v4: > - New separate commit to hold T30 devicetree changes > > Changes in v3: None > Changes in v2: None > > arch/arm/boot/dts/tegra30-apalis.dtsi | 22 ++++++++++++++-------- > arch/arm/boot/dts/tegra30-colibri.dtsi | 22 ++++++++++++++-------- > 2 files changed, 28 insertions(+), 16 deletions(-) > > diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi > b/arch/arm/boot/dts/tegra30-apalis.dtsi > index 7f112f192fe9..850b0d13549a 100644 > --- a/arch/arm/boot/dts/tegra30-apalis.dtsi > +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi > @@ -976,11 +976,18 @@ > id = <0>; > blocks = <0x5>; > irq-trigger = <0x1>; > + /* 3.25 MHz ADC clock speed */ > + st,adc-freq = <1>; > + /* 12-bit ADC */ > + st,mod-12b = <1>; > + /* internal ADC reference */ > + st,ref-sel = <0>; > + /* ADC converstion time: 80 clocks */ > + st,sample-time = <4>; > + /* forbid to use ADC channels 3-0 (touch) */ > > stmpe_touchscreen { > compatible = "st,stmpe-ts"; > - /* 3.25 MHz ADC clock speed */ > - st,adc-freq = <1>; > /* 8 sample average control */ > st,ave-ctrl = <3>; > /* 7 length fractional part in z */ > @@ -990,17 +997,16 @@ > * current limit value > */ > st,i-drive = <1>; > - /* 12-bit ADC */ > - st,mod-12b = <1>; > - /* internal ADC reference */ > - st,ref-sel = <0>; > - /* ADC converstion time: 80 clocks */ > - st,sample-time = <4>; > /* 1 ms panel driver settling time */ > st,settling = <3>; > /* 5 ms touch detect interrupt delay */ > st,touch-det-delay = <5>; > }; > + > + stmpe_adc { > + compatible = "st,stmpe-adc"; > + st,norequest-mask = <0x0F>; > + }; > }; > > /* > diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi > b/arch/arm/boot/dts/tegra30-colibri.dtsi > index 35af03ca9e90..1f9198bb24ff 100644 > --- a/arch/arm/boot/dts/tegra30-colibri.dtsi > +++ b/arch/arm/boot/dts/tegra30-colibri.dtsi > @@ -845,11 +845,18 @@ > id = <0>; > blocks = <0x5>; > irq-trigger = <0x1>; > + /* 3.25 MHz ADC clock speed */ > + st,adc-freq = <1>; > + /* 12-bit ADC */ > + st,mod-12b = <1>; > + /* internal ADC reference */ > + st,ref-sel = <0>; > + /* ADC converstion time: 80 clocks */ > + st,sample-time = <4>; > + /* forbid to use ADC channels 3-0 (touch) */ > > stmpe_touchscreen { > compatible = "st,stmpe-ts"; > - /* 3.25 MHz ADC clock speed */ > - st,adc-freq = <1>; > /* 8 sample average control */ > st,ave-ctrl = <3>; > /* 7 length fractional part in z */ > @@ -859,17 +866,16 @@ > * current limit value > */ > st,i-drive = <1>; > - /* 12-bit ADC */ > - st,mod-12b = <1>; > - /* internal ADC reference */ > - st,ref-sel = <0>; > - /* ADC converstion time: 80 clocks */ > - st,sample-time = <4>; > /* 1 ms panel driver settling time */ > st,settling = <3>; > /* 5 ms touch detect interrupt delay */ > st,touch-det-delay = <5>; > }; > + > + stmpe_adc { > + compatible = "st,stmpe-adc"; > + st,norequest-mask = <0x0F>; > + }; > }; > > /* ^ permalink raw reply [flat|nested] 4+ messages in thread
* [GIT PULL] Immutable branch between MFD, IIO and Input due for the v5.1 merge window 2018-12-21 13:46 [PATCH v5 0/8] Adding support for STMPE811 ADC Philippe Schenker 2018-12-21 13:46 ` [PATCH v5 8/8] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules Philippe Schenker @ 2019-01-16 12:44 ` Lee Jones 1 sibling, 0 replies; 4+ messages in thread From: Lee Jones @ 2019-01-16 12:44 UTC (permalink / raw) To: Philippe Schenker Cc: jic23, marcel.ziswiler, stefan, robh, alexandre.torgue, shawnguo, dmitry.torokhov, thierry.reding, digetx, coquelin.stm32, Philippe Schenker, Arnd Bergmann, Arnaud Pouliquen, linux-iio, Mark Brown, Pengutronix Kernel Team, Rob Herring, Geert Uytterhoeven, William Breathitt Gray, linux-stm32, Fabio Estevam, Randy Dunlap, Jonathan Cameron, Freeman Liu <fre> Taken all but the ARM patches. These need to be reviewed and go in via ARM-SoC. The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c: Linux 5.0-rc1 (2019-01-06 17:08:20 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-iio-input-v5.1 for you to fetch changes up to 81cdab79818988d27d8aeb162b7988c9e6dde936: iio: adc: add STMPE ADC devicetree bindings (2019-01-16 12:37:36 +0000) ---------------------------------------------------------------- Immutable branch between MFD, IIO and Input due for the v5.1 merge window ---------------------------------------------------------------- Philippe Schenker (3): dt-bindings: stmpe: Reformatting parameter list and use tabs only mfd: stmpe: Move ADC related defines to MFD header Input: stmpe-ts: preparations for STMPE ADC driver Stefan Agner (3): mfd: stmpe: Preparations for STMPE ADC driver iio: adc: add STMPE ADC driver using IIO framework iio: adc: add STMPE ADC devicetree bindings .../devicetree/bindings/iio/adc/stmpe-adc.txt | 21 ++ .../bindings/input/touchscreen/stmpe.txt | 116 +++++-- Documentation/devicetree/bindings/mfd/stmpe.txt | 28 +- drivers/iio/adc/Kconfig | 7 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/stmpe-adc.c | 363 +++++++++++++++++++++ drivers/input/touchscreen/stmpe-ts.c | 66 +--- drivers/mfd/Kconfig | 3 +- drivers/mfd/stmpe.c | 68 ++++ include/linux/mfd/stmpe.h | 21 ++ 10 files changed, 610 insertions(+), 84 deletions(-) create mode 100644 Documentation/devicetree/bindings/iio/adc/stmpe-adc.txt create mode 100644 drivers/iio/adc/stmpe-adc.c -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-16 12:44 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-12-21 13:46 [PATCH v5 0/8] Adding support for STMPE811 ADC Philippe Schenker 2018-12-21 13:46 ` [PATCH v5 8/8] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules Philippe Schenker 2019-01-09 11:51 ` Marcel Ziswiler 2019-01-16 12:44 ` [GIT PULL] Immutable branch between MFD, IIO and Input due for the v5.1 merge window Lee Jones
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox