* [PATCH 18/21] drm/tegra: Use drm_fb_helper_fill_info [not found] <20190326132008.11781-1-daniel.vetter@ffwll.ch> @ 2019-03-26 13:20 ` Daniel Vetter 2019-03-26 14:53 ` Noralf Trønnes 2019-03-26 14:55 ` Thierry Reding 0 siblings, 2 replies; 3+ messages in thread From: Daniel Vetter @ 2019-03-26 13:20 UTC (permalink / raw) To: DRI Development Cc: Daniel Vetter, Intel Graphics Development, Jonathan Hunter, Thierry Reding, linux-tegra, Daniel Vetter, Thierry Reding Another driver that didn't set fbinfo->fix.id before. v2: Fix subject and rebase Acked-by: Thierry Reding <treding@nvidia.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Jonathan Hunter <jonathanh@nvidia.com> Cc: linux-tegra@vger.kernel.org --- drivers/gpu/drm/tegra/fb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c index 0a4ce05e00ab..1dd83a757dba 100644 --- a/drivers/gpu/drm/tegra/fb.c +++ b/drivers/gpu/drm/tegra/fb.c @@ -255,11 +255,9 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper, helper->fb = fb; helper->fbdev = info; - info->par = helper; info->fbops = &tegra_fb_ops; - drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth); - drm_fb_helper_fill_var(info, helper, fb->width, fb->height); + drm_fb_helper_fill_info(info, helper, sizes); offset = info->var.xoffset * bytes_per_pixel + info->var.yoffset * fb->pitches[0]; -- 2.20.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 18/21] drm/tegra: Use drm_fb_helper_fill_info 2019-03-26 13:20 ` [PATCH 18/21] drm/tegra: Use drm_fb_helper_fill_info Daniel Vetter @ 2019-03-26 14:53 ` Noralf Trønnes 2019-03-26 14:55 ` Thierry Reding 1 sibling, 0 replies; 3+ messages in thread From: Noralf Trønnes @ 2019-03-26 14:53 UTC (permalink / raw) To: Daniel Vetter, DRI Development Cc: Intel Graphics Development, Jonathan Hunter, Thierry Reding, linux-tegra, Daniel Vetter, Thierry Reding Den 26.03.2019 14.20, skrev Daniel Vetter: > Another driver that didn't set fbinfo->fix.id before. > > v2: Fix subject and rebase > > Acked-by: Thierry Reding <treding@nvidia.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: linux-tegra@vger.kernel.org > --- Reviewed-by: Noralf Trønnes <noralf@tronnes.org> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 18/21] drm/tegra: Use drm_fb_helper_fill_info 2019-03-26 13:20 ` [PATCH 18/21] drm/tegra: Use drm_fb_helper_fill_info Daniel Vetter 2019-03-26 14:53 ` Noralf Trønnes @ 2019-03-26 14:55 ` Thierry Reding 1 sibling, 0 replies; 3+ messages in thread From: Thierry Reding @ 2019-03-26 14:55 UTC (permalink / raw) To: Daniel Vetter Cc: Intel Graphics Development, DRI Development, Jonathan Hunter, linux-tegra, Daniel Vetter, Thierry Reding [-- Attachment #1.1: Type: text/plain, Size: 543 bytes --] On Tue, Mar 26, 2019 at 02:20:05PM +0100, Daniel Vetter wrote: > Another driver that didn't set fbinfo->fix.id before. > > v2: Fix subject and rebase > > Acked-by: Thierry Reding <treding@nvidia.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: linux-tegra@vger.kernel.org > --- > drivers/gpu/drm/tegra/fb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Acked-by: Thierry Reding <treding@nvidia.com> [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-26 14:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190326132008.11781-1-daniel.vetter@ffwll.ch>
2019-03-26 13:20 ` [PATCH 18/21] drm/tegra: Use drm_fb_helper_fill_info Daniel Vetter
2019-03-26 14:53 ` Noralf Trønnes
2019-03-26 14:55 ` Thierry Reding
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox