* [PATCH] PCI: tegra: include linux/pinctrl/consumer.h
@ 2019-09-20 14:55 Arnd Bergmann
2019-09-20 15:07 ` Andrew Murray
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2019-09-20 14:55 UTC (permalink / raw)
To: Lorenzo Pieralisi, Bjorn Helgaas, Thierry Reding, Jonathan Hunter
Cc: Arnd Bergmann, Vidya Sagar, Andrew Murray, Thierry Reding,
linux-pci, linux-tegra, linux-kernel
Without this, we can run into a build failure:
drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror,-Wimplicit-function-declaration]
Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
index 09ed8e473cff..f89f5acee72d 100644
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -22,6 +22,7 @@
#include <linux/of_pci.h>
#include <linux/pci.h>
#include <linux/phy/phy.h>
+#include <linux/pinctrl/consumer.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
#include <linux/random.h>
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: tegra: include linux/pinctrl/consumer.h
2019-09-20 14:55 [PATCH] PCI: tegra: include linux/pinctrl/consumer.h Arnd Bergmann
@ 2019-09-20 15:07 ` Andrew Murray
2019-09-20 15:18 ` Lorenzo Pieralisi
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Murray @ 2019-09-20 15:07 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Lorenzo Pieralisi, Bjorn Helgaas, Thierry Reding, Jonathan Hunter,
Vidya Sagar, Thierry Reding, linux-pci, YueHaibing, linux-tegra,
linux-kernel
On Fri, Sep 20, 2019 at 04:55:05PM +0200, Arnd Bergmann wrote:
> Without this, we can run into a build failure:
>
> drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror,-Wimplicit-function-declaration]
>
> Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for this. Another fix for this came in earlier today:
https://patchwork.ozlabs.org/patch/1165139/
Reviewed-by: Andrew Murray <andrew.murray@arm.com>
Thanks,
Andrew Murray
> ---
> drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 09ed8e473cff..f89f5acee72d 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -22,6 +22,7 @@
> #include <linux/of_pci.h>
> #include <linux/pci.h>
> #include <linux/phy/phy.h>
> +#include <linux/pinctrl/consumer.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/random.h>
> --
> 2.20.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: tegra: include linux/pinctrl/consumer.h
2019-09-20 15:07 ` Andrew Murray
@ 2019-09-20 15:18 ` Lorenzo Pieralisi
0 siblings, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2019-09-20 15:18 UTC (permalink / raw)
To: Andrew Murray
Cc: Arnd Bergmann, Bjorn Helgaas, Thierry Reding, Jonathan Hunter,
Vidya Sagar, Thierry Reding, linux-pci, YueHaibing, linux-tegra,
linux-kernel
On Fri, Sep 20, 2019 at 04:07:14PM +0100, Andrew Murray wrote:
> On Fri, Sep 20, 2019 at 04:55:05PM +0200, Arnd Bergmann wrote:
> > Without this, we can run into a build failure:
> >
> > drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror,-Wimplicit-function-declaration]
> >
> > Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks for this. Another fix for this came in earlier today:
>
> https://patchwork.ozlabs.org/patch/1165139/
I have applied it since it came in earlier.
Thanks,
Lorenzo
> Reviewed-by: Andrew Murray <andrew.murray@arm.com>
>
> Thanks,
>
> Andrew Murray
>
> > ---
> > drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> > index 09ed8e473cff..f89f5acee72d 100644
> > --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> > @@ -22,6 +22,7 @@
> > #include <linux/of_pci.h>
> > #include <linux/pci.h>
> > #include <linux/phy/phy.h>
> > +#include <linux/pinctrl/consumer.h>
> > #include <linux/platform_device.h>
> > #include <linux/pm_runtime.h>
> > #include <linux/random.h>
> > --
> > 2.20.0
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-20 15:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-20 14:55 [PATCH] PCI: tegra: include linux/pinctrl/consumer.h Arnd Bergmann
2019-09-20 15:07 ` Andrew Murray
2019-09-20 15:18 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).