From: Mark Brown <broonie@kernel.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: jonathanh@nvidia.com, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: Re: [PATCH] regmap: add iopoll-like atomic polling macro
Date: Wed, 8 Jan 2020 13:36:08 +0000 [thread overview]
Message-ID: <20200108133608.GB3817@sirena.org.uk> (raw)
In-Reply-To: <ae119533-6966-157a-d14b-365306907554@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 566 bytes --]
On Wed, Jan 08, 2020 at 10:20:37AM +0530, Sameer Pujar wrote:
> While checking the documentation on snd_soc_dai_ops, it appears trigger() is
> in atomic context.
> This means I cannot use regmap interface (with default configuration) in
> trigger().
> The above issue went away with usage of regmap_read_poll_timeout_atomic()
> and now I think I just got lucky.
It's fine if your regmap is set up to support atomic use (using a flat
or no cache and MMIO) but not for regmaps in general, I'm asking you to
document the fact that it's only usable with some regmaps.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-01-08 13:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 10:28 [PATCH] regmap: add iopoll-like atomic polling macro Sameer Pujar
2020-01-07 12:09 ` Mark Brown
2020-01-08 4:50 ` Sameer Pujar
2020-01-08 13:36 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108133608.GB3817@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=spujar@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox