* [PATCH] mailbox: tegra-hsp: Flush whole channel
@ 2022-02-14 15:32 Thierry Reding
2022-02-14 15:42 ` Jon Hunter
0 siblings, 1 reply; 2+ messages in thread
From: Thierry Reding @ 2022-02-14 15:32 UTC (permalink / raw)
To: Jassi Brar
Cc: Jon Hunter, Mikko Perttunen, Pekka Pessi, linux-tegra,
linux-kernel
From: Pekka Pessi <ppessi@nvidia.com>
The txdone can re-fill the mailbox. Keep polling the mailbox during the
flush until all the messages have been delivered.
Signed-off-by: Pekka Pessi <ppessi@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/mailbox/tegra-hsp.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mailbox/tegra-hsp.c b/drivers/mailbox/tegra-hsp.c
index acd0675da681..78f7265039c6 100644
--- a/drivers/mailbox/tegra-hsp.c
+++ b/drivers/mailbox/tegra-hsp.c
@@ -412,6 +412,11 @@ static int tegra_hsp_mailbox_flush(struct mbox_chan *chan,
value = tegra_hsp_channel_readl(ch, HSP_SM_SHRD_MBOX);
if ((value & HSP_SM_SHRD_MBOX_FULL) == 0) {
mbox_chan_txdone(chan, 0);
+
+ /* Wait until channel is empty */
+ if (chan->active_req != NULL)
+ continue;
+
return 0;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mailbox: tegra-hsp: Flush whole channel
2022-02-14 15:32 [PATCH] mailbox: tegra-hsp: Flush whole channel Thierry Reding
@ 2022-02-14 15:42 ` Jon Hunter
0 siblings, 0 replies; 2+ messages in thread
From: Jon Hunter @ 2022-02-14 15:42 UTC (permalink / raw)
To: Thierry Reding, Jassi Brar
Cc: Mikko Perttunen, Pekka Pessi, linux-tegra, linux-kernel
On 14/02/2022 15:32, Thierry Reding wrote:
> From: Pekka Pessi <ppessi@nvidia.com>
>
> The txdone can re-fill the mailbox. Keep polling the mailbox during the
> flush until all the messages have been delivered.
>
> Signed-off-by: Pekka Pessi <ppessi@nvidia.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/mailbox/tegra-hsp.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mailbox/tegra-hsp.c b/drivers/mailbox/tegra-hsp.c
> index acd0675da681..78f7265039c6 100644
> --- a/drivers/mailbox/tegra-hsp.c
> +++ b/drivers/mailbox/tegra-hsp.c
> @@ -412,6 +412,11 @@ static int tegra_hsp_mailbox_flush(struct mbox_chan *chan,
> value = tegra_hsp_channel_readl(ch, HSP_SM_SHRD_MBOX);
> if ((value & HSP_SM_SHRD_MBOX_FULL) == 0) {
> mbox_chan_txdone(chan, 0);
> +
> + /* Wait until channel is empty */
> + if (chan->active_req != NULL)
> + continue;
> +
> return 0;
> }
>
Thanks!
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Maybe worth mentioning that this fixes an annoying issue with the TCU
(Tegra Combined UART) where the output is getting truncated. I think we
should add the following fixes tag and mark for stable too.
Fixes: 91b1b1c3da8a ("mailbox: tegra-hsp: Add support for shared mailboxes")
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-14 15:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-14 15:32 [PATCH] mailbox: tegra-hsp: Flush whole channel Thierry Reding
2022-02-14 15:42 ` Jon Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox