* [PATCH] soc/tegra: Enable Tegra186 timer support
@ 2022-10-25 15:41 Jon Hunter
2022-10-28 14:30 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Jon Hunter @ 2022-10-25 15:41 UTC (permalink / raw)
To: Thierry Reding; +Cc: linux-tegra, Jon Hunter
Enable Tegra186 timer support for Tegra186, Tegra194 and Tegra234
devices.
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
drivers/soc/tegra/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
index 5f5324294636..e49409b85a39 100644
--- a/drivers/soc/tegra/Kconfig
+++ b/drivers/soc/tegra/Kconfig
@@ -99,6 +99,7 @@ config ARCH_TEGRA_186_SOC
select TEGRA_BPMP
select TEGRA_HSP_MBOX
select TEGRA_IVC
+ select TEGRA186_TIMER
select SOC_TEGRA_PMC
help
Enable support for the NVIDIA Tegar186 SoC. The Tegra186 features a
@@ -115,6 +116,7 @@ config ARCH_TEGRA_194_SOC
select TEGRA_BPMP
select TEGRA_HSP_MBOX
select TEGRA_IVC
+ select TEGRA186_TIMER
select SOC_TEGRA_PMC
help
Enable support for the NVIDIA Tegra194 SoC.
@@ -125,6 +127,7 @@ config ARCH_TEGRA_234_SOC
select TEGRA_BPMP
select TEGRA_HSP_MBOX
select TEGRA_IVC
+ select TEGRA186_TIMER
select SOC_TEGRA_PMC
help
Enable support for the NVIDIA Tegra234 SoC.
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soc/tegra: Enable Tegra186 timer support
2022-10-25 15:41 [PATCH] soc/tegra: Enable Tegra186 timer support Jon Hunter
@ 2022-10-28 14:30 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2022-10-28 14:30 UTC (permalink / raw)
To: Jon Hunter; +Cc: linux-tegra
[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]
On Tue, Oct 25, 2022 at 04:41:31PM +0100, Jon Hunter wrote:
> Enable Tegra186 timer support for Tegra186, Tegra194 and Tegra234
> devices.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/soc/tegra/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
I realize that we have the same construct on older SoC generations, but
we really shouldn't be selecting user-visible symbols because that can
lead to conflicting configurations. The correct way to do this is to
enable via defconfig, even if that strictly allows people to disable
this driver again.
Thierry
>
> diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
> index 5f5324294636..e49409b85a39 100644
> --- a/drivers/soc/tegra/Kconfig
> +++ b/drivers/soc/tegra/Kconfig
> @@ -99,6 +99,7 @@ config ARCH_TEGRA_186_SOC
> select TEGRA_BPMP
> select TEGRA_HSP_MBOX
> select TEGRA_IVC
> + select TEGRA186_TIMER
> select SOC_TEGRA_PMC
> help
> Enable support for the NVIDIA Tegar186 SoC. The Tegra186 features a
> @@ -115,6 +116,7 @@ config ARCH_TEGRA_194_SOC
> select TEGRA_BPMP
> select TEGRA_HSP_MBOX
> select TEGRA_IVC
> + select TEGRA186_TIMER
> select SOC_TEGRA_PMC
> help
> Enable support for the NVIDIA Tegra194 SoC.
> @@ -125,6 +127,7 @@ config ARCH_TEGRA_234_SOC
> select TEGRA_BPMP
> select TEGRA_HSP_MBOX
> select TEGRA_IVC
> + select TEGRA186_TIMER
> select SOC_TEGRA_PMC
> help
> Enable support for the NVIDIA Tegra234 SoC.
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-28 14:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-25 15:41 [PATCH] soc/tegra: Enable Tegra186 timer support Jon Hunter
2022-10-28 14:30 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox