* [Patch v2] cpufreq: tegra194: fix warning due to missing opp_put
@ 2023-08-29 8:43 Sumit Gupta
2023-08-29 9:03 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Sumit Gupta @ 2023-08-29 8:43 UTC (permalink / raw)
To: rafael, viresh.kumar, linux-pm, linux-tegra, linux-kernel
Cc: treding, jonathanh, bbasu, sumitg
Fix the warning due to missing dev_pm_opp_put() call and hence
wrong refcount value. This causes below warning message when
trying to remove the module.
Call trace:
dev_pm_opp_put_opp_table+0x154/0x15c
dev_pm_opp_remove_table+0x34/0xa0
_dev_pm_opp_cpumask_remove_table+0x7c/0xbc
dev_pm_opp_of_cpumask_remove_table+0x10/0x18
tegra194_cpufreq_exit+0x24/0x34 [tegra194_cpufreq]
cpufreq_remove_dev+0xa8/0xf8
subsys_interface_unregister+0x90/0xe8
cpufreq_unregister_driver+0x54/0x9c
tegra194_cpufreq_remove+0x18/0x2c [tegra194_cpufreq]
platform_remove+0x24/0x74
device_remove+0x48/0x78
device_release_driver_internal+0xc8/0x160
driver_detach+0x4c/0x90
bus_remove_driver+0x68/0xb8
driver_unregister+0x2c/0x58
platform_driver_unregister+0x10/0x18
tegra194_ccplex_driver_exit+0x14/0x1e0 [tegra194_cpufreq]
__arm64_sys_delete_module+0x184/0x270
Fixes: f41e1442ac5b ("cpufreq: tegra194: add OPP support and set bandwidth")
Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
---
drivers/cpufreq/tegra194-cpufreq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-cpufreq.c
index 88ef5e57ccd0..9d7e1d58f6e5 100644
--- a/drivers/cpufreq/tegra194-cpufreq.c
+++ b/drivers/cpufreq/tegra194-cpufreq.c
@@ -450,6 +450,7 @@ static int tegra_cpufreq_init_cpufreq_table(struct cpufreq_policy *policy,
if (IS_ERR(opp))
continue;
+ dev_pm_opp_put(opp);
ret = dev_pm_opp_enable(cpu_dev, pos->frequency * KHZ);
if (ret < 0)
return ret;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch v2] cpufreq: tegra194: fix warning due to missing opp_put
2023-08-29 8:43 [Patch v2] cpufreq: tegra194: fix warning due to missing opp_put Sumit Gupta
@ 2023-08-29 9:03 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2023-08-29 9:03 UTC (permalink / raw)
To: Sumit Gupta
Cc: rafael, linux-pm, linux-tegra, linux-kernel, treding, jonathanh,
bbasu
On 29-08-23, 14:13, Sumit Gupta wrote:
> Fix the warning due to missing dev_pm_opp_put() call and hence
> wrong refcount value. This causes below warning message when
> trying to remove the module.
>
> Call trace:
> dev_pm_opp_put_opp_table+0x154/0x15c
> dev_pm_opp_remove_table+0x34/0xa0
> _dev_pm_opp_cpumask_remove_table+0x7c/0xbc
> dev_pm_opp_of_cpumask_remove_table+0x10/0x18
> tegra194_cpufreq_exit+0x24/0x34 [tegra194_cpufreq]
> cpufreq_remove_dev+0xa8/0xf8
> subsys_interface_unregister+0x90/0xe8
> cpufreq_unregister_driver+0x54/0x9c
> tegra194_cpufreq_remove+0x18/0x2c [tegra194_cpufreq]
> platform_remove+0x24/0x74
> device_remove+0x48/0x78
> device_release_driver_internal+0xc8/0x160
> driver_detach+0x4c/0x90
> bus_remove_driver+0x68/0xb8
> driver_unregister+0x2c/0x58
> platform_driver_unregister+0x10/0x18
> tegra194_ccplex_driver_exit+0x14/0x1e0 [tegra194_cpufreq]
> __arm64_sys_delete_module+0x184/0x270
>
> Fixes: f41e1442ac5b ("cpufreq: tegra194: add OPP support and set bandwidth")
> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> ---
> drivers/cpufreq/tegra194-cpufreq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-cpufreq.c
> index 88ef5e57ccd0..9d7e1d58f6e5 100644
> --- a/drivers/cpufreq/tegra194-cpufreq.c
> +++ b/drivers/cpufreq/tegra194-cpufreq.c
> @@ -450,6 +450,7 @@ static int tegra_cpufreq_init_cpufreq_table(struct cpufreq_policy *policy,
> if (IS_ERR(opp))
> continue;
>
> + dev_pm_opp_put(opp);
> ret = dev_pm_opp_enable(cpu_dev, pos->frequency * KHZ);
> if (ret < 0)
> return ret;
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-29 9:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-29 8:43 [Patch v2] cpufreq: tegra194: fix warning due to missing opp_put Sumit Gupta
2023-08-29 9:03 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox