Re: [PATCH 4.14 00/21] 4.14.335-rc1 review

Re: [PATCH 4.14 00/21] 4.14.335-rc1 review

[Jon Hunter]

Hi Greg,

On 05/01/2024 14:38, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.14.335 release.
> There are 21 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sun, 07 Jan 2024 14:38:02 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.335-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h
> 
> -------------
> Pseudo-Shortlog of commits:

...


> Alexis Lothoré <alexis.lothore@bootlin.com>
>      pinctrl: at91-pio4: use dedicated lock class for IRQ


I am seeing the following build error for ARM ...

drivers/pinctrl/pinctrl-at91-pio4.c: In function ‘atmel_pinctrl_probe’:
drivers/pinctrl/pinctrl-at91-pio4.c:1054:3: error: too many arguments to function ‘irq_set_lockdep_class’
    irq_set_lockdep_class(irq, &atmel_lock_key, &atmel_request_key);
    ^~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/irq.h:517:0,
                  from include/linux/gpio/driver.h:7,
                  from drivers/pinctrl/pinctrl-at91-pio4.c:18:
include/linux/irqdesc.h:250:1: note: declared here
  irq_set_lockdep_class(unsigned int irq, struct lock_class_key *class)
  ^~~~~~~~~~~~~~~~~~~~~

I am guessing it is the above commit.

Jon
-- 
nvpublic

Re: [PATCH 4.14 00/21] 4.14.335-rc1 review

[Greg Kroah-Hartman]

On Fri, Jan 05, 2024 at 04:23:00PM +0000, Jon Hunter wrote:
> Hi Greg,
> 
> On 05/01/2024 14:38, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.14.335 release.
> > There are 21 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Sun, 07 Jan 2024 14:38:02 +0000.
> > Anything received after that time might be too late.
> > 
> > The whole patch series can be found in one patch at:
> > 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.335-rc1.gz
> > or in the git tree and branch at:
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
> > and the diffstat can be found below.
> > 
> > thanks,
> > 
> > greg k-h
> > 
> > -------------
> > Pseudo-Shortlog of commits:
> 
> ...
> 
> 
> > Alexis Lothoré <alexis.lothore@bootlin.com>
> >      pinctrl: at91-pio4: use dedicated lock class for IRQ
> 
> 
> I am seeing the following build error for ARM ...
> 
> drivers/pinctrl/pinctrl-at91-pio4.c: In function ‘atmel_pinctrl_probe’:
> drivers/pinctrl/pinctrl-at91-pio4.c:1054:3: error: too many arguments to function ‘irq_set_lockdep_class’
>    irq_set_lockdep_class(irq, &atmel_lock_key, &atmel_request_key);
>    ^~~~~~~~~~~~~~~~~~~~~
> In file included from include/linux/irq.h:517:0,
>                  from include/linux/gpio/driver.h:7,
>                  from drivers/pinctrl/pinctrl-at91-pio4.c:18:
> include/linux/irqdesc.h:250:1: note: declared here
>  irq_set_lockdep_class(unsigned int irq, struct lock_class_key *class)
>  ^~~~~~~~~~~~~~~~~~~~~
> 
> I am guessing it is the above commit.

Thanks, now dropped.

greg k-h