[PATCH] arm64: tegra: Add AXI configuration for Tegra234 MGBE

[PATCH] arm64: tegra: Add AXI configuration for Tegra234 MGBE

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>

The MGBE devices found on Tegra234 need their AXI interface configured
to operate at peak performance. Ideally we would do this in the driver
based off the compatible string, but the DT bindings already specify a
separate mechanism, so reuse that.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 arch/arm64/boot/dts/nvidia/tegra234.dtsi | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
index 3f16595d099c..84c74155a5ca 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
@@ -1461,6 +1461,14 @@ ethernet@6800000 {
 			iommus = <&smmu_niso0 TEGRA234_SID_MGBE>;
 			power-domains = <&bpmp TEGRA234_POWER_DOMAIN_MGBEA>;
 			status = "disabled";
+
+			snps,axi-config = <&mgbe0_axi_setup>;
+
+			mgbe0_axi_setup: stmmac-axi-config {
+				snps,blen = <256 128 64 32>;
+				snps,rd_osr_lmt = <63>;
+				snps,wr_osr_lmt = <63>;
+			};
 		};
 
 		ethernet@6900000 {
@@ -1495,6 +1503,14 @@ ethernet@6900000 {
 			iommus = <&smmu_niso0 TEGRA234_SID_MGBE_VF1>;
 			power-domains = <&bpmp TEGRA234_POWER_DOMAIN_MGBEB>;
 			status = "disabled";
+
+			snps,axi-config = <&mgbe1_axi_setup>;
+
+			mgbe1_axi_setup: stmmac-axi-config {
+				snps,blen = <256 128 64 32>;
+				snps,rd_osr_lmt = <63>;
+				snps,wr_osr_lmt = <63>;
+			};
 		};
 
 		ethernet@6a00000 {
@@ -1529,6 +1545,14 @@ ethernet@6a00000 {
 			iommus = <&smmu_niso0 TEGRA234_SID_MGBE_VF2>;
 			power-domains = <&bpmp TEGRA234_POWER_DOMAIN_MGBEC>;
 			status = "disabled";
+
+			snps,axi-config = <&mgbe2_axi_setup>;
+
+			mgbe2_axi_setup: stmmac-axi-config {
+				snps,blen = <256 128 64 32>;
+				snps,rd_osr_lmt = <63>;
+				snps,wr_osr_lmt = <63>;
+			};
 		};
 
 		ethernet@6b00000 {
-- 
2.43.2

Re: [PATCH] arm64: tegra: Add AXI configuration for Tegra234 MGBE

[Jon Hunter]

On 22/02/2024 17:01, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> The MGBE devices found on Tegra234 need their AXI interface configured
> to operate at peak performance. Ideally we would do this in the driver
> based off the compatible string, but the DT bindings already specify a
> separate mechanism, so reuse that.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>   arch/arm64/boot/dts/nvidia/tegra234.dtsi | 24 ++++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> index 3f16595d099c..84c74155a5ca 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> @@ -1461,6 +1461,14 @@ ethernet@6800000 {
>   			iommus = <&smmu_niso0 TEGRA234_SID_MGBE>;
>   			power-domains = <&bpmp TEGRA234_POWER_DOMAIN_MGBEA>;
>   			status = "disabled";
> +
> +			snps,axi-config = <&mgbe0_axi_setup>;
> +
> +			mgbe0_axi_setup: stmmac-axi-config {
> +				snps,blen = <256 128 64 32>;
> +				snps,rd_osr_lmt = <63>;
> +				snps,wr_osr_lmt = <63>;
> +			};
>   		};
>   
>   		ethernet@6900000 {
> @@ -1495,6 +1503,14 @@ ethernet@6900000 {
>   			iommus = <&smmu_niso0 TEGRA234_SID_MGBE_VF1>;
>   			power-domains = <&bpmp TEGRA234_POWER_DOMAIN_MGBEB>;
>   			status = "disabled";
> +
> +			snps,axi-config = <&mgbe1_axi_setup>;
> +
> +			mgbe1_axi_setup: stmmac-axi-config {
> +				snps,blen = <256 128 64 32>;
> +				snps,rd_osr_lmt = <63>;
> +				snps,wr_osr_lmt = <63>;
> +			};
>   		};
>   
>   		ethernet@6a00000 {
> @@ -1529,6 +1545,14 @@ ethernet@6a00000 {
>   			iommus = <&smmu_niso0 TEGRA234_SID_MGBE_VF2>;
>   			power-domains = <&bpmp TEGRA234_POWER_DOMAIN_MGBEC>;
>   			status = "disabled";
> +
> +			snps,axi-config = <&mgbe2_axi_setup>;
> +
> +			mgbe2_axi_setup: stmmac-axi-config {
> +				snps,blen = <256 128 64 32>;
> +				snps,rd_osr_lmt = <63>;
> +				snps,wr_osr_lmt = <63>;
> +			};
>   		};
>   
>   		ethernet@6b00000 {

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>

Fixes the speed for me! Thanks!

Jon

-- 
nvpublic