[PATCH 0/3] Make pci/endpoint branch build

[PATCH 0/3] Make pci/endpoint branch build

[Niklas Cassel]

The pci/next branch has currently not merged the latest pci/endpoint
branch.

Perhaps this delay in creating a new pci/next branch is because the
pci/endpoint branch currently fails to build.

Fix the build error on the pci/endpoint branch such that it will be
possible to queue further patches.


Kind regards,
Niklas

Niklas Cassel (3):
  PCI: dwc: ep: Add dw_pcie_ep_deinit_notify()
  PCI: qcom-ep: Make use of dw_pcie_ep_deinit_notify()
  PCI: tegra194: Make use of dw_pcie_ep_deinit_notify()

 drivers/pci/controller/dwc/pcie-designware-ep.c | 13 +++++++++++++
 drivers/pci/controller/dwc/pcie-designware.h    |  5 +++++
 drivers/pci/controller/dwc/pcie-qcom-ep.c       |  2 +-
 drivers/pci/controller/dwc/pcie-tegra194.c      |  2 +-
 4 files changed, 20 insertions(+), 2 deletions(-)

-- 
2.45.1

[PATCH 3/3] PCI: tegra194: Make use of dw_pcie_ep_deinit_notify()

[Niklas Cassel]

By using dw_pcie_ep_deinit_notify(), the init and deinit notification is
performed using the same API layer. This makes the driver more consistent.

It also fixes a linker error where pci_epc_deinit_notify() would fail to
link in certain Kconfig combinations, because the PCI endpoint API layer
does not provide any dummy implementations.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202405130815.BwBrIepL-lkp@intel.com
Fixes: f94f2844f28c ("PCI: endpoint: Introduce 'epc_deinit' event and notify the EPF drivers")
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
 drivers/pci/controller/dwc/pcie-tegra194.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
index 4b28f8beedfe..be1f10cadf1d 100644
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -1715,7 +1715,7 @@ static void pex_ep_event_pex_rst_assert(struct tegra_pcie_dw *pcie)
 	if (ret)
 		dev_err(pcie->dev, "Failed to go Detect state: %d\n", ret);
 
-	pci_epc_deinit_notify(pcie->pci.ep.epc);
+	dw_pcie_ep_deinit_notify(&pcie->pci.ep);
 	dw_pcie_ep_cleanup(&pcie->pci.ep);
 
 	reset_control_assert(pcie->core_rst);
-- 
2.45.1

Re: [PATCH 0/3] Make pci/endpoint branch build

[Bjorn Helgaas]

On Tue, May 28, 2024 at 03:00:36PM +0200, Niklas Cassel wrote:
> The pci/next branch has currently not merged the latest pci/endpoint
> branch.
> 
> Perhaps this delay in creating a new pci/next branch is because the
> pci/endpoint branch currently fails to build.

The topic branches have things queued on them for build testing, but
they haven't been merged to pci/next yet.  It's standard practice that
we don't add v6.11 content to -next until v6.10-rc1 is tagged:
https://lore.kernel.org/linux-next/20240523111023.7ade2aa4@canb.auug.org.au/

v6.10-rc1 was tagged 5/26, and 5/27 was a US holiday.  The topic
branches will be merged to pci/next today.

Bjorn

Re: [PATCH 0/3] Make pci/endpoint branch build

[Niklas Cassel]

On Tue, May 28, 2024 at 09:44:52AM -0500, Bjorn Helgaas wrote:
> On Tue, May 28, 2024 at 03:00:36PM +0200, Niklas Cassel wrote:
> > The pci/next branch has currently not merged the latest pci/endpoint
> > branch.
> > 
> > Perhaps this delay in creating a new pci/next branch is because the
> > pci/endpoint branch currently fails to build.
> 
> The topic branches have things queued on them for build testing, but
> they haven't been merged to pci/next yet.  It's standard practice that
> we don't add v6.11 content to -next until v6.10-rc1 is tagged:
> https://lore.kernel.org/linux-next/20240523111023.7ade2aa4@canb.auug.org.au/
> 
> v6.10-rc1 was tagged 5/26, and 5/27 was a US holiday.  The topic
> branches will be merged to pci/next today.

Ok, great!

Although, perhaps you would want to defer merging pci/endpoint to pci/next
until the linker error has been fixed.

We have already gotten a bunch of reports of this on the linux-pci list:
https://lore.kernel.org/linux-pci/202405270544.yKgcokbA-lkp@intel.com/T/#u
https://lore.kernel.org/linux-pci/202405130815.BwBrIepL-lkp@intel.com/T/#u
https://lore.kernel.org/linux-pci/202405140344.glj9WfzM-lkp@intel.com/T/#u

Merging the branch to pci/next is guaranteed to have even move people hit
and complain about this error.


Kind regards,
Niklas

Re: [PATCH 0/3] Make pci/endpoint branch buildgg

[Bjorn Helgaas]

On Tue, May 28, 2024 at 08:57:04PM +0200, Niklas Cassel wrote:
> On Tue, May 28, 2024 at 09:44:52AM -0500, Bjorn Helgaas wrote:
> > On Tue, May 28, 2024 at 03:00:36PM +0200, Niklas Cassel wrote:
> > > The pci/next branch has currently not merged the latest pci/endpoint
> > > branch.
> > > 
> > > Perhaps this delay in creating a new pci/next branch is because the
> > > pci/endpoint branch currently fails to build.
> > 
> > The topic branches have things queued on them for build testing, but
> > they haven't been merged to pci/next yet.  It's standard practice that
> > we don't add v6.11 content to -next until v6.10-rc1 is tagged:
> > https://lore.kernel.org/linux-next/20240523111023.7ade2aa4@canb.auug.org.au/
> > 
> > v6.10-rc1 was tagged 5/26, and 5/27 was a US holiday.  The topic
> > branches will be merged to pci/next today.
> 
> Ok, great!
> 
> Although, perhaps you would want to defer merging pci/endpoint to pci/next
> until the linker error has been fixed.
> 
> We have already gotten a bunch of reports of this on the linux-pci list:
> https://lore.kernel.org/linux-pci/202405270544.yKgcokbA-lkp@intel.com/T/#u
> https://lore.kernel.org/linux-pci/202405130815.BwBrIepL-lkp@intel.com/T/#u
> https://lore.kernel.org/linux-pci/202405140344.glj9WfzM-lkp@intel.com/T/#u
> 
> Merging the branch to pci/next is guaranteed to have even move people hit
> and complain about this error.

I included pci/endpoint but dropped the "PCI: endpoint: Introduce
'epc_deinit' event and notify the EPF drivers" patch until we fix that
issue.

Bjorn