* [PATCH][next] crypto: tegra: remove redundant error check on ret
@ 2024-10-15 13:11 Colin Ian King
2024-10-16 12:50 ` Akhil R
2024-10-26 6:56 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2024-10-15 13:11 UTC (permalink / raw)
To: Akhil R, Herbert Xu, David S . Miller, Thierry Reding,
Jonathan Hunter, linux-crypto, linux-tegra
Cc: kernel-janitors, linux-kernel
Currently there is an unnecessary error check on ret without a proceeding
assignment to ret that needs checking. The check is redundant and can be
removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/crypto/tegra/tegra-se-aes.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/crypto/tegra/tegra-se-aes.c b/drivers/crypto/tegra/tegra-se-aes.c
index ae7a0f8435fc..9d130592cc0a 100644
--- a/drivers/crypto/tegra/tegra-se-aes.c
+++ b/drivers/crypto/tegra/tegra-se-aes.c
@@ -1180,8 +1180,6 @@ static int tegra_ccm_do_one_req(struct crypto_engine *engine, void *areq)
goto out;
} else {
rctx->cryptlen = req->cryptlen - ctx->authsize;
- if (ret)
- goto out;
/* CTR operation */
ret = tegra_ccm_do_ctr(ctx, rctx);
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH][next] crypto: tegra: remove redundant error check on ret
2024-10-15 13:11 [PATCH][next] crypto: tegra: remove redundant error check on ret Colin Ian King
@ 2024-10-16 12:50 ` Akhil R
2024-10-26 6:56 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Akhil R @ 2024-10-16 12:50 UTC (permalink / raw)
To: Colin Ian King, Herbert Xu, David S . Miller, Thierry Reding,
Jon Hunter, linux-crypto@vger.kernel.org,
linux-tegra@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
> Currently there is an unnecessary error check on ret without a proceeding
> assignment to ret that needs checking. The check is redundant and can be
> removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/crypto/tegra/tegra-se-aes.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/crypto/tegra/tegra-se-aes.c b/drivers/crypto/tegra/tegra-se-
> aes.c
> index ae7a0f8435fc..9d130592cc0a 100644
> --- a/drivers/crypto/tegra/tegra-se-aes.c
> +++ b/drivers/crypto/tegra/tegra-se-aes.c
> @@ -1180,8 +1180,6 @@ static int tegra_ccm_do_one_req(struct crypto_engine
> *engine, void *areq)
> goto out;
> } else {
> rctx->cryptlen = req->cryptlen - ctx->authsize;
> - if (ret)
> - goto out;
>
> /* CTR operation */
> ret = tegra_ccm_do_ctr(ctx, rctx);
> --
Agreed. Thanks for pointing.
Acked-by: Akhil R <akhilrajeev@nvidia.com>
Regards,
Akhil
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] crypto: tegra: remove redundant error check on ret
2024-10-15 13:11 [PATCH][next] crypto: tegra: remove redundant error check on ret Colin Ian King
2024-10-16 12:50 ` Akhil R
@ 2024-10-26 6:56 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2024-10-26 6:56 UTC (permalink / raw)
To: Colin Ian King
Cc: Akhil R, David S . Miller, Thierry Reding, Jonathan Hunter,
linux-crypto, linux-tegra, kernel-janitors, linux-kernel
On Tue, Oct 15, 2024 at 02:11:22PM +0100, Colin Ian King wrote:
> Currently there is an unnecessary error check on ret without a proceeding
> assignment to ret that needs checking. The check is redundant and can be
> removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/crypto/tegra/tegra-se-aes.c | 2 --
> 1 file changed, 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-26 6:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-15 13:11 [PATCH][next] crypto: tegra: remove redundant error check on ret Colin Ian King
2024-10-16 12:50 ` Akhil R
2024-10-26 6:56 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox