Re: [PATCH 6.1 000/798] 6.1.113-rc1 review

Re: [PATCH 6.1 000/798] 6.1.113-rc1 review

[Jon Hunter]

Hi Greg,

On 14/10/2024 15:09, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.113 release.
> There are 798 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Wed, 16 Oct 2024 14:09:57 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.113-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h
> 
> -------------
> Pseudo-Shortlog of commits:

...
  
> Oleksij Rempel <linux@rempel-privat.de>
>      clk: imx6ul: add ethernet refclock mux support


I am seeing the following build issue for ARM multi_v7_defconfig and
bisect is point to the commit ...

drivers/clk/imx/clk-imx6ul.c: In function ‘imx6ul_clocks_init’:
drivers/clk/imx/clk-imx6ul.c:487:34: error: implicit declaration of function ‘imx_obtain_fixed_of_clock’; did you mean ‘imx_obtain_fixed_clock’? [-Werror=implicit-function-declaration]
   hws[IMX6UL_CLK_ENET1_REF_PAD] = imx_obtain_fixed_of_clock(ccm_node, "enet1_ref_pad", 0);
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~
                                   imx_obtain_fixed_clock
drivers/clk/imx/clk-imx6ul.c:487:32: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
   hws[IMX6UL_CLK_ENET1_REF_PAD] = imx_obtain_fixed_of_clock(ccm_node, "enet1_ref_pad", 0);
                                 ^
drivers/clk/imx/clk-imx6ul.c:489:34: error: implicit declaration of function ‘imx_clk_gpr_mux’; did you mean ‘imx_clk_hw_mux’? [-Werror=implicit-function-declaration]
   hws[IMX6UL_CLK_ENET1_REF_SEL] = imx_clk_gpr_mux("enet1_ref_sel", "fsl,imx6ul-iomuxc-gpr",
                                   ^~~~~~~~~~~~~~~
                                   imx_clk_hw_mux
drivers/clk/imx/clk-imx6ul.c:489:32: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
   hws[IMX6UL_CLK_ENET1_REF_SEL] = imx_clk_gpr_mux("enet1_ref_sel", "fsl,imx6ul-iomuxc-gpr",
                                 ^
drivers/clk/imx/clk-imx6ul.c:492:32: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
   hws[IMX6UL_CLK_ENET2_REF_PAD] = imx_obtain_fixed_of_clock(ccm_node, "enet2_ref_pad", 0);
                                 ^
drivers/clk/imx/clk-imx6ul.c:494:32: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
   hws[IMX6UL_CLK_ENET2_REF_SEL] = imx_clk_gpr_mux("enet2_ref_sel", "fsl,imx6ul-iomuxc-gpr",


Jon

-- 
nvpublic

Re: [PATCH 6.1 000/798] 6.1.113-rc1 review

[Jon Hunter]

On 15/10/2024 06:31, Jon Hunter wrote:
> Hi Greg,
> 
> On 14/10/2024 15:09, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 6.1.113 release.
>> There are 798 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Wed, 16 Oct 2024 14:09:57 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>>     https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.113-rc1.gz
>> or in the git tree and branch at:
>>     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>>
>> -------------
>> Pseudo-Shortlog of commits:
> 
> ...
> 
>> Oleksij Rempel <linux@rempel-privat.de>
>>      clk: imx6ul: add ethernet refclock mux support
> 
> 
> I am seeing the following build issue for ARM multi_v7_defconfig and
> bisect is point to the commit ...

To be clear, I meant the 'above' commit.

Jon

-- 
nvpublic

Re: [PATCH 6.1 000/798] 6.1.113-rc1 review

[Greg Kroah-Hartman]

On Tue, Oct 15, 2024 at 06:50:43AM +0100, Jon Hunter wrote:
> 
> On 15/10/2024 06:31, Jon Hunter wrote:
> > Hi Greg,
> > 
> > On 14/10/2024 15:09, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 6.1.113 release.
> > > There are 798 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > > 
> > > Responses should be made by Wed, 16 Oct 2024 14:09:57 +0000.
> > > Anything received after that time might be too late.
> > > 
> > > The whole patch series can be found in one patch at:
> > >     https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.113-rc1.gz
> > > or in the git tree and branch at:
> > >     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> > > and the diffstat can be found below.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > > 
> > > -------------
> > > Pseudo-Shortlog of commits:
> > 
> > ...
> > 
> > > Oleksij Rempel <linux@rempel-privat.de>
> > >      clk: imx6ul: add ethernet refclock mux support
> > 
> > 
> > I am seeing the following build issue for ARM multi_v7_defconfig and
> > bisect is point to the commit ...
> 
> To be clear, I meant the 'above' commit.

Thanks, let me go drop this (and the other ones around it) and push out
some -rc2 releases.

greg k-h

Re: [PATCH 6.1 000/798] 6.1.113-rc1 review

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

Hi!

> > -------------
> > Pseudo-Shortlog of commits:
> 
> ...
> > Oleksij Rempel <linux@rempel-privat.de>
> >      clk: imx6ul: add ethernet refclock mux support
> 
> 
> I am seeing the following build issue for ARM multi_v7_defconfig and
> bisect is point to the commit ...
> 
> drivers/clk/imx/clk-imx6ul.c: In function ‘imx6ul_clocks_init’:
> drivers/clk/imx/clk-imx6ul.c:487:34: error: implicit declaration of function ‘imx_obtain_fixed_of_clock’; did you mean ‘imx_obtain_fixed_clock’? [-Werror=implicit-function-declaration]
>   hws[IMX6UL_CLK_ENET1_REF_PAD] = imx_obtain_fixed_of_clock(ccm_node, "enet1_ref_pad", 0);
>                                   ^~~~~~~~~~~~~~~~~~~~~~~~~
>                                   imx_obtain_fixed_clock

CIP testing sees same problem:

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/8083991401

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH 6.1 000/798] 6.1.113-rc1 review

[Geert Uytterhoeven]

On Tue, Oct 15, 2024 at 7:32 AM Jon Hunter <jonathanh@nvidia.com> wrote:
> On 14/10/2024 15:09, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 6.1.113 release.
> > There are 798 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 16 Oct 2024 14:09:57 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >       https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.113-rc1.gz
> > or in the git tree and branch at:
> >       git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> >
> > -------------
> > Pseudo-Shortlog of commits:
>
> ...
>
> > Oleksij Rempel <linux@rempel-privat.de>
> >      clk: imx6ul: add ethernet refclock mux support
>
>
> I am seeing the following build issue for ARM multi_v7_defconfig and
> bisect is point to the commit ...
>
> drivers/clk/imx/clk-imx6ul.c: In function ‘imx6ul_clocks_init’:
> drivers/clk/imx/clk-imx6ul.c:487:34: error: implicit declaration of function ‘imx_obtain_fixed_of_clock’; did you mean ‘imx_obtain_fixed_clock’? [-Werror=implicit-function-declaration]
>    hws[IMX6UL_CLK_ENET1_REF_PAD] = imx_obtain_fixed_of_clock(ccm_node, "enet1_ref_pad", 0);
>                                    ^~~~~~~~~~~~~~~~~~~~~~~~~
>                                    imx_obtain_fixed_clock
> drivers/clk/imx/clk-imx6ul.c:487:32: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>    hws[IMX6UL_CLK_ENET1_REF_PAD] = imx_obtain_fixed_of_clock(ccm_node, "enet1_ref_pad", 0);
>                                  ^
> drivers/clk/imx/clk-imx6ul.c:489:34: error: implicit declaration of function ‘imx_clk_gpr_mux’; did you mean ‘imx_clk_hw_mux’? [-Werror=implicit-function-declaration]
>    hws[IMX6UL_CLK_ENET1_REF_SEL] = imx_clk_gpr_mux("enet1_ref_sel", "fsl,imx6ul-iomuxc-gpr",
>                                    ^~~~~~~~~~~~~~~
>                                    imx_clk_hw_mux
> drivers/clk/imx/clk-imx6ul.c:489:32: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>    hws[IMX6UL_CLK_ENET1_REF_SEL] = imx_clk_gpr_mux("enet1_ref_sel", "fsl,imx6ul-iomuxc-gpr",
>                                  ^
> drivers/clk/imx/clk-imx6ul.c:492:32: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>    hws[IMX6UL_CLK_ENET2_REF_PAD] = imx_obtain_fixed_of_clock(ccm_node, "enet2_ref_pad", 0);
>                                  ^
> drivers/clk/imx/clk-imx6ul.c:494:32: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>    hws[IMX6UL_CLK_ENET2_REF_SEL] = imx_clk_gpr_mux("enet2_ref_sel", "fsl,imx6ul-iomuxc-gpr",

Missing backports of the other clock-related patches in the original
series[1]?
imx_obtain_fixed_clock() was introduced in commit 7757731053406dd0
("clk: imx: add imx_obtain_fixed_of_clock()"), but some of the other
patches from that series may be needed, too?

[1] https://lore.kernel.org/all/20230131084642.709385-1-o.rempel@pengutronix.de/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 6.1 000/798] 6.1.113-rc1 review

[Geert Uytterhoeven]

CC Oleksij

On Tue, Oct 15, 2024 at 9:06 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Tue, Oct 15, 2024 at 7:32 AM Jon Hunter <jonathanh@nvidia.com> wrote:
> > On 14/10/2024 15:09, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 6.1.113 release.
> > > There are 798 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Wed, 16 Oct 2024 14:09:57 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > >       https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.113-rc1.gz
> > > or in the git tree and branch at:
> > >       git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> > >
> > > -------------
> > > Pseudo-Shortlog of commits:
> >
> > ...
> >
> > > Oleksij Rempel <linux@rempel-privat.de>
> > >      clk: imx6ul: add ethernet refclock mux support
> >
> >
> > I am seeing the following build issue for ARM multi_v7_defconfig and
> > bisect is point to the commit ...
> >
> > drivers/clk/imx/clk-imx6ul.c: In function ‘imx6ul_clocks_init’:
> > drivers/clk/imx/clk-imx6ul.c:487:34: error: implicit declaration of function ‘imx_obtain_fixed_of_clock’; did you mean ‘imx_obtain_fixed_clock’? [-Werror=implicit-function-declaration]
> >    hws[IMX6UL_CLK_ENET1_REF_PAD] = imx_obtain_fixed_of_clock(ccm_node, "enet1_ref_pad", 0);
> >                                    ^~~~~~~~~~~~~~~~~~~~~~~~~
> >                                    imx_obtain_fixed_clock
> > drivers/clk/imx/clk-imx6ul.c:487:32: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> >    hws[IMX6UL_CLK_ENET1_REF_PAD] = imx_obtain_fixed_of_clock(ccm_node, "enet1_ref_pad", 0);
> >                                  ^
> > drivers/clk/imx/clk-imx6ul.c:489:34: error: implicit declaration of function ‘imx_clk_gpr_mux’; did you mean ‘imx_clk_hw_mux’? [-Werror=implicit-function-declaration]
> >    hws[IMX6UL_CLK_ENET1_REF_SEL] = imx_clk_gpr_mux("enet1_ref_sel", "fsl,imx6ul-iomuxc-gpr",
> >                                    ^~~~~~~~~~~~~~~
> >                                    imx_clk_hw_mux
> > drivers/clk/imx/clk-imx6ul.c:489:32: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> >    hws[IMX6UL_CLK_ENET1_REF_SEL] = imx_clk_gpr_mux("enet1_ref_sel", "fsl,imx6ul-iomuxc-gpr",
> >                                  ^
> > drivers/clk/imx/clk-imx6ul.c:492:32: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> >    hws[IMX6UL_CLK_ENET2_REF_PAD] = imx_obtain_fixed_of_clock(ccm_node, "enet2_ref_pad", 0);
> >                                  ^
> > drivers/clk/imx/clk-imx6ul.c:494:32: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> >    hws[IMX6UL_CLK_ENET2_REF_SEL] = imx_clk_gpr_mux("enet2_ref_sel", "fsl,imx6ul-iomuxc-gpr",
>
> Missing backports of the other clock-related patches in the original
> series[1]?
> imx_obtain_fixed_clock() was introduced in commit 7757731053406dd0
> ("clk: imx: add imx_obtain_fixed_of_clock()"), but some of the other
> patches from that series may be needed, too?
>
> [1] https://lore.kernel.org/all/20230131084642.709385-1-o.rempel@pengutronix.de/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 6.1 000/798] 6.1.113-rc1 review

[Oleksij Rempel]

Hi all,

On Tue, Oct 15, 2024 at 09:07:14AM +0200, Geert Uytterhoeven wrote:
> CC Oleksij
> 
> On Tue, Oct 15, 2024 at 9:06 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Tue, Oct 15, 2024 at 7:32 AM Jon Hunter <jonathanh@nvidia.com> wrote:
> > > On 14/10/2024 15:09, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 6.1.113 release.
> > > > There are 798 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Wed, 16 Oct 2024 14:09:57 +0000.
> > > > Anything received after that time might be too late.
> > > >
> > > > The whole patch series can be found in one patch at:
> > > >       https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.113-rc1.gz
> > > > or in the git tree and branch at:
> > > >       git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> > > > and the diffstat can be found below.
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > > >
> > > > -------------
> > > > Pseudo-Shortlog of commits:
> > >
> > > ...
> > >
> > > > Oleksij Rempel <linux@rempel-privat.de>
> > > >      clk: imx6ul: add ethernet refclock mux support
> > >
> > >
> > > I am seeing the following build issue for ARM multi_v7_defconfig and
> > > bisect is point to the commit ...
> > >
> > > drivers/clk/imx/clk-imx6ul.c: In function ‘imx6ul_clocks_init’:
> > > drivers/clk/imx/clk-imx6ul.c:487:34: error: implicit declaration of function ‘imx_obtain_fixed_of_clock’; did you mean ‘imx_obtain_fixed_clock’? [-Werror=implicit-function-declaration]
> > >    hws[IMX6UL_CLK_ENET1_REF_PAD] = imx_obtain_fixed_of_clock(ccm_node, "enet1_ref_pad", 0);
> > >                                    ^~~~~~~~~~~~~~~~~~~~~~~~~
> > >                                    imx_obtain_fixed_clock
> > > drivers/clk/imx/clk-imx6ul.c:487:32: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> > >    hws[IMX6UL_CLK_ENET1_REF_PAD] = imx_obtain_fixed_of_clock(ccm_node, "enet1_ref_pad", 0);
> > >                                  ^
> > > drivers/clk/imx/clk-imx6ul.c:489:34: error: implicit declaration of function ‘imx_clk_gpr_mux’; did you mean ‘imx_clk_hw_mux’? [-Werror=implicit-function-declaration]
> > >    hws[IMX6UL_CLK_ENET1_REF_SEL] = imx_clk_gpr_mux("enet1_ref_sel", "fsl,imx6ul-iomuxc-gpr",
> > >                                    ^~~~~~~~~~~~~~~
> > >                                    imx_clk_hw_mux
> > > drivers/clk/imx/clk-imx6ul.c:489:32: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> > >    hws[IMX6UL_CLK_ENET1_REF_SEL] = imx_clk_gpr_mux("enet1_ref_sel", "fsl,imx6ul-iomuxc-gpr",
> > >                                  ^
> > > drivers/clk/imx/clk-imx6ul.c:492:32: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> > >    hws[IMX6UL_CLK_ENET2_REF_PAD] = imx_obtain_fixed_of_clock(ccm_node, "enet2_ref_pad", 0);
> > >                                  ^
> > > drivers/clk/imx/clk-imx6ul.c:494:32: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> > >    hws[IMX6UL_CLK_ENET2_REF_SEL] = imx_clk_gpr_mux("enet2_ref_sel", "fsl,imx6ul-iomuxc-gpr",
> >
> > Missing backports of the other clock-related patches in the original
> > series[1]?
> > imx_obtain_fixed_clock() was introduced in commit 7757731053406dd0
> > ("clk: imx: add imx_obtain_fixed_of_clock()"), but some of the other
> > patches from that series may be needed, too?
> >
> > [1] https://lore.kernel.org/all/20230131084642.709385-1-o.rempel@pengutronix.de/

Yes, I agree, at least commit 7757731053406dd0 is missing. Other patches
in [1] series are only interesting if corresponding device trees was
upstream.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |