* [PATCH AUTOSEL 6.12 09/15] phy: tegra: xusb: Set fwnode for xusb port devices [not found] <20241204221627.2247598-1-sashal@kernel.org> @ 2024-12-04 22:16 ` Sasha Levin 2024-12-06 0:06 ` Saravana Kannan 0 siblings, 1 reply; 2+ messages in thread From: Sasha Levin @ 2024-12-04 22:16 UTC (permalink / raw) To: linux-kernel, stable Cc: Saravana Kannan, Jon Hunter, Nícolas F . R . A . Prado, Thierry Reding, Greg Kroah-Hartman, Sasha Levin, jckuo, vkoul, kishon, thierry.reding, linux-phy, linux-tegra From: Saravana Kannan <saravanak@google.com> [ Upstream commit 74ffe43bad3af3e2a786ca017c205555ba87ebad ] fwnode needs to be set for a device for fw_devlink to be able to track/enforce its dependencies correctly. Without this, you'll see error messages like this when the supplier has probed and tries to make sure all its fwnode consumers are linked to it using device links: tegra-xusb-padctl 3520000.padctl: Failed to create device link (0x180) with 1-0008 Reported-by: Jon Hunter <jonathanh@nvidia.com> Closes: https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@nvidia.com/ Tested-by: Jon Hunter <jonathanh@nvidia.com> Suggested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Signed-off-by: Saravana Kannan <saravanak@google.com> Acked-by: Thierry Reding <treding@nvidia.com> Link: https://lore.kernel.org/r/20241024061347.1771063-3-saravanak@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/phy/tegra/xusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c index 342f5ccf611d8..d536998288acb 100644 --- a/drivers/phy/tegra/xusb.c +++ b/drivers/phy/tegra/xusb.c @@ -543,7 +543,7 @@ static int tegra_xusb_port_init(struct tegra_xusb_port *port, device_initialize(&port->dev); port->dev.type = &tegra_xusb_port_type; - port->dev.of_node = of_node_get(np); + device_set_node(&port->dev, of_fwnode_handle(of_node_get(np))); port->dev.parent = padctl->dev; err = dev_set_name(&port->dev, "%s-%u", name, index); -- 2.43.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH AUTOSEL 6.12 09/15] phy: tegra: xusb: Set fwnode for xusb port devices 2024-12-04 22:16 ` [PATCH AUTOSEL 6.12 09/15] phy: tegra: xusb: Set fwnode for xusb port devices Sasha Levin @ 2024-12-06 0:06 ` Saravana Kannan 0 siblings, 0 replies; 2+ messages in thread From: Saravana Kannan @ 2024-12-06 0:06 UTC (permalink / raw) To: Sasha Levin Cc: linux-kernel, stable, Jon Hunter, Nícolas F . R . A . Prado, Thierry Reding, Greg Kroah-Hartman, jckuo, vkoul, kishon, thierry.reding, linux-phy, linux-tegra On Wed, Dec 4, 2024 at 3:28 PM Sasha Levin <sashal@kernel.org> wrote: > > From: Saravana Kannan <saravanak@google.com> > > [ Upstream commit 74ffe43bad3af3e2a786ca017c205555ba87ebad ] > > fwnode needs to be set for a device for fw_devlink to be able to > track/enforce its dependencies correctly. Without this, you'll see error > messages like this when the supplier has probed and tries to make sure > all its fwnode consumers are linked to it using device links: > > tegra-xusb-padctl 3520000.padctl: Failed to create device link (0x180) with 1-0008 > > Reported-by: Jon Hunter <jonathanh@nvidia.com> > Closes: https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@nvidia.com/ > Tested-by: Jon Hunter <jonathanh@nvidia.com> > Suggested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > Signed-off-by: Saravana Kannan <saravanak@google.com> > Acked-by: Thierry Reding <treding@nvidia.com> > Link: https://lore.kernel.org/r/20241024061347.1771063-3-saravanak@google.com > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Sasha Levin <sashal@kernel.org> I'm okay pulling this into 6.12 as it's recent enough. -Saravana > --- > drivers/phy/tegra/xusb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c > index 342f5ccf611d8..d536998288acb 100644 > --- a/drivers/phy/tegra/xusb.c > +++ b/drivers/phy/tegra/xusb.c > @@ -543,7 +543,7 @@ static int tegra_xusb_port_init(struct tegra_xusb_port *port, > > device_initialize(&port->dev); > port->dev.type = &tegra_xusb_port_type; > - port->dev.of_node = of_node_get(np); > + device_set_node(&port->dev, of_fwnode_handle(of_node_get(np))); > port->dev.parent = padctl->dev; > > err = dev_set_name(&port->dev, "%s-%u", name, index); > -- > 2.43.0 > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-06 0:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20241204221627.2247598-1-sashal@kernel.org>
2024-12-04 22:16 ` [PATCH AUTOSEL 6.12 09/15] phy: tegra: xusb: Set fwnode for xusb port devices Sasha Levin
2024-12-06 0:06 ` Saravana Kannan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox