[PATCH] arm64: tegra: Enable Tegra234 USB remote wakeup

[PATCH] arm64: tegra: Enable Tegra234 USB remote wakeup

[Ivy Huang]

From: Haotien Hsu <haotienh@nvidia.com>

Populate the USB wake-up interrupts for Tegra234 to enable
the USB device to wake the system up from low power modes.

Signed-off-by: Henry Lin <henryl@nvidia.com>
Signed-off-by: Wayne Chang <waynec@nvidia.com>
Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
Signed-off-by: Ivy Huang <yijuh@nvidia.com>
---
 arch/arm64/boot/dts/nvidia/tegra234.dtsi | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
index 2601b43b2d8c..bbd5f7c2bf03 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
@@ -3254,8 +3254,22 @@
 			      <0x0 0x03650000 0x0 0x10000>;
 			reg-names = "hcd", "fpci", "bar2";
 
-			interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
-				     <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
+			interrupts-extended = <&gic GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
+					      <&gic GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>,
+					      <&pmc 76 IRQ_TYPE_LEVEL_HIGH>,
+					      <&pmc 77 IRQ_TYPE_LEVEL_HIGH>,
+					      <&pmc 78 IRQ_TYPE_LEVEL_HIGH>,
+					      <&pmc 79 IRQ_TYPE_LEVEL_HIGH>,
+					      <&pmc 80 IRQ_TYPE_LEVEL_HIGH>,
+					      <&pmc 81 IRQ_TYPE_LEVEL_HIGH>,
+					      <&pmc 82 IRQ_TYPE_LEVEL_HIGH>;
+			/*
+			 * wake0, wake1, wake2 are for USB3.0 ports
+			 * wake3, wake4, wake5, wake6 are for USB2.0 ports
+			 */
+			interrupt-names = "xhci", "mbox",
+				  "wake0", "wake1", "wake2", "wake3",
+				  "wake4", "wake5", "wake6";
 
 			clocks = <&bpmp TEGRA234_CLK_XUSB_CORE_HOST>,
 				 <&bpmp TEGRA234_CLK_XUSB_FALCON>,
-- 
2.17.1

Re: [PATCH] arm64: tegra: Enable Tegra234 USB remote wakeup

[Rob Herring (Arm)]

On Thu, 06 Feb 2025 22:27:31 +0000, Ivy Huang wrote:
> From: Haotien Hsu <haotienh@nvidia.com>
> 
> Populate the USB wake-up interrupts for Tegra234 to enable
> the USB device to wake the system up from low power modes.
> 
> Signed-off-by: Henry Lin <henryl@nvidia.com>
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
> Signed-off-by: Ivy Huang <yijuh@nvidia.com>
> ---
>  arch/arm64/boot/dts/nvidia/tegra234.dtsi | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/nvidia/' for 20250206222731.3691073-1-yijuh@nvidia.com:

arch/arm64/boot/dts/nvidia/tegra234-sim-vdk.dtb: usb@3610000: interrupts-extended: [[1, 0, 163, 4], [1, 0, 164, 4], [242, 76, 4], [242, 77, 4], [242, 78, 4], [242, 79, 4], [242, 80, 4], [242, 81, 4], [242, 82, 4]] is too long
	from schema $id: http://devicetree.org/schemas/usb/nvidia,tegra234-xusb.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: usb@3610000: interrupts-extended: [[1, 0, 163, 4], [1, 0, 164, 4], [256, 76, 4], [256, 77, 4], [256, 78, 4], [256, 79, 4], [256, 80, 4], [256, 81, 4], [256, 82, 4]] is too long
	from schema $id: http://devicetree.org/schemas/usb/nvidia,tegra234-xusb.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: usb@3610000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts-extended' were unexpected)
	from schema $id: http://devicetree.org/schemas/usb/nvidia,tegra234-xusb.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0005.dtb: usb@3610000: interrupts-extended: [[1, 0, 163, 4], [1, 0, 164, 4], [251, 76, 4], [251, 77, 4], [251, 78, 4], [251, 79, 4], [251, 80, 4], [251, 81, 4], [251, 82, 4]] is too long
	from schema $id: http://devicetree.org/schemas/usb/nvidia,tegra234-xusb.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0005.dtb: usb@3610000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts-extended' were unexpected)
	from schema $id: http://devicetree.org/schemas/usb/nvidia,tegra234-xusb.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dtb: usb@3610000: interrupts-extended: [[1, 0, 163, 4], [1, 0, 164, 4], [251, 76, 4], [251, 77, 4], [251, 78, 4], [251, 79, 4], [251, 80, 4], [251, 81, 4], [251, 82, 4]] is too long
	from schema $id: http://devicetree.org/schemas/usb/nvidia,tegra234-xusb.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dtb: usb@3610000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts-extended' were unexpected)
	from schema $id: http://devicetree.org/schemas/usb/nvidia,tegra234-xusb.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dtb: usb@3610000: interrupts-extended: [[1, 0, 163, 4], [1, 0, 164, 4], [256, 76, 4], [256, 77, 4], [256, 78, 4], [256, 79, 4], [256, 80, 4], [256, 81, 4], [256, 82, 4]] is too long
	from schema $id: http://devicetree.org/schemas/usb/nvidia,tegra234-xusb.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dtb: usb@3610000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts-extended' were unexpected)
	from schema $id: http://devicetree.org/schemas/usb/nvidia,tegra234-xusb.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dtb: usb@3610000: interrupts-extended: [[1, 0, 163, 4], [1, 0, 164, 4], [252, 76, 4], [252, 77, 4], [252, 78, 4], [252, 79, 4], [252, 80, 4], [252, 81, 4], [252, 82, 4]] is too long
	from schema $id: http://devicetree.org/schemas/usb/nvidia,tegra234-xusb.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dtb: usb@3610000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts-extended' were unexpected)
	from schema $id: http://devicetree.org/schemas/usb/nvidia,tegra234-xusb.yaml#

Re: [PATCH] arm64: tegra: Enable Tegra234 USB remote wakeup

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 2114 bytes --]

On Thu, Feb 06, 2025 at 10:27:31PM +0000, Ivy Huang wrote:
> From: Haotien Hsu <haotienh@nvidia.com>
> 
> Populate the USB wake-up interrupts for Tegra234 to enable
> the USB device to wake the system up from low power modes.
> 
> Signed-off-by: Henry Lin <henryl@nvidia.com>
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
> Signed-off-by: Ivy Huang <yijuh@nvidia.com>
> ---
>  arch/arm64/boot/dts/nvidia/tegra234.dtsi | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> index 2601b43b2d8c..bbd5f7c2bf03 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> @@ -3254,8 +3254,22 @@
>  			      <0x0 0x03650000 0x0 0x10000>;
>  			reg-names = "hcd", "fpci", "bar2";
>  
> -			interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
> -				     <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupts-extended = <&gic GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&gic GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&pmc 76 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&pmc 77 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&pmc 78 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&pmc 79 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&pmc 80 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&pmc 81 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&pmc 82 IRQ_TYPE_LEVEL_HIGH>;
> +			/*
> +			 * wake0, wake1, wake2 are for USB3.0 ports
> +			 * wake3, wake4, wake5, wake6 are for USB2.0 ports
> +			 */
> +			interrupt-names = "xhci", "mbox",
> +				  "wake0", "wake1", "wake2", "wake3",
> +				  "wake4", "wake5", "wake6";

This needs a bindings update because both of these properties aren't
currently allowed. Also, do we need additional handling in the driver to
make the wake events work, or does this work automatically?

At the very least I think we would also need a patch to add the
corresponding wake events to the PMC driver, otherwise these are
probably not going to do anything.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] arm64: tegra: Enable Tegra234 USB remote wakeup

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>


On Thu, 06 Feb 2025 22:27:31 +0000, Ivy Huang wrote:
> Populate the USB wake-up interrupts for Tegra234 to enable
> the USB device to wake the system up from low power modes.
> 
> 

Applied, thanks!

[1/1] arm64: tegra: Enable Tegra234 USB remote wakeup
      commit: e6709a6f78132468d18e56e201d6ed313624b78b

Best regards,
-- 
Thierry Reding <treding@nvidia.com>

Re: [PATCH] arm64: tegra: Enable Tegra234 USB remote wakeup

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

On Thu, Mar 06, 2025 at 07:08:07PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> 
> On Thu, 06 Feb 2025 22:27:31 +0000, Ivy Huang wrote:
> > Populate the USB wake-up interrupts for Tegra234 to enable
> > the USB device to wake the system up from low power modes.
> > 
> > 
> 
> Applied, thanks!
> 
> [1/1] arm64: tegra: Enable Tegra234 USB remote wakeup
>       commit: e6709a6f78132468d18e56e201d6ed313624b78b

Nevermind, I applied this by mistake. Changes are needed for this, so
I've backed this out again.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]