[PATCH] arm64: tegra: delete the Orin NX/Nano suspend key

[PATCH] arm64: tegra: delete the Orin NX/Nano suspend key

[Ivy Huang]

From: Ninad Malwade <nmalwade@nvidia.com>

As per the Orin Nano Dev Kit schematic, GPIO_G.02 is not available
on this device family. It should not be used at all on Orin NX/Nano.
Having this unused pin mapped as the suspend key can lead to
unpredictable behavior for low power modes.

Orin NX/Nano uses GPIO_EE.04 as both a "power" button and a "suspend"
button.  However, we cannot have two gpio-keys mapped to the same
GPIO. Therefore delete the "suspend" key.

Cc: stable@vger.kernel.org
Fixes: e63472eda5ea ("arm64: tegra: Support Jetson Orin NX reference platform")
Signed-off-by: Ninad Malwade <nmalwade@nvidia.com>
Signed-off-by: Ivy Huang <yijuh@nvidia.com>
---
 arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi
index 19340d13f789..41821354bbda 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi
@@ -227,13 +227,6 @@
 			wakeup-event-action = <EV_ACT_ASSERTED>;
 			wakeup-source;
 		};
-
-		key-suspend {
-			label = "Suspend";
-			gpios = <&gpio TEGRA234_MAIN_GPIO(G, 2) GPIO_ACTIVE_LOW>;
-			linux,input-type = <EV_KEY>;
-			linux,code = <KEY_SLEEP>;
-		};
 	};
 
 	fan: pwm-fan {
-- 
2.17.1

Re: [PATCH] arm64: tegra: delete the Orin NX/Nano suspend key

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>


On Thu, 06 Feb 2025 22:40:34 +0000, Ivy Huang wrote:
> As per the Orin Nano Dev Kit schematic, GPIO_G.02 is not available
> on this device family. It should not be used at all on Orin NX/Nano.
> Having this unused pin mapped as the suspend key can lead to
> unpredictable behavior for low power modes.
> 
> Orin NX/Nano uses GPIO_EE.04 as both a "power" button and a "suspend"
> button.  However, we cannot have two gpio-keys mapped to the same
> GPIO. Therefore delete the "suspend" key.
> 
> [...]

Applied, thanks!

[1/1] arm64: tegra: delete the Orin NX/Nano suspend key
      commit: c695ff32564a4e9532f2c1892ef0a7cb27cfb34c

Best regards,
-- 
Thierry Reding <treding@nvidia.com>