* [PATCH] staging: nvec: silence macro argument warnings in NVEC_PHD()
@ 2025-07-04 15:27 Emre Cecanpunar
2025-07-09 11:06 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Emre Cecanpunar @ 2025-07-04 15:27 UTC (permalink / raw)
To: gregkh, linux-staging
Cc: linux-tegra, marvin24, linux-kernel, Emre Cecanpunar
checkpatch.pl warns that the NVEC_PHD macro defines unused arguments.
Use (void) casts to prevent unused argument warnings when the macro is disabled.
Signed-off-by: Emre Cecanpunar <emreleno@gmail.com>
---
drivers/staging/nvec/nvec_ps2.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/nvec/nvec_ps2.c b/drivers/staging/nvec/nvec_ps2.c
index 575233fa1677..38e736b3761e 100644
--- a/drivers/staging/nvec/nvec_ps2.c
+++ b/drivers/staging/nvec/nvec_ps2.c
@@ -28,7 +28,11 @@
print_hex_dump(KERN_DEBUG, str, DUMP_PREFIX_NONE, \
16, 1, buf, len, false)
#else
-#define NVEC_PHD(str, buf, len) do { } while (0)
+#define NVEC_PHD(str, buf, len) do { \
+ (void)(str); \
+ (void)(buf); \
+ (void)(len); \
+} while (0)
#endif
enum ps2_subcmds {
--
2.50.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: nvec: silence macro argument warnings in NVEC_PHD()
2025-07-04 15:27 [PATCH] staging: nvec: silence macro argument warnings in NVEC_PHD() Emre Cecanpunar
@ 2025-07-09 11:06 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2025-07-09 11:06 UTC (permalink / raw)
To: Emre Cecanpunar; +Cc: linux-staging, linux-tegra, marvin24, linux-kernel
On Fri, Jul 04, 2025 at 06:27:37PM +0300, Emre Cecanpunar wrote:
> checkpatch.pl warns that the NVEC_PHD macro defines unused arguments.
> Use (void) casts to prevent unused argument warnings when the macro is disabled.
>
> Signed-off-by: Emre Cecanpunar <emreleno@gmail.com>
> ---
> drivers/staging/nvec/nvec_ps2.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/nvec/nvec_ps2.c b/drivers/staging/nvec/nvec_ps2.c
> index 575233fa1677..38e736b3761e 100644
> --- a/drivers/staging/nvec/nvec_ps2.c
> +++ b/drivers/staging/nvec/nvec_ps2.c
> @@ -28,7 +28,11 @@
> print_hex_dump(KERN_DEBUG, str, DUMP_PREFIX_NONE, \
> 16, 1, buf, len, false)
> #else
> -#define NVEC_PHD(str, buf, len) do { } while (0)
> +#define NVEC_PHD(str, buf, len) do { \
> + (void)(str); \
> + (void)(buf); \
> + (void)(len); \
> +} while (0)
This is really not needed at all, sorry. Especially for a define that
will never even be used. Can you work to remove NVEC_PS2_DEBUG instead,
as that's not a good idea.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-09 11:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-04 15:27 [PATCH] staging: nvec: silence macro argument warnings in NVEC_PHD() Emre Cecanpunar
2025-07-09 11:06 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox