Re: [PATCH 5.4 000/187] 5.4.302-rc1 review

Re: [PATCH 5.4 000/187] 5.4.302-rc1 review

[Jon Hunter]

Hi Greg,

On 01/12/2025 11:21, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.302 release.
> There are 187 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Wed, 03 Dec 2025 11:22:11 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.302-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h

...

> Fabio M. De Francesco <fabio.maria.de.francesco@linux.intel.com>
>      mm/mempool: replace kmap_atomic() with kmap_local_page()


The above commit is causing the following build errors ...

kernel/mm/mempool.c: In function 'check_element':
kernel/mm/mempool.c:69:17: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
    69 |                 for (int i = 0; i < (1 << order); i++) {
       |                 ^~~
kernel/mm/mempool.c:69:17: note: use option '-std=c99', '-std=gnu99', '-std=c11' or '-std=gnu11' to compile your code
kernel/mm/mempool.c:71:38: error: implicit declaration of function 'kmap_local_page'; did you mean 'kmap_to_page'? [-Werror=implicit-function-declaration]
    71 |                         void *addr = kmap_local_page(page + i);
       |                                      ^~~~~~~~~~~~~~~
       |                                      kmap_to_page
kernel/mm/mempool.c:71:38: warning: initialization of 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
kernel/mm/mempool.c:74:25: error: implicit declaration of function 'kunmap_local' [-Werror=implicit-function-declaration]
    74 |                         kunmap_local(addr);
       |                         ^~~~~~~~~~~~
kernel/mm/mempool.c: In function 'poison_element':
kernel/mm/mempool.c:103:17: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
   103 |                 for (int i = 0; i < (1 << order); i++) {
       |                 ^~~
kernel/mm/mempool.c:105:38: warning: initialization of 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
   105 |                         void *addr = kmap_local_page(page + i);
       |                                      ^~~~~~~~~~~~~~~


I am seeing this with ARM builds using the tegra_defconfig.

Jon

-- 
nvpublic

Re: [PATCH 5.4 000/187] 5.4.302-rc1 review

[Greg Kroah-Hartman]

On Tue, Dec 02, 2025 at 06:24:08AM +0000, Jon Hunter wrote:
> Hi Greg,
> 
> On 01/12/2025 11:21, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.4.302 release.
> > There are 187 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Wed, 03 Dec 2025 11:22:11 +0000.
> > Anything received after that time might be too late.
> > 
> > The whole patch series can be found in one patch at:
> > 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.302-rc1.gz
> > or in the git tree and branch at:
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > and the diffstat can be found below.
> > 
> > thanks,
> > 
> > greg k-h
> 
> ...
> 
> > Fabio M. De Francesco <fabio.maria.de.francesco@linux.intel.com>
> >      mm/mempool: replace kmap_atomic() with kmap_local_page()
> 
> 
> The above commit is causing the following build errors ...
> 
> kernel/mm/mempool.c: In function 'check_element':
> kernel/mm/mempool.c:69:17: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
>    69 |                 for (int i = 0; i < (1 << order); i++) {
>       |                 ^~~
> kernel/mm/mempool.c:69:17: note: use option '-std=c99', '-std=gnu99', '-std=c11' or '-std=gnu11' to compile your code
> kernel/mm/mempool.c:71:38: error: implicit declaration of function 'kmap_local_page'; did you mean 'kmap_to_page'? [-Werror=implicit-function-declaration]
>    71 |                         void *addr = kmap_local_page(page + i);
>       |                                      ^~~~~~~~~~~~~~~
>       |                                      kmap_to_page
> kernel/mm/mempool.c:71:38: warning: initialization of 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> kernel/mm/mempool.c:74:25: error: implicit declaration of function 'kunmap_local' [-Werror=implicit-function-declaration]
>    74 |                         kunmap_local(addr);
>       |                         ^~~~~~~~~~~~
> kernel/mm/mempool.c: In function 'poison_element':
> kernel/mm/mempool.c:103:17: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
>   103 |                 for (int i = 0; i < (1 << order); i++) {
>       |                 ^~~
> kernel/mm/mempool.c:105:38: warning: initialization of 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>   105 |                         void *addr = kmap_local_page(page + i);
>       |                                      ^~~~~~~~~~~~~~~
> 
> 
> I am seeing this with ARM builds using the tegra_defconfig.

Ah, odd I missed this, looks like it needs HIGHMEM enabled.  I'll go
drop 2 of these patches that cause this and will push out a -rc2, thanks
for testing!

greg k-h